inspector/clients/tui/__tests__
Repository files (latest commit first)
Filename Latest commit message Latest commit date
cliffhall 799763543f fix: address Copilot review round 4 on #2248
Eight findings. Two were visible in a terminal capture I had already taken
and read past.

**A digest mismatch rendered with no digests.** `verifySkillResource` sets
`reason` for a SIZE mismatch — which short-circuits before hashing — while a
digest mismatch carries `expectedDigest` / `actualDigest` and no `reason`, so
the TUI printed a bare `✗ notes.md` with nothing to act on. `failureDetail`
now falls back to the expected/actual pair, truncated to fit the pane.

**A dynamic skill's read failure rendered nowhere.** Its synthetic
`read-error` row lives in the report, not the manifest, and the manifest is
empty for such a skill by definition — so the pane said only "Verification
FAILED". There is a Read failures block for any report file the manifest does
not cover, matched on normalized identity.

**The non-finite sentinel could be aliased.** A listing whose value genuinely
was `{"#non-finite":"NaN"}` canonicalized identically to a served `.nan`, so
the round-3 fix moved the bug rather than closing it. Any encoding into the
value space can be aliased by a document containing the encoding, so the
comparison is structural now (`jsonLikeEqual`) and there is no sentinel at
all; `Object.is` gives NaN === NaN while keeping ±Infinity distinct.
Serialization is used only for the message.

**`parseSkillFrontmatter("null")` returned `{ fields: {} }`,** contradicting
its own non-mapping contract: an explicit null scalar parses to exactly what
an empty block does. They are told apart by the source, since the parsed
value cannot.

Also: the `files` doc comment still claimed it is empty for a dynamic skill,
which the round-2 fix made untrue; and three inline Mantine elements with two
static styling props each are extracted to `.withProps()` constants, per the
convention the rest of the file follows.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ND46Ci64DC3tzBy9aG81Nc
Signed-off-by: cliffhall <cliff@futurescale.com>
2026-09-07 19:55:17 -04:00
..
helpers fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
App.test.tsx fix: address Copilot review round 1 on #2248 2026-09-07 18:43:58 -04:00
AuthTab.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
DetailsModal.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
HistoryTab.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
InfoTab.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
logger.test.ts test: raise per-file coverage gate to 90 across all clients (closes #1271) (#1532) 2026-06-27 15:26:03 -04:00
NotificationsTab.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
oauthDisplay.test.ts Guided-auth removal, OAuth smoke testing, and TUI/CLI support (#1531) 2026-06-29 15:35:51 -04:00
oauthMessageTone.test.ts fix(auth): read enumerated issuers exactly, and stop the TUI tone going stale (#2144) 2026-08-28 02:58:04 -04:00
openUrl.test.ts test(cli,tui): add in-process source coverage gates (#1484) (#1502) 2026-06-20 15:05:58 -04:00
promptArgsToForm.test.ts test(cli,tui): add in-process source coverage gates (#1484) (#1502) 2026-06-20 15:05:58 -04:00
PromptsTab.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
PromptTestModal.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
renderTui.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
RequestsTab.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
ResourcesTab.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
ResourceTestModal.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
schemaToForm.test.ts fix: decline a union branch requiring a name it never declares (#2224) 2026-09-06 12:59:52 -04:00
SelectableItem.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
setup.ts test(tui): extend coverage gate to Ink components + App.tsx (closes #1501) (#1538) 2026-06-29 08:19:12 -04:00
SkillsTab.test.tsx fix: address Copilot review round 4 on #2248 2026-09-07 19:55:17 -04:00
Tabs.test.tsx feat: Skills extension phase 3 — CLI, TUI, directory reads, frontmatter check 2026-09-07 18:10:37 -04:00
ToolsTab.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
ToolTestModal.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
tsupConfig.test.ts chore(lint): enable no-floating-promises in all five ESLint scopes 2026-08-16 20:57:32 -04:00
tui-servers.test.ts Guided-auth removal, OAuth smoke testing, and TUI/CLI support (#1531) 2026-06-29 15:35:51 -04:00
tui.test.ts Fixed tab naming to correspond to the web client. (#1780) 2026-07-25 20:11:52 -04:00
tuiOAuth.test.ts test(cli,tui): typecheck the __tests__ dirs (#1791) (#1799) 2026-07-27 12:05:35 -04:00
uriTemplateToForm.test.ts fix: dedupe a repeated name in a group, and name every unmet requirement 2026-08-17 00:33:52 -04:00
useSelectableList.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00