inspector/core/react/useClientSettingsDraft.ts
Bob Dickinson 13dafe457b
Guided-auth removal, OAuth smoke testing, and TUI/CLI support (#1531)
* refactor(web): update OAuth E2E tests to use new authentication method

- Replaced `runGuidedAuth` with `authenticate` in the InspectorClient OAuth end-to-end tests to support quick authentication with CIMD pre-registration.
- Updated comments to reflect the change in authentication method and its support for HTTP test metadata URLs.
- Ensured that the tests continue to validate the expected authorization URL after the change.

Additionally, imported `ensureCimdClientRegistration` in the OAuthManager to streamline client registration during the authentication process.

* Guided-auth removal, OAuth smoke testing, and TUI/CLI support

* Added CLI OAuth runner flags tests

* Added clarifying comment on port 0 binding

* README notes on TUI oauth callback port, prettier fixes for CLI tests

* CIMD validation uses inline like EMA IdP

* Fixed TUI test failures from merge

* test: bring 5 OAuth files over the 90 per-file coverage gate

The guided-auth-removal work added/touched several files that fell below
the repo's >=90 per-file coverage gate (npm run coverage). CI doesn't run
the gate (it's local-only), so validate + test:integration passed while
these gaps slipped through. Bring them all back over the line:

- core/auth/node/runner-oauth-callback.ts: test bad-URL/non-http-scheme
  throws, no-port->80 default, and IPv6 hostname bracketing. Annotate the
  provably-dead guards (empty host, out-of-range port, String(err)
  fallback, pathname "/" fallback) -- all rejected by new URL() upstream --
  with justified v8 ignore comments instead of lowering the gate.
- core/auth/cimd.ts: test the AS-doesn't-support-CIMD early return.
- core/react/useClientSettingsDraft.ts: test the functional-updater path,
  the stale-onChange-after-close prev===null guard, and the
  timer-fires-after-close value===null guard.
- ClientSettingsForm.tsx: test the CIMD checkbox toggle and CIMD URL clear.
- clients/tui/src/utils/oauthDisplay.ts: test static/dcr registration
  kinds, the expired IdP session, and the configured-scope/empty-scope
  branches of formatScopes.

npm run coverage now passes (exit 0) across web, cli, tui, launcher.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: cliffhall <cliff@futurescale.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-29 15:35:51 -04:00

105 lines
2.9 KiB
TypeScript

/**
* Draft state for the install-level client settings modal (client.json).
*
* Same controlled-modal pattern as {@link useSettingsDraft}: local draft,
* debounced persist, synchronous `flush` on close. Keyed on modal
* open/close (`opened`) rather than a server id because client config is
* install-level, not per-server.
*/
import { useCallback, useEffect, useRef, useState } from "react";
export interface UseClientSettingsDraftOptions<T> {
opened: boolean;
resolveInitial: () => T;
onPersist: (value: T) => Promise<void>;
onError: (err: unknown) => void;
debounceMs?: number;
}
export interface UseClientSettingsDraftResult<T> {
draft: T | null;
onChange: (next: T | ((prev: T) => T)) => void;
flush: () => void;
}
export function useClientSettingsDraft<T>({
opened,
resolveInitial,
onPersist,
onError,
debounceMs = 300,
}: UseClientSettingsDraftOptions<T>): UseClientSettingsDraftResult<T> {
const [draft, setDraft] = useState<T | null>(null);
const timerRef = useRef<ReturnType<typeof setTimeout> | undefined>(undefined);
const latestValuesRef = useRef<T | null>(null);
const resolveInitialRef = useRef(resolveInitial);
const onPersistRef = useRef(onPersist);
const onErrorRef = useRef(onError);
const openedRef = useRef(opened);
resolveInitialRef.current = resolveInitial;
onPersistRef.current = onPersist;
onErrorRef.current = onError;
openedRef.current = opened;
useEffect(() => {
if (!opened) {
setDraft(null);
latestValuesRef.current = null;
return;
}
const initial = resolveInitialRef.current();
setDraft(initial);
latestValuesRef.current = initial;
}, [opened]);
useEffect(() => {
return () => {
if (timerRef.current) {
clearTimeout(timerRef.current);
timerRef.current = undefined;
}
};
}, []);
const persist = useCallback((value: T) => {
onPersistRef.current(value).catch((err) => {
onErrorRef.current(err);
});
}, []);
const onChange = useCallback(
(next: T | ((prev: T) => T)) => {
if (!opened) return;
const prev = latestValuesRef.current;
if (prev === null) return;
const resolved =
typeof next === "function"
? (next as (prev: T) => T)(prev)
: next;
latestValuesRef.current = resolved;
setDraft(resolved);
if (timerRef.current) clearTimeout(timerRef.current);
timerRef.current = setTimeout(() => {
timerRef.current = undefined;
const value = latestValuesRef.current;
if (value !== null) {
persist(value);
}
}, debounceMs);
},
[opened, debounceMs, persist],
);
const flush = useCallback(() => {
if (!timerRef.current) return;
clearTimeout(timerRef.current);
timerRef.current = undefined;
const value = latestValuesRef.current;
if (openedRef.current && value !== null) {
persist(value);
}
}, [persist]);
return { draft, onChange, flush };
}