inspector/clients/web/src/components/groups/PendingClientRequests/PendingClientRequests.stories.tsx
cliffhall 19a6df7ad3 SDK v2 migration (behavior-neutral, versionNegotiation: 'legacy') (#1624)
Migrate all three clients + core + test-servers from
@modelcontextprotocol/sdk@1.29 to SDK v2 (2.0.0-beta.4), keeping behavior
identical against legacy (2025-11-25) servers. Foundation for the SDK V2 +
New Spec stack.

Packages
- Split @modelcontextprotocol/sdk -> @modelcontextprotocol/client (Client,
  transports, OAuth, error taxonomy, protocol types) + core (Zod schemas);
  stdio -> client/stdio, Ajv -> client/validators/ajv. Test-servers ->
  @modelcontextprotocol/server (+ server-legacy/sse). Deterministic import
  rewrite (schemas -> core, everything else -> client); the codemod misroutes
  client code to /server so it was not used for path routing.
- new Client(..., { versionNegotiation: { mode: 'legacy' } }) — nothing
  2026-era goes on the wire.

Runtime (core/mcp/inspectorClient.ts)
- Error taxonomy: McpError -> ProtocolError, ErrorCode -> ProtocolErrorCode;
  RequestTimeout -> SdkError/SdkErrorCode.
- Handlers take method strings; task methods (tasks/*, notifications/tasks/*)
  use the 3-arg custom form (excluded from v2's spec-method set).
- Legacy tasks kept working (per project requirement): requestor tasks re-
  implemented over raw client.request + explicit deprecated schemas;
  experimental.tasks.callToolStream replaced by a local pollTaskToolCall
  async generator (with _progressHandlers revival so task-execution progress
  still reaches the caller). Receiver (server-initiated) tasks: the v2 Client
  validates a sampling/elicit handler result and rejects the legacy { task }
  response with -32602 — installReceiverTaskResponseBypass swaps the wrapped
  entry in the private _requestHandlers map for the task-augmented branch so
  { task } reaches the wire (fixes server-initiated sampling-via-task).
- Pagination: list verbs use raw client.request({method}, List*ResultSchema)
  for single-page behavior (v2's client.listX() auto-aggregate all pages).

Web / auth / apps
- Rename local JsonSchemaType -> InspectorFormSchema + add toFormSchema()
  structural narrowing at the SDK-schema -> form boundary.
- ext-apps still peers on SDK v1: one compat boundary with documented casts
  (remove when ext-apps#702 lands a v2 peer).
- OAuth provider saveClientInformation reconciled with v2's
  OAuthClientInformationContext; InvalidClientMetadataError re-homed as a
  local class (server-legacy/auth is not browser-safe).
- vitest.shared.mts dedupes @modelcontextprotocol/client+core to one copy so
  vi.mock intercepts the SUT's import.

Accepted v2 behavior changes (per #1624 / spec §9.2): unknown-tool call
rejects with -32602; cancellation is stream-abort (no guaranteed
notifications/cancelled frame); output-schema strictness restored via the
Inspector's own Ajv check on the default path.

npm run ci green: validate (web 3087 / cli 212 / tui 274 / launcher 5),
coverage (>=90 per-file, all clients), smoke (launcher/cli/web), storybook
(410).

Closes #1624

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-15 10:44:24 -04:00

120 lines
3 KiB
TypeScript

import type { Meta, StoryObj } from "@storybook/react-vite";
import type { ElicitRequest } from "@modelcontextprotocol/client";
import { fn } from "storybook/test";
import { PendingClientRequests } from "./PendingClientRequests";
import { InlineSamplingRequest } from "../InlineSamplingRequest/InlineSamplingRequest";
import { InlineElicitationRequest } from "../InlineElicitationRequest/InlineElicitationRequest";
const meta: Meta<typeof PendingClientRequests> = {
title: "Groups/PendingClientRequests",
component: PendingClientRequests,
};
export default meta;
type Story = StoryObj<typeof PendingClientRequests>;
const elicitFormRequest = {
message: "Please provide your database connection details.",
requestedSchema: {
type: "object" as const,
properties: {
host: { type: "string" as const, title: "Host" },
port: { type: "string" as const, title: "Port" },
},
},
} satisfies ElicitRequest["params"];
const elicitDeployRequest = {
message: "Please confirm the deployment target.",
requestedSchema: {
type: "object" as const,
properties: {
environment: {
type: "string" as const,
title: "Environment",
enum: ["staging", "production"],
},
confirm: { type: "boolean" as const, title: "Confirm deployment" },
},
},
} satisfies ElicitRequest["params"];
export const SingleSampling: Story = {
args: {
count: 1,
children: (
<InlineSamplingRequest
request={{
messages: [
{
role: "user",
content: {
type: "text",
text: "Please analyze the following code and suggest improvements.",
},
},
],
maxTokens: 1024,
}}
queuePosition="1 of 1"
onAutoRespond={fn()}
onEditAndSend={fn()}
onReject={fn()}
onViewDetails={fn()}
/>
),
},
};
export const SingleElicitation: Story = {
args: {
count: 1,
children: (
<InlineElicitationRequest
request={elicitFormRequest}
queuePosition="1 of 1"
values={{}}
onChange={fn()}
onSubmit={fn()}
onCancel={fn()}
/>
),
},
};
export const MultipleMixed: Story = {
args: {
count: 2,
children: (
<>
<InlineSamplingRequest
request={{
messages: [
{
role: "user",
content: {
type: "text",
text: "Please analyze the following code and suggest improvements.",
},
},
],
maxTokens: 1024,
}}
queuePosition="1 of 2"
onAutoRespond={fn()}
onEditAndSend={fn()}
onReject={fn()}
onViewDetails={fn()}
/>
<InlineElicitationRequest
request={elicitDeployRequest}
queuePosition="2 of 2"
values={{}}
onChange={fn()}
onSubmit={fn()}
onCancel={fn()}
/>
</>
),
},
};