cliffhall
b18b975128
chore(scripts): treat an expression-built script name as forbidden too ( #2146 ) ...
Copilot, first review:
- The guard read only literal names, so `npm run smoke:web:${{ matrix.browser }}`
and `npm run local:${{ matrix.task }}` walked past it — the one form in which
a forbidden engine reaches CI without anyone typing its name. It already
refused an expression-valued SMOKE_BROWSER for that exact reason; this applies
the reasoning consistently. Its limit is now stated: a fully opaque
`npm run ${{ matrix.script }}` names no family and is not detectable.
- The module header claimed the gate adds "the non-Chromium engine passes";
it adds Firefox only, and WebKit belongs to neither tier.
- eslint.config.js:33 still said `npm run ci` — the last stale reference.
- AGENTS.md read "everything from `smoke` rightward is `local:gate` only",
which is two claims wrong: smoke and Storybook run in GitHub CI too, and
`pack:verify` is in neither tier.
Signed-off-by: Cliff Hall <cliff@futurescale.com>
Signed-off-by: cliffhall <cliff@futurescale.com>
2026-08-27 00:15:07 -04:00
chore(scripts): rename the local pre-push gate off ci, and guard it out of CI ( #2146 )
2026-08-26 23:56:34 -04:00
chore(scripts): rename the local pre-push gate off ci, and guard it out of CI ( #2146 )
2026-08-26 23:56:34 -04:00
fix(scripts): await the pack:verify web child's exit before removing its work dir ( #1895 )
2026-08-01 19:50:00 -04:00
fix(scripts): await the pack:verify web child's exit before removing its work dir ( #1895 )
2026-08-01 19:50:00 -04:00
docs(scripts): correct the deleted-source caveat — it is silent, not loud
2026-08-25 01:37:40 -04:00
fix(scripts): pin the tsbuildinfo inside build/, assert on cache hits
2026-08-25 01:11:10 -04:00
fix(smoke): assert the requested engine is the one launched; fix the remedy
2026-08-26 09:33:21 -04:00
fix(smoke): assert the requested engine is the one launched; fix the remedy
2026-08-26 09:33:21 -04:00
test(smoke): run the headless web smokes in Firefox and WebKit, not just Chromium ( #2086 )
2026-08-25 20:44:11 -04:00
Merge branch 'v2/main' into v2/chore/2003-pack-verify-app-render
2026-08-24 09:05:53 -04:00
test(cli,tui): typecheck the __tests__ dirs ( #1791 ) ( #1799 )
2026-07-27 12:05:35 -04:00
test(cli,tui): typecheck the __tests__ dirs ( #1791 ) ( #1799 )
2026-07-27 12:05:35 -04:00
test(smoke): cover loadBrowser's failure branches; fix a stale helper comment
2026-08-25 22:42:06 -04:00
fix(smoke): pin the teardown ordering, and correct a docblock the test refuted
2026-08-11 15:17:56 -04:00
fix(scripts): address Copilot review round 2 on #2147
2026-08-26 21:36:40 -04:00
fix(scripts): address Copilot review round 2 on #2147
2026-08-26 21:36:40 -04:00
fix(scripts): make the test stubs drain, and the raw-mode guard testable ( #2147 )
2026-08-26 22:13:35 -04:00
fix(scripts): make the test stubs drain, and the raw-mode guard testable ( #2147 )
2026-08-26 22:13:35 -04:00
fix(scripts): keep the resolver local, complete the cmd.exe quoting
2026-08-17 00:18:40 -04:00
fix(scripts): keep the resolver local, complete the cmd.exe quoting
2026-08-17 00:18:40 -04:00
fix(scripts): validate the bin name and that its file exists
2026-08-16 23:43:24 -04:00
chore(scripts): compare only the copies a program actually met
2026-08-16 12:35:38 -04:00
fix(scripts): keep the resolver local, complete the cmd.exe quoting
2026-08-17 00:18:40 -04:00
fix(scripts): keep the resolver local, complete the cmd.exe quoting
2026-08-17 00:18:40 -04:00
chore(scripts): treat an expression-built script name as forbidden too ( #2146 )
2026-08-27 00:15:07 -04:00
chore(scripts): treat an expression-built script name as forbidden too ( #2146 )
2026-08-27 00:15:07 -04:00
b18b975128