cliffhall
b0b252a5c0
fix: address Copilot review round 41 — const does not demand a property, required-only branches
...
- `const` constrains a property that is PRESENT; it neither requires the
property nor acts as a default. It is now supplied automatically only where
the schema also requires the field — in `collectSchemaDefaults`,
`applySchemaConstants` and the TUI's initial values alike — so an optional
`dryRun: { const: true }` no longer turns a valid `{}` call into one that
asks the server to do something. A value that IS present is still corrected
to the constant, whatever supplied it, and the field stays read-only.
- Offerability is judged on the base+member merge rather than the raw member,
so `anyOf: [{ required: ["email"] }, { required: ["phone"] }]` over
root-declared properties is offered. It was declined, which left the gate
checking the base alone and accepting `{}` — which that schema rejects.
- The TUI's branch sections keep the schema's own `required` for the seeding
decision while still rendering every branch field non-required, which is what
keeps a static form submittable.
Signed-off-by: cliffhall <cliff@futurescale.com>
2026-08-26 16:08:24 -04:00
..
helpers
feat: allow complex JSON values in request _meta
2026-08-23 12:23:40 -04:00
App.test.tsx
Merge branch 'v2/main' into v2/fix/2067-proxy-undici
2026-08-23 23:34:07 -04:00
AuthTab.test.tsx
test(cli,tui): typecheck the __tests__ dirs ( #1791 ) ( #1799 )
2026-07-27 12:05:35 -04:00
DetailsModal.test.tsx
test(tui): extend coverage gate to Ink components + App.tsx ( closes #1501 ) ( #1538 )
2026-06-29 08:19:12 -04:00
HistoryTab.test.tsx
test(cli,tui): typecheck the __tests__ dirs ( #1791 ) ( #1799 )
2026-07-27 12:05:35 -04:00
InfoTab.test.tsx
chore: close quality-gate coverage gaps ( #1689 ) ( #1766 )
2026-07-24 17:20:12 -04:00
logger.test.ts
test: raise per-file coverage gate to 90 across all clients ( closes #1271 ) ( #1532 )
2026-06-27 15:26:03 -04:00
NotificationsTab.test.tsx
Fixed tab naming to correspond to the web client. ( #1780 )
2026-07-25 20:11:52 -04:00
oauthDisplay.test.ts
Guided-auth removal, OAuth smoke testing, and TUI/CLI support ( #1531 )
2026-06-29 15:35:51 -04:00
openUrl.test.ts
test(cli,tui): add in-process source coverage gates ( #1484 ) ( #1502 )
2026-06-20 15:05:58 -04:00
promptArgsToForm.test.ts
test(cli,tui): add in-process source coverage gates ( #1484 ) ( #1502 )
2026-06-20 15:05:58 -04:00
PromptsTab.test.tsx
SDK v2 migration (behavior-neutral, versionNegotiation: 'legacy') ( #1624 )
2026-07-15 10:44:24 -04:00
PromptTestModal.test.tsx
SDK v2 migration (behavior-neutral, versionNegotiation: 'legacy') ( #1624 )
2026-07-15 10:44:24 -04:00
RequestsTab.test.tsx
Fixed tab naming to correspond to the web client. ( #1780 )
2026-07-25 20:11:52 -04:00
ResourcesTab.test.tsx
SDK v2 migration (behavior-neutral, versionNegotiation: 'legacy') ( #1624 )
2026-07-15 10:44:24 -04:00
ResourceTestModal.test.tsx
fix: honor a defined-but-empty value, and announce the expansion error
2026-08-16 23:08:30 -04:00
schemaToForm.test.ts
fix: address Copilot review round 41 — const does not demand a property, required-only branches
2026-08-26 16:08:24 -04:00
SelectableItem.test.tsx
test(tui): extend coverage gate to Ink components + App.tsx ( closes #1501 ) ( #1538 )
2026-06-29 08:19:12 -04:00
setup.ts
test(tui): extend coverage gate to Ink components + App.tsx ( closes #1501 ) ( #1538 )
2026-06-29 08:19:12 -04:00
Tabs.test.tsx
Fixed tab naming to correspond to the web client. ( #1780 )
2026-07-25 20:11:52 -04:00
ToolsTab.test.tsx
feat: flag unportable tool schemas in all three clients
2026-08-25 01:18:53 -04:00
ToolTestModal.test.tsx
fix: address Copilot review round 9 — canonical constant comparison, name-based inference, permissive schemas
2026-08-26 04:07:50 -04:00
tsupConfig.test.ts
chore(lint): enable no-floating-promises in all five ESLint scopes
2026-08-16 20:57:32 -04:00
tui-servers.test.ts
Guided-auth removal, OAuth smoke testing, and TUI/CLI support ( #1531 )
2026-06-29 15:35:51 -04:00
tui.test.ts
Fixed tab naming to correspond to the web client. ( #1780 )
2026-07-25 20:11:52 -04:00
tuiOAuth.test.ts
test(cli,tui): typecheck the __tests__ dirs ( #1791 ) ( #1799 )
2026-07-27 12:05:35 -04:00
uriTemplateToForm.test.ts
fix: dedupe a repeated name in a group, and name every unmet requirement
2026-08-17 00:33:52 -04:00
useSelectableList.test.tsx
test(tui): extend coverage gate to Ink components + App.tsx ( closes #1501 ) ( #1538 )
2026-06-29 08:19:12 -04:00