* test(tui): cover useSelectableList hook + leaf Ink components (#1501) Add ink-testing-library and renderer-based tests for useSelectableList, SelectableItem, and Tabs. Widen the vitest include glob to .test.tsx and lift these files from the interim React-surface coverage exclusion. The blanket src/components/**/*.tsx exclude is expanded into an explicit per-file list so remaining components can be lifted incrementally. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(tui): add ink-scroll-view passthrough mock for renderer tests (#1501) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(tui): add ink-form passthrough mock for modal renderer tests (#1501) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(tui): cover all Ink tab + modal components via renderer tests (#1501) Add ink-testing-library tests for the 12 Ink components (InfoTab, AuthTab, ResourcesTab, PromptsTab, ToolsTab, NotificationsTab, HistoryTab, RequestsTab, and the Tool/Resource/Prompt test modals + DetailsModal), mounting them through the ink-scroll-view / ink-form passthrough doubles and driving keypresses via stdin. Modal components render position:absolute (empty frame under the test renderer) so their tests assert on behavior — injected InspectorClient fakes and onClose — while the passthrough ScrollView still mounts the inner JSX for coverage. Lift these 12 components from the interim React-surface exclusion in vitest.config.ts; only App.tsx remains excluded. All files clear the uniform 90/90/90/90 per-file gate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(tui): add App.tsx renderer-test harness + foundation tests (#1501) Mock the full @inspector/core surface (InspectorClient, the 7 managed-state classes, the 8 react hooks, transport + auth) behind a controllable harness, plus the ink-scroll-view/ink-form passthroughs, so App renders under ink-testing-library and its keyboard state machine can be driven via stdin. Concurrent ink mounts share raw-mode stdin, so each render is unmounted in afterEach. Foundation covers server-list nav, tab accelerators, connect/ disconnect, OAuth-tab gating, and connected-status rendering (~50% baseline). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(tui): cover App.tsx via mocked-core renderer tests; lift final exclusion (#1501) Extend App.test.tsx to 67 tests driving the keyboard state machine, tab content, modals, OAuth flows, and connect/disconnect across the controllable @inspector/core mock. App.tsx now clears the 90/90/90/90 per-file gate (94.6/90.6/94.5/96.6). Remove the last React-surface exclusion (src/App.tsx) from clients/tui/vitest.config.ts. The whole clients/tui/src tree is now under the uniform per-file coverage gate with no React-surface exclusions, completing the interim-scope lift from #1484. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(tui): raise stdout max-listeners in App test to silence warning (#1501) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(tui): raise App.tsx branch coverage >90 and de-flake coverage runs (#1501) Add targeted App.tsx tests for the OAuth handlers' non-Error throw arms (quick onCallback, guided start/advance, run-to-completion) and a re-entrant quick-auth guard, lifting App.tsx branch coverage 90.6% -> 91.48% for a safer margin above the 90 gate. Harden the App renderer tests against the heavier v8 coverage instrumentation, where React+ink's multi-macrotask render scheduling races fixed ticks: - press() now settles two ticks per key so focus/tab changes flush before the next key is routed (ink re-subscribes useInput on re-render); - expectFrame()/waitUntil() poll for frame content and async flow state (callbackServer opts) instead of asserting after a single fixed tick; - ResourcesTab's content-clear test polls for fetched content likewise. Plain 'npm test' (the CI path) was already stable; this makes the local coverage gate stable too (13/13 clean runs vs ~2/8 flaky before). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(tui): de-flake component renderer tests under slow CI (#1501) CI flaked on AuthTab's 'renders quick auth results' under the plain test run: its oauthFlowState is populated by a post-mount useEffect reading the inspectorClient, and a single-macrotask tick can race that effect -> setState -> re-render chain on a slow/loaded CI runner. Make each component test file's tick() flush several macrotask cycles so such chains settle deterministically before assertions (no test relies on precise tick timing — no fake timers / debounce). App.test.tsx already polls via expectFrame/waitUntil and passed CI, so it's unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(tui): address review — shared setupFile for max-listeners, consume-once ink-form global (#1501) Review follow-ups on #1538 (both non-blocking cleanups): - Hoist process.std{out,in}.setMaxListeners into a shared vitest setupFile (__tests__/setup.ts) wired via setupFiles, so every renderer test file inherits it and the MaxListenersExceededWarning is silenced across the whole suite — not just App.test.tsx. Remove the per-file call. - Make the ink-form double consume (clear) __INK_FORM_SUBMIT_VALUE__ on submit, eliminating the latent cross-test coupling on the shared global regardless of how the modal test files are organized. No production code changed; suite + coverage gate stay green (App.tsx 94.8/91.5/94.5/96.6), and the warning no longer prints. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
267 lines
8 KiB
TypeScript
267 lines
8 KiB
TypeScript
import React from "react";
|
|
import { describe, it, expect, vi, afterEach } from "vitest";
|
|
import { render } from "ink-testing-library";
|
|
import type { InspectorClient } from "@inspector/core/mcp/index.js";
|
|
|
|
// ScrollView passthrough so the results JSX actually mounts (and is covered).
|
|
vi.mock("ink-scroll-view", () => import("./helpers/inkScrollViewMock.js"));
|
|
// Form double that fires onSubmit when the user presses Enter ("\r").
|
|
vi.mock("ink-form", () => import("./helpers/inkFormMock.js"));
|
|
|
|
import { ResourceTestModal } from "../src/components/ResourceTestModal.js";
|
|
|
|
// These modals render position="absolute", which produces an EMPTY frame under
|
|
// ink-testing-library. So we assert on BEHAVIOR — the injected client fake's
|
|
// readResourceFromTemplate, onClose, and the state transitions they drive —
|
|
// rather than on lastFrame(). React still EXECUTES the inner results/error JSX,
|
|
// so its coverage is collected even though it isn't visible.
|
|
|
|
const tick = async () => {
|
|
// Flush several macrotask cycles so an effect -> setState -> re-render chain
|
|
// settles before assertions, even on slow/loaded CI (a single tick can race).
|
|
for (let i = 0; i < 8; i++)
|
|
await new Promise((resolve) => setTimeout(resolve, 4));
|
|
};
|
|
const ESC = String.fromCharCode(27);
|
|
const UP = `${ESC}[A`;
|
|
const DOWN = `${ESC}[B`;
|
|
const PAGE_UP = `${ESC}[5~`;
|
|
const PAGE_DOWN = `${ESC}[6~`;
|
|
|
|
type Template = {
|
|
name: string;
|
|
uriTemplate: string;
|
|
description?: string;
|
|
};
|
|
|
|
const makeTemplate = (over: Partial<Template> = {}): Template => ({
|
|
name: "Greeting",
|
|
uriTemplate: "greeting://{name}",
|
|
...over,
|
|
});
|
|
|
|
const fakeClient = (readResourceFromTemplate: unknown): InspectorClient =>
|
|
({ readResourceFromTemplate }) as unknown as InspectorClient;
|
|
|
|
const setSubmitValue = (value: Record<string, unknown>) => {
|
|
(globalThis as Record<string, unknown>).__INK_FORM_SUBMIT_VALUE__ = value;
|
|
};
|
|
|
|
afterEach(() => {
|
|
delete (globalThis as Record<string, unknown>).__INK_FORM_SUBMIT_VALUE__;
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
const renderAndSubmit = async (
|
|
client: InspectorClient | null,
|
|
template: Template = makeTemplate(),
|
|
submitValue: Record<string, unknown> = { name: "world" },
|
|
) => {
|
|
const onClose = vi.fn();
|
|
const api = render(
|
|
<ResourceTestModal
|
|
template={template}
|
|
inspectorClient={client}
|
|
width={80}
|
|
height={24}
|
|
onClose={onClose}
|
|
/>,
|
|
);
|
|
await tick();
|
|
setSubmitValue(submitValue);
|
|
api.stdin.write("\r");
|
|
await tick();
|
|
await tick();
|
|
return { ...api, onClose };
|
|
};
|
|
|
|
describe("ResourceTestModal", () => {
|
|
it("renders the form initially without invoking the client", async () => {
|
|
const read = vi.fn();
|
|
const api = render(
|
|
<ResourceTestModal
|
|
template={makeTemplate()}
|
|
inspectorClient={fakeClient(read)}
|
|
width={80}
|
|
height={24}
|
|
onClose={vi.fn()}
|
|
/>,
|
|
);
|
|
await tick();
|
|
expect(read).not.toHaveBeenCalled();
|
|
api.unmount();
|
|
});
|
|
|
|
it("renders the template description when present", async () => {
|
|
const read = vi.fn();
|
|
const api = render(
|
|
<ResourceTestModal
|
|
template={makeTemplate({ description: "A friendly greeting" })}
|
|
inspectorClient={fakeClient(read)}
|
|
width={80}
|
|
height={24}
|
|
onClose={vi.fn()}
|
|
/>,
|
|
);
|
|
await tick();
|
|
api.unmount();
|
|
});
|
|
|
|
it("uses the 'Unknown Template' label when the template has an empty name", async () => {
|
|
const read = vi.fn();
|
|
const api = render(
|
|
<ResourceTestModal
|
|
template={makeTemplate({ name: "" })}
|
|
inspectorClient={fakeClient(read)}
|
|
width={80}
|
|
height={24}
|
|
onClose={vi.fn()}
|
|
/>,
|
|
);
|
|
await tick();
|
|
api.unmount();
|
|
});
|
|
|
|
it("renders the loading state while the read is in flight", async () => {
|
|
let resolveRead: (v: unknown) => void = () => {};
|
|
const pending = new Promise((resolve) => {
|
|
resolveRead = resolve;
|
|
});
|
|
const read = vi.fn().mockReturnValue(pending);
|
|
const api = render(
|
|
<ResourceTestModal
|
|
template={makeTemplate()}
|
|
inspectorClient={fakeClient(read)}
|
|
width={80}
|
|
height={24}
|
|
onClose={vi.fn()}
|
|
/>,
|
|
);
|
|
await tick();
|
|
setSubmitValue({ name: "world" });
|
|
api.stdin.write("\r");
|
|
await tick();
|
|
// The component is now committed in the "loading" state (read not resolved).
|
|
expect(read).toHaveBeenCalled();
|
|
resolveRead({
|
|
result: { contents: [{ uri: "greeting://world", text: "hi" }] },
|
|
expandedUri: "greeting://world",
|
|
});
|
|
await tick();
|
|
await tick();
|
|
api.unmount();
|
|
});
|
|
|
|
it("reads the resource and shows successful content", async () => {
|
|
const read = vi.fn().mockResolvedValue({
|
|
result: { contents: [{ uri: "greeting://world", text: "hi" }] },
|
|
expandedUri: "greeting://world",
|
|
});
|
|
const { onClose, stdin, unmount } = await renderAndSubmit(
|
|
fakeClient(read),
|
|
makeTemplate(),
|
|
{ name: "world" },
|
|
);
|
|
expect(read).toHaveBeenCalledWith("greeting://{name}", { name: "world" });
|
|
// Drive scroll keys in results state for scrollBy / page coverage.
|
|
stdin.write(DOWN);
|
|
await tick();
|
|
stdin.write(UP);
|
|
await tick();
|
|
stdin.write(PAGE_DOWN);
|
|
await tick();
|
|
stdin.write(PAGE_UP);
|
|
await tick();
|
|
expect(onClose).not.toHaveBeenCalled();
|
|
unmount();
|
|
});
|
|
|
|
it("catches an Error thrown by readResourceFromTemplate", async () => {
|
|
const read = vi.fn().mockRejectedValue(new Error("not found"));
|
|
const { unmount } = await renderAndSubmit(fakeClient(read));
|
|
expect(read).toHaveBeenCalled();
|
|
unmount();
|
|
});
|
|
|
|
it("catches a string thrown by readResourceFromTemplate", async () => {
|
|
const read = vi.fn().mockRejectedValue("boom");
|
|
const { unmount } = await renderAndSubmit(fakeClient(read));
|
|
expect(read).toHaveBeenCalled();
|
|
unmount();
|
|
});
|
|
|
|
it("catches an object error carrying uri and message (uri + Object.assign branches)", async () => {
|
|
const read = vi
|
|
.fn()
|
|
.mockRejectedValue({ message: "bad uri", uri: "greeting://expanded" });
|
|
const { unmount } = await renderAndSubmit(fakeClient(read));
|
|
expect(read).toHaveBeenCalled();
|
|
unmount();
|
|
});
|
|
|
|
it("catches an object error without message or uri (Object.assign + Unknown error)", async () => {
|
|
const read = vi.fn().mockRejectedValue({ code: 42 });
|
|
const { unmount } = await renderAndSubmit(fakeClient(read));
|
|
expect(read).toHaveBeenCalled();
|
|
unmount();
|
|
});
|
|
|
|
it("catches a non-object, non-string throw (else branch)", async () => {
|
|
const read = vi.fn().mockRejectedValue(12345);
|
|
const { unmount } = await renderAndSubmit(fakeClient(read));
|
|
expect(read).toHaveBeenCalled();
|
|
unmount();
|
|
});
|
|
|
|
it("does nothing on submit when inspectorClient is null (early-return guard)", async () => {
|
|
const { onClose, unmount } = await renderAndSubmit(null);
|
|
expect(onClose).not.toHaveBeenCalled();
|
|
unmount();
|
|
});
|
|
|
|
it("closes on ESC while in form state", async () => {
|
|
const onClose = vi.fn();
|
|
const api = render(
|
|
<ResourceTestModal
|
|
template={makeTemplate()}
|
|
inspectorClient={fakeClient(vi.fn())}
|
|
width={80}
|
|
height={24}
|
|
onClose={onClose}
|
|
/>,
|
|
);
|
|
await tick();
|
|
api.stdin.write(ESC);
|
|
await tick();
|
|
expect(onClose).toHaveBeenCalledTimes(1);
|
|
api.unmount();
|
|
});
|
|
|
|
it("closes on ESC while in results state", async () => {
|
|
const read = vi.fn().mockResolvedValue({
|
|
result: { contents: [{ uri: "greeting://world", text: "hi" }] },
|
|
expandedUri: "greeting://world",
|
|
});
|
|
const { onClose, stdin, unmount } = await renderAndSubmit(fakeClient(read));
|
|
stdin.write(ESC);
|
|
await tick();
|
|
expect(onClose).toHaveBeenCalledTimes(1);
|
|
unmount();
|
|
});
|
|
|
|
it("responds to a stdout resize event", async () => {
|
|
const api = render(
|
|
<ResourceTestModal
|
|
template={makeTemplate()}
|
|
inspectorClient={fakeClient(vi.fn())}
|
|
width={80}
|
|
height={24}
|
|
onClose={vi.fn()}
|
|
/>,
|
|
);
|
|
await tick();
|
|
process.stdout.emit("resize");
|
|
await tick();
|
|
api.unmount();
|
|
});
|
|
});
|