* refactor(web): update OAuth E2E tests to use new authentication method - Replaced `runGuidedAuth` with `authenticate` in the InspectorClient OAuth end-to-end tests to support quick authentication with CIMD pre-registration. - Updated comments to reflect the change in authentication method and its support for HTTP test metadata URLs. - Ensured that the tests continue to validate the expected authorization URL after the change. Additionally, imported `ensureCimdClientRegistration` in the OAuthManager to streamline client registration during the authentication process. * Guided-auth removal, OAuth smoke testing, and TUI/CLI support * Added CLI OAuth runner flags tests * Added clarifying comment on port 0 binding * README notes on TUI oauth callback port, prettier fixes for CLI tests * CIMD validation uses inline like EMA IdP * Fixed TUI test failures from merge * test: bring 5 OAuth files over the 90 per-file coverage gate The guided-auth-removal work added/touched several files that fell below the repo's >=90 per-file coverage gate (npm run coverage). CI doesn't run the gate (it's local-only), so validate + test:integration passed while these gaps slipped through. Bring them all back over the line: - core/auth/node/runner-oauth-callback.ts: test bad-URL/non-http-scheme throws, no-port->80 default, and IPv6 hostname bracketing. Annotate the provably-dead guards (empty host, out-of-range port, String(err) fallback, pathname "/" fallback) -- all rejected by new URL() upstream -- with justified v8 ignore comments instead of lowering the gate. - core/auth/cimd.ts: test the AS-doesn't-support-CIMD early return. - core/react/useClientSettingsDraft.ts: test the functional-updater path, the stale-onChange-after-close prev===null guard, and the timer-fires-after-close value===null guard. - ClientSettingsForm.tsx: test the CIMD checkbox toggle and CIMD URL clear. - clients/tui/src/utils/oauthDisplay.ts: test static/dcr registration kinds, the expired IdP session, and the configured-scope/empty-scope branches of formatScopes. npm run coverage now passes (exit 0) across web, cli, tui, launcher. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: cliffhall <cliff@futurescale.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
77 lines
2.6 KiB
TypeScript
77 lines
2.6 KiB
TypeScript
/**
|
|
* Start Vite dev server in-process via the Node API. Config is passed into the plugin; no shared state.
|
|
*
|
|
* Uses the shared base config so Node-only callers don't need to load
|
|
* `vite.config.ts` (which Node can't import directly).
|
|
*/
|
|
|
|
import { join, dirname, resolve } from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
import { createServer, type InlineConfig } from "vite";
|
|
import react from "@vitejs/plugin-react";
|
|
import type { WebServerConfig } from "./web-server-config.js";
|
|
import { honoMiddlewarePlugin } from "./vite-hono-plugin.js";
|
|
import {
|
|
clearViteDepsCache,
|
|
getViteDevOptimizeDeps,
|
|
} from "./vite-base-config.js";
|
|
import { vitestSharedPaths } from "../../../vitest.shared.mts";
|
|
import type { WebServerHandle } from "./types.js";
|
|
|
|
export type { WebServerHandle };
|
|
|
|
const __dirname = dirname(fileURLToPath(import.meta.url));
|
|
|
|
/**
|
|
* Start the Vite dev server in-process. Passes config into the plugin. Caller owns SIGINT/SIGTERM.
|
|
*/
|
|
export async function startViteDevServer(
|
|
config: WebServerConfig,
|
|
): Promise<WebServerHandle> {
|
|
// Canonicalize paths under clients/web.
|
|
const root = resolve(join(__dirname, ".."));
|
|
clearViteDepsCache(root);
|
|
// `configFile: false` means this in-process server never loads
|
|
// `vite.config.ts`, so it must reproduce that file's `resolve` block and
|
|
// `server.fs.allow` here. Without them, App.tsx's `@inspector/core/*`
|
|
// imports fail to resolve and the page 500s (#1452 smoke test). The aliases
|
|
// and dedupe are factored into `vitest.shared.mts` so both paths stay in
|
|
// sync — pass the client dir (`root`) so bare-module pins resolve against
|
|
// `clients/web/node_modules`.
|
|
const { repoRoot, sharedAliases, sharedDedupe, nodeModulesAliases } =
|
|
vitestSharedPaths(root);
|
|
const inlineConfig: InlineConfig = {
|
|
optimizeDeps: getViteDevOptimizeDeps(),
|
|
configFile: false,
|
|
root,
|
|
resolve: {
|
|
alias: [
|
|
...Object.entries(sharedAliases).map(([find, replacement]) => ({
|
|
find,
|
|
replacement,
|
|
})),
|
|
...nodeModulesAliases,
|
|
],
|
|
dedupe: sharedDedupe,
|
|
},
|
|
server: {
|
|
port: config.port,
|
|
host: config.hostname,
|
|
// Allow Vite to serve source files from the repo root (core/ lives
|
|
// outside clients/web), matching `vite.config.ts`'s `server.fs.allow`.
|
|
fs: {
|
|
allow: [repoRoot],
|
|
},
|
|
},
|
|
plugins: [react(), honoMiddlewarePlugin(config)],
|
|
};
|
|
const server = await createServer(inlineConfig);
|
|
|
|
await server.listen();
|
|
|
|
return {
|
|
async close(): Promise<void> {
|
|
await server.close();
|
|
},
|
|
};
|
|
}
|