inspector/core/auth/node/oauth-callback-server.ts
Bob Dickinson 13dafe457b
Guided-auth removal, OAuth smoke testing, and TUI/CLI support (#1531)
* refactor(web): update OAuth E2E tests to use new authentication method

- Replaced `runGuidedAuth` with `authenticate` in the InspectorClient OAuth end-to-end tests to support quick authentication with CIMD pre-registration.
- Updated comments to reflect the change in authentication method and its support for HTTP test metadata URLs.
- Ensured that the tests continue to validate the expected authorization URL after the change.

Additionally, imported `ensureCimdClientRegistration` in the OAuthManager to streamline client registration during the authentication process.

* Guided-auth removal, OAuth smoke testing, and TUI/CLI support

* Added CLI OAuth runner flags tests

* Added clarifying comment on port 0 binding

* README notes on TUI oauth callback port, prettier fixes for CLI tests

* CIMD validation uses inline like EMA IdP

* Fixed TUI test failures from merge

* test: bring 5 OAuth files over the 90 per-file coverage gate

The guided-auth-removal work added/touched several files that fell below
the repo's >=90 per-file coverage gate (npm run coverage). CI doesn't run
the gate (it's local-only), so validate + test:integration passed while
these gaps slipped through. Bring them all back over the line:

- core/auth/node/runner-oauth-callback.ts: test bad-URL/non-http-scheme
  throws, no-port->80 default, and IPv6 hostname bracketing. Annotate the
  provably-dead guards (empty host, out-of-range port, String(err)
  fallback, pathname "/" fallback) -- all rejected by new URL() upstream --
  with justified v8 ignore comments instead of lowering the gate.
- core/auth/cimd.ts: test the AS-doesn't-support-CIMD early return.
- core/react/useClientSettingsDraft.ts: test the functional-updater path,
  the stale-onChange-after-close prev===null guard, and the
  timer-fires-after-close value===null guard.
- ClientSettingsForm.tsx: test the CIMD checkbox toggle and CIMD URL clear.
- clients/tui/src/utils/oauthDisplay.ts: test static/dcr registration
  kinds, the expired IdP session, and the configured-scope/empty-scope
  branches of formatScopes.

npm run coverage now passes (exit 0) across web, cli, tui, launcher.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: cliffhall <cliff@futurescale.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-29 15:35:51 -04:00

224 lines
6.4 KiB
TypeScript

import { createServer, type Server } from "node:http";
import { parseOAuthCallbackParams } from "../utils.js";
import { generateOAuthErrorDescription } from "../utils.js";
const DEFAULT_HOSTNAME = "127.0.0.1";
const DEFAULT_CALLBACK_PATH = "/oauth/callback";
const SUCCESS_HTML = `<!DOCTYPE html>
<html>
<head><meta charset="utf-8"><title>OAuth complete</title></head>
<body><p>OAuth complete. You can close this window.</p></body>
</html>`;
function errorHtml(message: string): string {
return `<!DOCTYPE html>
<html>
<head><meta charset="utf-8"><title>OAuth error</title></head>
<body><p>OAuth failed: ${escapeHtml(message)}</p></body>
</html>`;
}
function escapeHtml(s: string): string {
return s
.replace(/&/g, "&amp;")
.replace(/</g, "&lt;")
.replace(/>/g, "&gt;")
.replace(/"/g, "&quot;");
}
export type OAuthCallbackHandler = (params: {
code: string;
state?: string;
}) => Promise<void>;
export type OAuthErrorHandler = (params: {
error: string;
error_description?: string | null;
}) => void;
export interface OAuthCallbackServerStartOptions {
port?: number;
hostname?: string;
path?: string;
onCallback?: OAuthCallbackHandler;
onError?: OAuthErrorHandler;
}
export interface OAuthCallbackServerStartResult {
port: number;
redirectUrl: string;
}
/**
* Minimal HTTP server that receives OAuth 2.1 redirects at GET /oauth/callback.
* Used by TUI/CLI to complete the authorization code flow.
* Caller provides onCallback/onError; typically onCallback calls
* InspectorClient.completeOAuthFlow(code) then stops the server.
*/
export class OAuthCallbackServer {
private server: Server | null = null;
private port: number = 0;
private callbackPath: string = DEFAULT_CALLBACK_PATH;
private handled = false;
private onCallback?: OAuthCallbackHandler;
private onError?: OAuthErrorHandler;
/**
* Start the server. Port defaults to 0 (random) when omitted; TUI/CLI callers
* pass the resolved port from {@link parseRunnerOAuthCallbackUrl} (6276 by default).
* Returns port and redirectUrl for use as oauth.redirectUrl.
*/
async start(
options: OAuthCallbackServerStartOptions = {},
): Promise<OAuthCallbackServerStartResult> {
const {
port = 0,
hostname = DEFAULT_HOSTNAME,
path = DEFAULT_CALLBACK_PATH,
onCallback,
onError,
} = options;
if (!path.startsWith("/")) {
return Promise.reject(
new Error("Callback path must start with '/' (absolute path)"),
);
}
this.onCallback = onCallback;
this.onError = onError;
this.handled = false;
this.callbackPath = path;
return new Promise((resolve, reject) => {
this.server = createServer((req, res) => this.handleRequest(req, res));
this.server.on("error", reject);
this.server.listen(port, hostname, () => {
const a = this.server!.address();
/* v8 ignore next 4 -- defensive: a TCP server that has fired its
`listen` callback always reports an AddressInfo object (never null
and never a string, which only happens for a pipe/unix socket),
so this guard is unreachable from a successful `listen(port, host)`. */
if (!a || typeof a === "string") {
reject(new Error("Failed to get server address"));
return;
}
this.port = a.port;
resolve({
port: this.port,
redirectUrl: buildRedirectUrl(hostname, this.port, path),
});
});
});
}
/**
* Stop the server. Idempotent.
*/
async stop(): Promise<void> {
if (!this.server) return;
await new Promise<void>((resolve) => {
this.server!.close(() => resolve());
});
this.server = null;
}
private handleRequest(
req: import("node:http").IncomingMessage,
res: import("node:http").ServerResponse<
import("node:http").IncomingMessage
>,
): void {
const needJson = req.headers["accept"]?.includes("application/json");
const send = (
status: number,
body: string,
contentType = "text/html; charset=utf-8",
) => {
res.writeHead(status, { "Content-Type": contentType });
res.end(body);
};
if (req.method !== "GET") {
send(405, needJson ? '{"error":"Method Not Allowed"}' : SUCCESS_HTML);
return;
}
let pathname: string;
let search: string;
let state: string | undefined;
try {
const u = new URL(
/* v8 ignore next -- defensive: Node always populates req.url for an
HTTP request, so the `?? ""` fallback is never taken. */
req.url ?? "",
"http://placeholder",
);
pathname = u.pathname;
search = u.search;
state = u.searchParams.get("state") ?? undefined;
} catch {
send(400, needJson ? '{"error":"Bad Request"}' : SUCCESS_HTML);
return;
}
if (pathname !== this.callbackPath) {
send(404, needJson ? '{"error":"Not Found"}' : SUCCESS_HTML);
return;
}
if (this.handled) {
send(
409,
needJson ? '{"error":"Callback already handled"}' : SUCCESS_HTML,
);
return;
}
const params = parseOAuthCallbackParams(search);
if (params.successful) {
this.handled = true;
const cb = this.onCallback;
if (cb) {
cb({ code: params.code, state })
.then(() => {
send(200, SUCCESS_HTML);
void this.stop();
})
.catch((err) => {
const msg = err instanceof Error ? err.message : String(err);
this.onError?.({ error: "callback_error", error_description: msg });
send(500, errorHtml(msg));
void this.stop();
});
} else {
send(200, SUCCESS_HTML);
void this.stop();
}
return;
}
this.handled = true;
const msg = generateOAuthErrorDescription(params);
this.onError?.({
error: params.error,
error_description: params.error_description ?? undefined,
});
send(400, errorHtml(msg));
}
}
/**
* Create an OAuth callback server instance.
* Use start() then stop() when the OAuth flow is done.
*/
export function createOAuthCallbackServer(): OAuthCallbackServer {
return new OAuthCallbackServer();
}
function buildRedirectUrl(host: string, port: number, path: string): string {
const needsBrackets = host.includes(":") && !host.startsWith("[");
const formattedHost = needsBrackets ? `[${host}]` : host;
return `http://${formattedHost}:${port}${path}`;
}