inspector/core/mcp/messageTrackingTransport.ts
Cliff Hall 9b558afee1
feat(web): display negotiated MCP protocol version on ServerCard (#1324) (#1442)
* feat(web): show negotiated MCP protocol version on ServerCard (#1324)

Add optional protocolVersion to ConnectionState and render it as a
dimmed "MCP <version>" label at the end of the transport-badge/
description row on ServerCard, shown only when connected. The value
is plumbed through useInspectorClient as part of #1324.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat(core,web): surface negotiated protocolVersion end-to-end (#1324)

Plumb the MCP protocol version negotiated during initialize from the
InspectorClient through to the ServerCard so the active connected card
displays "MCP <version>".

The SDK Client doesn't expose protocolVersion; it stamps it onto the
transport via setProtocolVersion. MessageTrackingTransport now captures
it (and forwards to the base transport when present), so it works for
stdio too — whose base transport has no setProtocolVersion.

- core: MessageTrackingTransport captures + exposes protocolVersion;
  InspectorClient stores it, exposes getProtocolVersion(), dispatches a
  protocolVersionChange event, and clears it on disconnect.
- core: useInspectorClient subscribes and returns protocolVersion.
- web: App reads it from the hook (drops the hard-coded "2025-06-18")
  and InspectorView splices it onto the active server's connection.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* refactor(web): decouple initializeResult from protocolVersion (#1324 review)

Gate the initializeResult memo on serverInfo only, not protocolVersion.
initializeResult also drives the connected ViewHeader and Connection Info
modal, so requiring the version risked hiding the whole connected surface
in the edge case where it's absent. protocolVersion now flows through as
the optional field it already is everywhere downstream ('' reads as
unknown; the ServerCard label and modal value both tolerate it).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* refactor(web): drop redundant connected-check in InspectorView splice (#1324 review)

initializeResult is derived from connectionStatus in App's memo, so a
truthy initializeResult.protocolVersion already implies a live
connection — the extra connectionStatus === 'connected' guard in the
splice was redundant. ServerCard keeps its own status guard (dumb-
component robustness). No behavior change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-08 07:40:02 -04:00

165 lines
5.1 KiB
TypeScript

import type {
Transport,
TransportSendOptions,
} from "@modelcontextprotocol/sdk/shared/transport.js";
import type {
JSONRPCMessage,
MessageExtraInfo,
} from "@modelcontextprotocol/sdk/types.js";
import type {
JSONRPCRequest,
JSONRPCNotification,
JSONRPCResultResponse,
JSONRPCErrorResponse,
} from "@modelcontextprotocol/sdk/types.js";
import type { MessageOrigin } from "./types.js";
export interface MessageTrackingCallbacks {
trackRequest?: (message: JSONRPCRequest, origin: MessageOrigin) => void;
trackResponse?: (
message: JSONRPCResultResponse | JSONRPCErrorResponse,
origin: MessageOrigin,
) => void;
trackNotification?: (
message: JSONRPCNotification,
origin: MessageOrigin,
) => void;
}
// Transport wrapper that intercepts all messages for tracking
export class MessageTrackingTransport implements Transport {
private baseTransport: Transport;
private callbacks: MessageTrackingCallbacks;
private negotiatedProtocolVersion?: string;
constructor(
baseTransport: Transport,
callbacks: MessageTrackingCallbacks,
) {
this.baseTransport = baseTransport;
this.callbacks = callbacks;
}
async start(): Promise<void> {
return this.baseTransport.start();
}
async send(
message: JSONRPCMessage,
options?: TransportSendOptions,
): Promise<void> {
// Track outgoing traffic symmetrically to onmessage. The client issues
// requests (client→server), answers server→client requests — roots/list,
// sampling, elicitation (responses, which messageLogState folds back into
// the originating request by id) — and emits its own notifications
// (initialized, progress, roots/list_changed). All are tagged origin
// "client".
if ("id" in message && message.id !== null && message.id !== undefined) {
if ("result" in message || "error" in message) {
this.callbacks.trackResponse?.(
message as JSONRPCResultResponse | JSONRPCErrorResponse,
"client",
);
} else if ("method" in message) {
this.callbacks.trackRequest?.(message as JSONRPCRequest, "client");
}
} else if ("method" in message) {
this.callbacks.trackNotification?.(
message as JSONRPCNotification,
"client",
);
}
return this.baseTransport.send(message, options);
}
async close(): Promise<void> {
return this.baseTransport.close();
}
get onclose(): (() => void) | undefined {
return this.baseTransport.onclose;
}
set onclose(handler: (() => void) | undefined) {
this.baseTransport.onclose = handler;
}
get onerror(): ((error: Error) => void) | undefined {
return this.baseTransport.onerror;
}
set onerror(handler: ((error: Error) => void) | undefined) {
this.baseTransport.onerror = handler;
}
get onmessage():
| (<T extends JSONRPCMessage>(message: T, extra?: MessageExtraInfo) => void)
| undefined {
return this.baseTransport.onmessage;
}
set onmessage(
handler:
| (<T extends JSONRPCMessage>(
message: T,
extra?: MessageExtraInfo,
) => void)
| undefined,
) {
if (handler) {
// Wrap the handler to track incoming messages
this.baseTransport.onmessage = <T extends JSONRPCMessage>(
message: T,
extra?: MessageExtraInfo,
) => {
// Track incoming messages
if (
"id" in message &&
message.id !== null &&
message.id !== undefined
) {
// Check if it's a response (has 'result' or 'error' property)
if ("result" in message || "error" in message) {
this.callbacks.trackResponse?.(
message as JSONRPCResultResponse | JSONRPCErrorResponse,
"server",
);
} else if ("method" in message) {
// This is a request coming from the server
this.callbacks.trackRequest?.(message as JSONRPCRequest, "server");
}
} else if ("method" in message) {
// Notification (no ID, has method)
this.callbacks.trackNotification?.(
message as JSONRPCNotification,
"server",
);
}
// Call the original handler
handler(message, extra);
};
} else {
this.baseTransport.onmessage = undefined;
}
}
get sessionId(): string | undefined {
return this.baseTransport.sessionId;
}
// Implemented as a concrete method (rather than delegating the base
// transport's optional `setProtocolVersion`) so the SDK Client always
// invokes it after the initialize handshake — including for stdio, whose
// base transport has no `setProtocolVersion`. We capture the negotiated
// version for the UI here, then forward to the base transport when it
// cares (HTTP transports stamp it into subsequent request headers).
setProtocolVersion(version: string): void {
this.negotiatedProtocolVersion = version;
this.baseTransport.setProtocolVersion?.(version);
}
/** MCP protocol version negotiated during initialize, once connected. */
get protocolVersion(): string | undefined {
return this.negotiatedProtocolVersion;
}
}