* fix(core): make "error" the canonical terminal status on a mid-session crash (#1490) On a real mid-session transport crash many SDK transports fire BOTH `onclose` and `onerror` in a transport-dependent order. The `onclose` guard (`if status !== "disconnected"`) let a trailing `onclose` downgrade a crash's `"error"` status back to `"disconnected"`, so the persistent terminal status differed by ordering: - onerror-then-onclose → "disconnected" - onclose-then-onerror → "error" `onclose` now treats `"error"` as terminal (only `"connected"`/ `"connecting"` → `"disconnected"`), so `"error"` is the canonical resting status in both orderings. It still emits the `disconnect` event exactly once so session-teardown consumers fire identically either way. Because the state managers gated list/message/subscription/task teardown on `getStatus() === "disconnected"`, holding the status at `"error"` would have left them stale in the onerror-first ordering — swapping one ordering-dependence for another. Introduce `isTerminalStatus()` (disconnected || error) and key every teardown guard off it so they clear identically regardless of crash ordering. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(core): single disconnect event when explicitly disconnecting from "error" (#1490 re-review) Addresses the non-blocking observation from the PR review: explicitly calling disconnect() from a held-"error" status could fire the `disconnect` event twice. close() can trigger the transport's onclose synchronously; onclose (holding status at "error") fired `disconnect`, then disconnect()'s own guard saw status still != "disconnected" and fired it again — a timing-dependence on whether the SDK closes sync. Add a `disconnecting` ownership flag: onclose defers its status set + `disconnect` event to disconnect() while it is set, so the explicit-disconnect path emits exactly one `disconnect` regardless of sync/async close. Crash-path onclose (flag unset) is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(core): deterministically pin the sync-close disconnect double-fire (#1490 re-review) The real-stdio test asserts the single-disconnect invariant but may not exercise the sync-close branch (the one that double-fired) if the SDK stdio transport closes asynchronously. Add a test that overrides the SDK client's close() to invoke the transport's onclose synchronously, forcing the exact timing the `disconnecting` flag guards. Verified it asserts 2 (fails) without the flag and 1 (passes) with it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
133 lines
4.5 KiB
TypeScript
133 lines
4.5 KiB
TypeScript
/**
|
|
* PagedRequestorTasksState: holds an aggregated list of requestor tasks loaded
|
|
* via loadPage(cursor). Subscribes to tasksListChanged (refetch first page),
|
|
* taskStatusChange, requestorTaskUpdated, and taskCancelled. Clears on disconnect.
|
|
*
|
|
* Ported from v1.5/main. v2 substitutes `InspectorClientProtocol` for the
|
|
* concrete `InspectorClient` since the runtime class is not yet ported.
|
|
*/
|
|
|
|
import type { InspectorClientProtocol } from "../inspectorClientProtocol.js";
|
|
import type { Task } from "@modelcontextprotocol/sdk/types.js";
|
|
import { isTerminalStatus } from "../types.js";
|
|
import type { InspectorClientEventMap } from "../inspectorClientEventTarget.js";
|
|
import {
|
|
TypedEventTarget,
|
|
type TypedEventGeneric,
|
|
} from "../typedEventTarget.js";
|
|
import { mergeTaskIntoList } from "./mergeTaskIntoList.js";
|
|
|
|
export interface PagedRequestorTasksStateEventMap {
|
|
tasksChange: Task[];
|
|
}
|
|
|
|
export interface LoadPageResult {
|
|
tasks: Task[];
|
|
nextCursor?: string;
|
|
}
|
|
|
|
export class PagedRequestorTasksState extends TypedEventTarget<PagedRequestorTasksStateEventMap> {
|
|
private tasks: Task[] = [];
|
|
private nextCursor: string | undefined = undefined;
|
|
private client: InspectorClientProtocol | null = null;
|
|
private unsubscribe: (() => void) | null = null;
|
|
|
|
constructor(client: InspectorClientProtocol) {
|
|
super();
|
|
this.client = client;
|
|
const onStatusChange = (): void => {
|
|
if (isTerminalStatus(this.client?.getStatus())) {
|
|
this.tasks = [];
|
|
this.nextCursor = undefined;
|
|
this.dispatchTypedEvent("tasksChange", []);
|
|
}
|
|
};
|
|
const onTasksListChanged = (): void => {
|
|
void this.loadPage(undefined);
|
|
};
|
|
const onTaskStatusChange = (
|
|
e: TypedEventGeneric<InspectorClientEventMap, "taskStatusChange">,
|
|
): void => {
|
|
const { taskId, task } = e.detail;
|
|
this.tasks = mergeTaskIntoList(this.tasks, taskId, task);
|
|
this.dispatchTypedEvent("tasksChange", this.tasks);
|
|
};
|
|
const onRequestorTaskUpdated = (
|
|
e: TypedEventGeneric<InspectorClientEventMap, "requestorTaskUpdated">,
|
|
): void => {
|
|
const { taskId, task } = e.detail;
|
|
this.tasks = mergeTaskIntoList(this.tasks, taskId, task);
|
|
this.dispatchTypedEvent("tasksChange", this.tasks);
|
|
};
|
|
const onTaskCancelled = (
|
|
e: TypedEventGeneric<InspectorClientEventMap, "taskCancelled">,
|
|
): void => {
|
|
const { taskId } = e.detail;
|
|
const idx = this.tasks.findIndex((t) => t.taskId === taskId);
|
|
if (idx >= 0) {
|
|
const next = [...this.tasks];
|
|
const prev = next[idx]!;
|
|
next[idx] = { ...prev, status: "cancelled" as const };
|
|
this.tasks = next;
|
|
this.dispatchTypedEvent("tasksChange", this.tasks);
|
|
}
|
|
};
|
|
this.client.addEventListener("statusChange", onStatusChange);
|
|
this.client.addEventListener("tasksListChanged", onTasksListChanged);
|
|
this.client.addEventListener("taskStatusChange", onTaskStatusChange);
|
|
this.client.addEventListener(
|
|
"requestorTaskUpdated",
|
|
onRequestorTaskUpdated,
|
|
);
|
|
this.client.addEventListener("taskCancelled", onTaskCancelled);
|
|
this.unsubscribe = () => {
|
|
if (this.client) {
|
|
this.client.removeEventListener("statusChange", onStatusChange);
|
|
this.client.removeEventListener("tasksListChanged", onTasksListChanged);
|
|
this.client.removeEventListener("taskStatusChange", onTaskStatusChange);
|
|
this.client.removeEventListener(
|
|
"requestorTaskUpdated",
|
|
onRequestorTaskUpdated,
|
|
);
|
|
this.client.removeEventListener("taskCancelled", onTaskCancelled);
|
|
}
|
|
this.client = null;
|
|
};
|
|
}
|
|
|
|
getTasks(): Task[] {
|
|
return [...this.tasks];
|
|
}
|
|
|
|
getNextCursor(): string | undefined {
|
|
return this.nextCursor;
|
|
}
|
|
|
|
clear(): void {
|
|
this.tasks = [];
|
|
this.nextCursor = undefined;
|
|
this.dispatchTypedEvent("tasksChange", this.tasks);
|
|
}
|
|
|
|
async loadPage(cursor?: string): Promise<LoadPageResult> {
|
|
const c = this.client;
|
|
if (!c || c.getStatus() !== "connected") {
|
|
return { tasks: [], nextCursor: undefined };
|
|
}
|
|
const result = await c.listRequestorTasks(cursor);
|
|
this.tasks =
|
|
cursor === undefined
|
|
? [...result.tasks]
|
|
: [...this.tasks, ...result.tasks];
|
|
this.nextCursor = result.nextCursor;
|
|
this.dispatchTypedEvent("tasksChange", this.tasks);
|
|
return { tasks: result.tasks, nextCursor: result.nextCursor };
|
|
}
|
|
|
|
destroy(): void {
|
|
this.unsubscribe?.();
|
|
this.unsubscribe = null;
|
|
this.tasks = [];
|
|
this.nextCursor = undefined;
|
|
}
|
|
}
|