inspector/clients/web/src/components/groups/InlineElicitationRequest/InlineElicitationRequest.tsx
cliffhall 6002c2ce33 fix: gate submission on unsendable field text, and on required tool args
A field that cannot turn its text into a value reports `undefined` — which is
exactly what an empty field reports. That made the two indistinguishable to
every caller of `SchemaForm`, so invalid text in an optional field was
submittable and the argument simply arrived absent (#2020).

`SchemaForm` now tracks per-field draft validity and reports it through
`onValidityChange`, covering both fields that hold text the form cannot send:
the JSON editor (unparseable text) and the number input (a magnitude JS cannot
hold exactly, which is dropped rather than silently rounded). The number field
also states it on itself, as the JSON editor already did. A nested object form
reports through the same channel, and both the field-level and form-level
effects report "valid" on cleanup so a draft cannot outlive the field that held
it — a remount under a new `resetKey`, or an unmounted panel.

`ToolDetailPanel` gated Execute on `isExecuting` alone, so it also had no
required-argument check at all — unlike the App and elicitation panels. It now
uses `hasMissingRequiredFields` like they do. `InlineElicitationRequest` had
neither gate and gets both.

Signed-off-by: cliffhall <cliff@futurescale.com>
2026-08-15 21:19:04 -04:00

149 lines
3.8 KiB
TypeScript

import {
Badge,
Button,
Code,
Group,
Loader,
Paper,
Stack,
Text,
} from "@mantine/core";
import type {
ElicitRequest,
ElicitRequestFormParams,
} from "@modelcontextprotocol/client";
import type { PendingRequestOrigin } from "@inspector/core/mcp/types.js";
import { useState } from "react";
import {
hasMissingRequiredFields,
type InspectorFormSchema,
} from "../../../utils/jsonUtils";
import { SchemaForm } from "../SchemaForm/SchemaForm";
import { MrtrOriginNote } from "../../elements/MrtrOriginNote/MrtrOriginNote";
export interface InlineElicitationRequestProps {
request: ElicitRequest["params"];
queuePosition: string;
values?: Record<string, unknown>;
isWaiting?: boolean;
/**
* How the request reached the Inspector — a legacy server→client request or a
* modern MRTR `input_required` round. Drives the era-accurate note; defaults
* to `"server-request"` (legacy, note hidden). (#1704)
*/
origin?: PendingRequestOrigin;
onChange: (values: Record<string, unknown>) => void;
onSubmit: () => void;
onCancel: () => void;
}
const RequestContainer = Paper.withProps({
p: "md",
withBorder: true,
});
const QueueLabel = Text.withProps({
size: "xs",
c: "dimmed",
});
const ItalicMessage = Text.withProps({
size: "sm",
fs: "italic",
});
const ActionsRow = Group.withProps({
justify: "flex-end",
gap: "xs",
});
const CompactButton = Button.withProps({
size: "xs",
variant: "light",
});
function isFormMode(
request: ElicitRequest["params"],
): request is ElicitRequestFormParams {
return "requestedSchema" in request;
}
function isUrlMode(
request: ElicitRequest["params"],
): request is Extract<ElicitRequest["params"], { mode: "url" }> {
return "url" in request;
}
function getBadgeLabel(request: ElicitRequest["params"]): string {
return isFormMode(request)
? "elicitation/create (form)"
: "elicitation/create (url)";
}
export function InlineElicitationRequest({
request,
queuePosition,
values,
isWaiting,
origin = "server-request",
onChange,
onSubmit,
onCancel,
}: InlineElicitationRequestProps) {
// Same gate as `ElicitationFormPanel`, which this is the inline form of: a
// missing required answer, or a field holding text it could not turn into a
// value, must not be submittable — neither is visible in `values` (#2020).
const [hasInvalidDraft, setHasInvalidDraft] = useState(false);
const formValues = values ?? {};
const submitDisabled =
isFormMode(request) &&
(hasMissingRequiredFields(
request.requestedSchema as InspectorFormSchema,
formValues,
) ||
hasInvalidDraft);
return (
<RequestContainer>
<Stack gap="sm">
<Group justify="space-between">
<Badge color="violet">{getBadgeLabel(request)}</Badge>
<QueueLabel>{queuePosition}</QueueLabel>
</Group>
<ItalicMessage>{request.message}</ItalicMessage>
<MrtrOriginNote origin={origin} />
{isFormMode(request) && (
<SchemaForm
schema={request.requestedSchema as InspectorFormSchema}
values={formValues}
onChange={onChange}
onValidityChange={setHasInvalidDraft}
/>
)}
{isUrlMode(request) && (
<>
<Code block>{request.url}</Code>
{isWaiting && (
<Group>
<Loader size="xs" />
<Text size="xs">Waiting...</Text>
</Group>
)}
</>
)}
<ActionsRow>
<CompactButton onClick={onCancel}>Cancel</CompactButton>
{isFormMode(request) && (
<Button size="xs" onClick={onSubmit} disabled={submitDisabled}>
Submit
</Button>
)}
</ActionsRow>
</Stack>
</RequestContainer>
);
}