cliffhall
ec2ef5656d
docs: address Copilot review round 5 on #2203
...
The truncation guard read only the first physical line of the scalar, so
a multiline plain scalar slipped past it:
description: Covers boards
#28 and #11
YAML parses that as `Covers boards`, and the first-line-only comparison
saw `Covers boards` on both sides and reported no loss — passing the
exact silent truncation the guard exists to reject.
It now walks the whole plain scalar: the value line plus every indented
continuation, whitespace-collapsed to match YAML's folding of newlines to
spaces. Quoted and block scalars are still skipped, since neither loses
text to a comment.
Two regression cases: the multiline truncation, and a multiline scalar
with no `#`, which must stay clean — the fix cannot be "reject anything
multiline".
No skill description or eval case changed, so skills:eval is unchanged
from round 4's 63/63. local:gate passes, 34/34. 390/390 script tests.
Signed-off-by: cliffhall <cliff@futurescale.com>
2026-09-01 11:31:22 -04:00
..
announced-child.mjs
chore(scripts): rename the local pre-push gate off ci, and guard it out of CI ( #2146 )
2026-08-26 23:56:34 -04:00
announced-child.test.mjs
chore(scripts): rename the local pre-push gate off ci, and guard it out of CI ( #2146 )
2026-08-26 23:56:34 -04:00
child-cleanup.mjs
fix(scripts): await the pack:verify web child's exit before removing its work dir ( #1895 )
2026-08-01 19:50:00 -04:00
child-cleanup.test.mjs
fix(scripts): await the pack:verify web child's exit before removing its work dir ( #1895 )
2026-08-01 19:50:00 -04:00
claude-cli.mjs
chore: address Copilot review round 17
2026-08-29 04:54:04 -04:00
claude-cli.test.mjs
chore: address Copilot review round 7 (Windows .cmd shims)
2026-08-29 02:32:30 -04:00
deep-link-connect.mjs
chore(web): connected-flow smoke for the Tools, Resources and Prompts tabs
2026-08-26 23:09:44 -04:00
deep-link-connect.test.mjs
chore(web): connected-flow smoke for the Tools, Resources and Prompts tabs
2026-08-26 23:09:44 -04:00
ensure-test-servers.mjs
docs(scripts): correct the deleted-source caveat — it is silent, not loud
2026-08-25 01:37:40 -04:00
ensure-test-servers.test.mjs
fix(scripts): pin the tsbuildinfo inside build/, assert on cache hits
2026-08-25 01:11:10 -04:00
headless-browser.mjs
fix(smoke): assert the requested engine is the one launched; fix the remedy
2026-08-26 09:33:21 -04:00
headless-browser.test.mjs
fix(smoke): assert the requested engine is the one launched; fix the remedy
2026-08-26 09:33:21 -04:00
mcp-app-flow.mjs
chore(web): connected-flow smoke for the Tools, Resources and Prompts tabs
2026-08-26 23:09:44 -04:00
mcp-app-flow.test.mjs
Merge branch 'v2/main' into v2/chore/2003-pack-verify-app-render
2026-08-24 09:05:53 -04:00
npm-scripts.mjs
chore: address Copilot review round 20
2026-08-29 05:32:12 -04:00
npm-scripts.test.mjs
test(cli,tui): typecheck the __tests__ dirs ( #1791 ) ( #1799 )
2026-07-27 12:05:35 -04:00
prod-web-server.mjs
test(smoke): cover loadBrowser's failure branches; fix a stale helper comment
2026-08-25 22:42:06 -04:00
prod-web-server.test.mjs
fix(smoke): pin the teardown ordering, and correct a docblock the test refuted
2026-08-11 15:17:56 -04:00
pty.mjs
fix(scripts): address Copilot review round 2 on #2147
2026-08-26 21:36:40 -04:00
pty.test.mjs
fix(scripts): address Copilot review round 2 on #2147
2026-08-26 21:36:40 -04:00
render-smoke.mjs
fix(scripts): make the test stubs drain, and the raw-mode guard testable ( #2147 )
2026-08-26 22:13:35 -04:00
render-smoke.test.mjs
test(scripts): anchor the render-smoke overlap paint to the parent's clock
2026-08-27 23:51:36 -04:00
resolve-node-bin.mjs
fix(scripts): keep the resolver local, complete the cmd.exe quoting
2026-08-17 00:18:40 -04:00
resolve-node-bin.test.mjs
fix(scripts): keep the resolver local, complete the cmd.exe quoting
2026-08-17 00:18:40 -04:00
skill-manifest.mjs
docs: address Copilot review round 5 on #2203
2026-09-01 11:31:22 -04:00
skill-manifest.test.mjs
docs: address Copilot review round 5 on #2203
2026-09-01 11:31:22 -04:00
tsc-program.mjs
fix(scripts): validate the bin name and that its file exists
2026-08-16 23:43:24 -04:00
tsc-program.test.mjs
chore(scripts): compare only the copies a program actually met
2026-08-16 12:35:38 -04:00
win-shell-args.mjs
fix(scripts): keep the resolver local, complete the cmd.exe quoting
2026-08-17 00:18:40 -04:00
win-shell-args.test.mjs
fix(scripts): keep the resolver local, complete the cmd.exe quoting
2026-08-17 00:18:40 -04:00
workflow-gate.mjs
chore(scripts): cover PowerShell's Env: drive, and correct two stale scope summaries ( #2146 )
2026-08-27 02:44:41 -04:00
workflow-gate.test.mjs
chore(scripts): cover PowerShell's Env: drive, and correct two stale scope summaries ( #2146 )
2026-08-27 02:44:41 -04:00