* test(tui): cover useSelectableList hook + leaf Ink components (#1501) Add ink-testing-library and renderer-based tests for useSelectableList, SelectableItem, and Tabs. Widen the vitest include glob to .test.tsx and lift these files from the interim React-surface coverage exclusion. The blanket src/components/**/*.tsx exclude is expanded into an explicit per-file list so remaining components can be lifted incrementally. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(tui): add ink-scroll-view passthrough mock for renderer tests (#1501) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(tui): add ink-form passthrough mock for modal renderer tests (#1501) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(tui): cover all Ink tab + modal components via renderer tests (#1501) Add ink-testing-library tests for the 12 Ink components (InfoTab, AuthTab, ResourcesTab, PromptsTab, ToolsTab, NotificationsTab, HistoryTab, RequestsTab, and the Tool/Resource/Prompt test modals + DetailsModal), mounting them through the ink-scroll-view / ink-form passthrough doubles and driving keypresses via stdin. Modal components render position:absolute (empty frame under the test renderer) so their tests assert on behavior — injected InspectorClient fakes and onClose — while the passthrough ScrollView still mounts the inner JSX for coverage. Lift these 12 components from the interim React-surface exclusion in vitest.config.ts; only App.tsx remains excluded. All files clear the uniform 90/90/90/90 per-file gate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(tui): add App.tsx renderer-test harness + foundation tests (#1501) Mock the full @inspector/core surface (InspectorClient, the 7 managed-state classes, the 8 react hooks, transport + auth) behind a controllable harness, plus the ink-scroll-view/ink-form passthroughs, so App renders under ink-testing-library and its keyboard state machine can be driven via stdin. Concurrent ink mounts share raw-mode stdin, so each render is unmounted in afterEach. Foundation covers server-list nav, tab accelerators, connect/ disconnect, OAuth-tab gating, and connected-status rendering (~50% baseline). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(tui): cover App.tsx via mocked-core renderer tests; lift final exclusion (#1501) Extend App.test.tsx to 67 tests driving the keyboard state machine, tab content, modals, OAuth flows, and connect/disconnect across the controllable @inspector/core mock. App.tsx now clears the 90/90/90/90 per-file gate (94.6/90.6/94.5/96.6). Remove the last React-surface exclusion (src/App.tsx) from clients/tui/vitest.config.ts. The whole clients/tui/src tree is now under the uniform per-file coverage gate with no React-surface exclusions, completing the interim-scope lift from #1484. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(tui): raise stdout max-listeners in App test to silence warning (#1501) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(tui): raise App.tsx branch coverage >90 and de-flake coverage runs (#1501) Add targeted App.tsx tests for the OAuth handlers' non-Error throw arms (quick onCallback, guided start/advance, run-to-completion) and a re-entrant quick-auth guard, lifting App.tsx branch coverage 90.6% -> 91.48% for a safer margin above the 90 gate. Harden the App renderer tests against the heavier v8 coverage instrumentation, where React+ink's multi-macrotask render scheduling races fixed ticks: - press() now settles two ticks per key so focus/tab changes flush before the next key is routed (ink re-subscribes useInput on re-render); - expectFrame()/waitUntil() poll for frame content and async flow state (callbackServer opts) instead of asserting after a single fixed tick; - ResourcesTab's content-clear test polls for fetched content likewise. Plain 'npm test' (the CI path) was already stable; this makes the local coverage gate stable too (13/13 clean runs vs ~2/8 flaky before). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(tui): de-flake component renderer tests under slow CI (#1501) CI flaked on AuthTab's 'renders quick auth results' under the plain test run: its oauthFlowState is populated by a post-mount useEffect reading the inspectorClient, and a single-macrotask tick can race that effect -> setState -> re-render chain on a slow/loaded CI runner. Make each component test file's tick() flush several macrotask cycles so such chains settle deterministically before assertions (no test relies on precise tick timing — no fake timers / debounce). App.test.tsx already polls via expectFrame/waitUntil and passed CI, so it's unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(tui): address review — shared setupFile for max-listeners, consume-once ink-form global (#1501) Review follow-ups on #1538 (both non-blocking cleanups): - Hoist process.std{out,in}.setMaxListeners into a shared vitest setupFile (__tests__/setup.ts) wired via setupFiles, so every renderer test file inherits it and the MaxListenersExceededWarning is silenced across the whole suite — not just App.test.tsx. Remove the per-file call. - Make the ink-form double consume (clear) __INK_FORM_SUBMIT_VALUE__ on submit, eliminating the latent cross-test coupling on the shared global regardless of how the modal test files are organized. No production code changed; suite + coverage gate stay green (App.tsx 94.8/91.5/94.5/96.6), and the warning no longer prints. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
184 lines
5.8 KiB
TypeScript
184 lines
5.8 KiB
TypeScript
import React from "react";
|
|
import { describe, it, expect, vi } from "vitest";
|
|
import { render } from "ink-testing-library";
|
|
|
|
// MUST mock ink-scroll-view: the real ScrollView renders a placeholder minimap
|
|
// in the non-TTY test env and never mounts its children. This passthrough
|
|
// renders children directly and stubs scrollBy/scrollTo/getViewportHeight.
|
|
vi.mock("ink-scroll-view", () => import("./helpers/inkScrollViewMock.js"));
|
|
|
|
import type { StderrLogEntry } from "@inspector/core/mcp/index.js";
|
|
import { NotificationsTab } from "../src/components/NotificationsTab.js";
|
|
|
|
// Ink processes stdin keypresses asynchronously — await this after stdin.write
|
|
// and after rerender() before asserting.
|
|
const tick = async () => {
|
|
// Flush several macrotask cycles so an effect -> setState -> re-render chain
|
|
// settles before assertions, even on slow/loaded CI (a single tick can race).
|
|
for (let i = 0; i < 8; i++)
|
|
await new Promise((resolve) => setTimeout(resolve, 4));
|
|
};
|
|
|
|
// Real terminal escape sequences (with the leading ESC) so ink reliably parses
|
|
// them as arrow / page keys for this component's useInput handler.
|
|
const ESC = String.fromCharCode(27);
|
|
const UP = `${ESC}[A`;
|
|
const DOWN = `${ESC}[B`;
|
|
const PAGE_UP = `${ESC}[5~`;
|
|
const PAGE_DOWN = `${ESC}[6~`;
|
|
|
|
const makeLog = (message: string): StderrLogEntry => ({
|
|
timestamp: new Date("2026-06-27T12:34:56Z"),
|
|
message,
|
|
});
|
|
|
|
describe("NotificationsTab", () => {
|
|
it("renders the empty state when there are no logs", () => {
|
|
const { lastFrame } = render(
|
|
<NotificationsTab stderrLogs={[]} width={80} height={20} />,
|
|
);
|
|
const frame = lastFrame() ?? "";
|
|
expect(frame).toContain("Logging (0)");
|
|
expect(frame).toContain("No stderr output yet");
|
|
});
|
|
|
|
it("renders log entries with timestamps and messages", () => {
|
|
const logs = [makeLog("first error"), makeLog("second error")];
|
|
const { lastFrame } = render(
|
|
<NotificationsTab stderrLogs={logs} width={80} height={20} />,
|
|
);
|
|
const frame = lastFrame() ?? "";
|
|
expect(frame).toContain("Logging (2)");
|
|
expect(frame).toContain("first error");
|
|
expect(frame).toContain("second error");
|
|
expect(frame).not.toContain("No stderr output yet");
|
|
});
|
|
|
|
it("invokes onCountChange with the initial log count", () => {
|
|
const onCountChange = vi.fn();
|
|
render(
|
|
<NotificationsTab
|
|
stderrLogs={[makeLog("a"), makeLog("b")]}
|
|
width={80}
|
|
height={20}
|
|
onCountChange={onCountChange}
|
|
/>,
|
|
);
|
|
expect(onCountChange).toHaveBeenCalledWith(2);
|
|
});
|
|
|
|
it("re-invokes onCountChange when the log count changes", async () => {
|
|
const onCountChange = vi.fn();
|
|
const { rerender } = render(
|
|
<NotificationsTab
|
|
stderrLogs={[makeLog("a")]}
|
|
width={80}
|
|
height={20}
|
|
onCountChange={onCountChange}
|
|
/>,
|
|
);
|
|
expect(onCountChange).toHaveBeenLastCalledWith(1);
|
|
|
|
rerender(
|
|
<NotificationsTab
|
|
stderrLogs={[makeLog("a"), makeLog("b"), makeLog("c")]}
|
|
width={80}
|
|
height={20}
|
|
onCountChange={onCountChange}
|
|
/>,
|
|
);
|
|
await tick();
|
|
expect(onCountChange).toHaveBeenLastCalledWith(3);
|
|
});
|
|
|
|
it("picks up a changed onCountChange callback via the ref effect", async () => {
|
|
const first = vi.fn();
|
|
const second = vi.fn();
|
|
const { rerender } = render(
|
|
<NotificationsTab
|
|
stderrLogs={[makeLog("a")]}
|
|
width={80}
|
|
height={20}
|
|
onCountChange={first}
|
|
/>,
|
|
);
|
|
expect(first).toHaveBeenLastCalledWith(1);
|
|
|
|
// New callback identity + new count → the ref is updated, then the
|
|
// count-change effect fires the latest callback.
|
|
rerender(
|
|
<NotificationsTab
|
|
stderrLogs={[makeLog("a"), makeLog("b")]}
|
|
width={80}
|
|
height={20}
|
|
onCountChange={second}
|
|
/>,
|
|
);
|
|
await tick();
|
|
expect(second).toHaveBeenLastCalledWith(2);
|
|
});
|
|
|
|
it("renders without an onCountChange prop", () => {
|
|
const { lastFrame } = render(
|
|
<NotificationsTab
|
|
stderrLogs={[makeLog("solo")]}
|
|
width={80}
|
|
height={20}
|
|
/>,
|
|
);
|
|
expect(lastFrame() ?? "").toContain("solo");
|
|
});
|
|
|
|
it("highlights the header and handles scroll keys when focused", async () => {
|
|
const logs = [makeLog("line one"), makeLog("line two")];
|
|
const { lastFrame, stdin } = render(
|
|
<NotificationsTab stderrLogs={logs} width={80} height={20} focused />,
|
|
);
|
|
expect(lastFrame() ?? "").toContain("Logging (2)");
|
|
|
|
// Drive every useInput branch
|
|
stdin.write(UP);
|
|
await tick();
|
|
stdin.write(DOWN);
|
|
await tick();
|
|
stdin.write(PAGE_UP);
|
|
await tick();
|
|
stdin.write(PAGE_DOWN);
|
|
await tick();
|
|
stdin.write("x"); // non-handled key → else fall-through
|
|
await tick();
|
|
|
|
expect(lastFrame() ?? "").toContain("line one");
|
|
});
|
|
|
|
it("handles scroll keys with no logs (ScrollView absent → null scroll ref)", async () => {
|
|
// With an empty log list the ScrollView (and its ref) is never mounted, so
|
|
// scrollViewRef.current is null. Driving the scroll keys exercises the
|
|
// optional-chaining + `getViewportHeight() || 1` fallback paths.
|
|
const { lastFrame, stdin } = render(
|
|
<NotificationsTab stderrLogs={[]} width={80} height={20} focused />,
|
|
);
|
|
expect(lastFrame() ?? "").toContain("No stderr output yet");
|
|
|
|
stdin.write(UP);
|
|
await tick();
|
|
stdin.write(DOWN);
|
|
await tick();
|
|
stdin.write(PAGE_UP);
|
|
await tick();
|
|
stdin.write(PAGE_DOWN);
|
|
await tick();
|
|
|
|
expect(lastFrame() ?? "").toContain("No stderr output yet");
|
|
});
|
|
|
|
it("does not react to keys when not focused", async () => {
|
|
const logs = [makeLog("line one")];
|
|
const { lastFrame, stdin } = render(
|
|
<NotificationsTab stderrLogs={logs} width={80} height={20} />,
|
|
);
|
|
stdin.write(DOWN);
|
|
await tick();
|
|
expect(lastFrame() ?? "").toContain("line one");
|
|
});
|
|
});
|