inspector/clients/tui/__tests__
Repository files (latest commit first)
Filename Latest commit message Latest commit date
cliffhall 9117f633aa fix: address Copilot review round 17 on #2248
Four of the five findings share one root cause: the tri-state `outcome`
added in round 15 was not propagated to consumers, which kept branching
on `ok` — true for an `incomplete` report, since nothing that was checked
was wrong.

- CLI `summarizeSkillVerification` counts off `outcome`, not `ok`, so a
  truncated walk no longer prints "no conformance errors" one line before
  exiting SKILL_INCOMPLETE. A mixed failed/incomplete catalog reports
  both counts rather than letting the louder verdict hide the quieter.
- `verifySkills` sets the truncation reason only when entries were
  actually left unread. A file crossing the byte budget as the FINAL
  entry stopped nothing, and "Stopped after 3 of 3" both read as a
  contradiction and demoted a fully-read skill out of `verified`.
- The TUI status line switches on `outcome` through a `Record` over the
  union, so the INCOMPLETE arm is reachable and a fourth outcome would
  be a type error rather than a silently missing label.
- The `incomplete` doc paragraph said it makes `ok` false. It does not,
  deliberately — corrected, and it now names `outcome` as the thing a
  consumer must branch on.
- The web sidebar composes in the per-URI `duplicate-name` warning, so
  two colliding skills are badged in the catalog instead of looking
  clean until one is selected.

The suppressed `selfAttempted` finding is stale — fixed in round 16.

The existing TUI INCOMPLETE test was passing for the wrong reason: its
fixture understated every size, which is itself a mismatch, so the report
was `failed` and only the old `ok`-first branch printed INCOMPLETE. It is
rebuilt with honest digests and sizes, so truncation comes from the
declared-size prefilter and the report is genuinely incomplete.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ND46Ci64DC3tzBy9aG81Nc
Signed-off-by: cliffhall <cliff@futurescale.com>
2026-09-07 23:12:28 -04:00
..
helpers fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
App.test.tsx fix: address Copilot review round 1 on #2248 2026-09-07 18:43:58 -04:00
AuthTab.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
DetailsModal.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
HistoryTab.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
InfoTab.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
logger.test.ts test: raise per-file coverage gate to 90 across all clients (closes #1271) (#1532) 2026-06-27 15:26:03 -04:00
NotificationsTab.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
oauthDisplay.test.ts Guided-auth removal, OAuth smoke testing, and TUI/CLI support (#1531) 2026-06-29 15:35:51 -04:00
oauthMessageTone.test.ts fix(auth): read enumerated issuers exactly, and stop the TUI tone going stale (#2144) 2026-08-28 02:58:04 -04:00
openUrl.test.ts test(cli,tui): add in-process source coverage gates (#1484) (#1502) 2026-06-20 15:05:58 -04:00
promptArgsToForm.test.ts test(cli,tui): add in-process source coverage gates (#1484) (#1502) 2026-06-20 15:05:58 -04:00
PromptsTab.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
PromptTestModal.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
renderTui.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
RequestsTab.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
ResourcesTab.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
ResourceTestModal.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
schemaToForm.test.ts fix: decline a union branch requiring a name it never declares (#2224) 2026-09-06 12:59:52 -04:00
SelectableItem.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
setup.ts test(tui): extend coverage gate to Ink components + App.tsx (closes #1501) (#1538) 2026-06-29 08:19:12 -04:00
SkillsTab.test.tsx fix: address Copilot review round 17 on #2248 2026-09-07 23:12:28 -04:00
Tabs.test.tsx feat: Skills extension phase 3 — CLI, TUI, directory reads, frontmatter check 2026-09-07 18:10:37 -04:00
tabsConfig.test.ts fix: address Copilot review round 12 on #2248 2026-09-07 21:57:48 -04:00
ToolsTab.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
ToolTestModal.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00
tsupConfig.test.ts chore(lint): enable no-floating-promises in all five ESLint scopes 2026-08-16 20:57:32 -04:00
tui-servers.test.ts Guided-auth removal, OAuth smoke testing, and TUI/CLI support (#1531) 2026-06-29 15:35:51 -04:00
tui.test.ts Fixed tab naming to correspond to the web client. (#1780) 2026-07-25 20:11:52 -04:00
tuiOAuth.test.ts test(cli,tui): typecheck the __tests__ dirs (#1791) (#1799) 2026-07-27 12:05:35 -04:00
uriTemplateToForm.test.ts fix: dedupe a repeated name in a group, and name every unmet requirement 2026-08-17 00:33:52 -04:00
useSelectableList.test.tsx fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207) 2026-09-06 20:00:15 -04:00