519ecf49ee
A floated promise is invisible at review time — the call reads like an awaited one minus four characters — and the unhandled rejection it produces surfaces in a different test, in a different file, as a stack pointing at SDK internals. In #1947 two un-held `callTool` calls made `npm run ci` unpassable and took a full investigation to attribute; the fix was two lines. `@typescript-eslint/no-floating-promises` catches the class outright, so enable it at `error` everywhere. The rule is type-aware and `tseslint.configs.recommended` is not, so each scope's config gains a parser project. The four clients name their own tsconfig projects (both of them — `src` and `__tests__`/`server` live in different ones). The root scope has no tsconfig at all, so add `tsconfig.lint.json`: a lint-only project covering `core/**`, `test-servers/src/**`, and `vitest.shared.mts`, emitting nothing and gating nothing. It sets `moduleResolution: bundler` deliberately — under NodeNext `core/`'s extensionless imports fail to resolve, every import degrades to `any`, and the rule silently stops seeing promises at all. Measured surface, and the fixes: - core (2) — `stream.close()` in two Hono `onAbort` listeners. Hono invokes subscribers with a bare `subscriber()`, so a promise returned from the listener is floated one layer up; `closeAbortedStream` owns the rejection where it can actually be owned. - tui (5) — `handleDisconnect` had no catch of its own and its only caller is a key handler that cannot await, so a failing disconnect was a live unhandled rejection; it now surfaces the message the way `handleConnect` does. The rest are `void` at callers that genuinely cannot await, over callees that already own their failures. - web (92) — 83 are Storybook `expect(...)`, which is instrumented and returns a promise, now awaited (`scrollAreaStoryAssertions` is async for the same reason). Two tests were asserting against a provider call they never awaited. `open(url)` in both web servers now warns instead of escaping a synchronous callback. - cli, launcher — already clean. Type-aware linting costs time: `clients/web`'s `eslint .` goes from ~8s to ~19s, inside `validate`. Narrowing the loaded projects is the lever if that needs reducing later; dropping the rule is not. Closes #1959 Signed-off-by: cliffhall <cliff@futurescale.com>
98 lines
3.3 KiB
JavaScript
98 lines
3.3 KiB
JavaScript
import js from "@eslint/js";
|
|
import globals from "globals";
|
|
import tseslint from "typescript-eslint";
|
|
import { defineConfig, globalIgnores } from "eslint/config";
|
|
|
|
// Root-level lint gate for first-party code that no client's own `eslint .`
|
|
// (each scoped to its own directory) reaches: the shared `core/` package
|
|
// (#1689) and the root-owned "shared" surface — `test-servers/src/**`, the
|
|
// root `vitest.shared.mts`, and this config file itself (#1767). `core/` is
|
|
// isomorphic TypeScript (browser-side OAuth + Node backends + shared runtime);
|
|
// the shared surface is Node-only tooling/tests. Neither has JSX, so no React
|
|
// plugin is needed.
|
|
// Type-aware linting for the two blocks below. `no-floating-promises` needs
|
|
// type information, which `tseslint.configs.recommended` (the non-type-aware
|
|
// set) does not provide — so each block adds a parser project (#1959).
|
|
//
|
|
// `tsconfig.lint.json` exists for this and nothing else: the root has no
|
|
// tsconfig of its own (`core/` is typechecked through `clients/web`'s
|
|
// `tsc -b`, `test-servers/src` through `clients/cli`'s test project), and a
|
|
// parser project must literally *contain* every file it is asked to lint.
|
|
const typeAware = {
|
|
languageOptions: {
|
|
parserOptions: {
|
|
project: ["./tsconfig.lint.json"],
|
|
tsconfigRootDir: import.meta.dirname,
|
|
},
|
|
},
|
|
rules: {
|
|
// The class this catches is invisible at review time: the call reads like
|
|
// an awaited one minus four characters, and the unhandled rejection it
|
|
// produces surfaces in a different test, in a different file, as a stack
|
|
// pointing at SDK internals — which is how #1947 came to fail the whole
|
|
// `npm run ci` chain from two un-held `callTool` promises.
|
|
"@typescript-eslint/no-floating-promises": "error",
|
|
},
|
|
};
|
|
|
|
const sharedRules = {
|
|
// An `_`-prefix is the explicit "intentionally unused" marker —
|
|
// interface-conformance params in fakes, destructuring-rest omissions,
|
|
// and reserved-for-later args. Honor it rather than deleting signal.
|
|
"@typescript-eslint/no-unused-vars": [
|
|
"error",
|
|
{
|
|
argsIgnorePattern: "^_",
|
|
varsIgnorePattern: "^_",
|
|
caughtErrorsIgnorePattern: "^_",
|
|
},
|
|
],
|
|
};
|
|
|
|
export default defineConfig([
|
|
globalIgnores([
|
|
"core/**/build/**",
|
|
"core/**/dist/**",
|
|
"test-servers/build/**",
|
|
]),
|
|
{
|
|
files: ["core/**/*.{ts,tsx}"],
|
|
extends: [js.configs.recommended, tseslint.configs.recommended],
|
|
languageOptions: {
|
|
ecmaVersion: 2022,
|
|
sourceType: "module",
|
|
globals: {
|
|
...globals.node,
|
|
...globals.browser,
|
|
},
|
|
},
|
|
rules: sharedRules,
|
|
},
|
|
{
|
|
files: [
|
|
"test-servers/src/**/*.{ts,tsx,mts,cts}",
|
|
"vitest.shared.mts",
|
|
"eslint.config.js",
|
|
],
|
|
extends: [js.configs.recommended, tseslint.configs.recommended],
|
|
languageOptions: {
|
|
ecmaVersion: 2022,
|
|
sourceType: "module",
|
|
globals: {
|
|
...globals.node,
|
|
},
|
|
},
|
|
rules: sharedRules,
|
|
},
|
|
{
|
|
// Type-aware pass over the same surface, minus `eslint.config.js` — it is
|
|
// JavaScript, so no tsconfig contains it and asking the parser for a
|
|
// project would fail it outright rather than lint it.
|
|
files: [
|
|
"core/**/*.{ts,tsx}",
|
|
"test-servers/src/**/*.{ts,tsx,mts,cts}",
|
|
"vitest.shared.mts",
|
|
],
|
|
...typeAware,
|
|
},
|
|
]);
|