modelcontextprotocol/java-sdk
Watch
1
0
Fork
You've already forked java-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Handle non-compliant notification responses (#589)

Browse source 
Ensure warnings are logged for all non-compliant responses to JSON-RPC
notifications, including empty responses. Empty responses now display
as "[empty]" in log messages for better clarity.

Resolves #586

Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
This commit is contained in:
Christian Tzolov 2025-10-01 23:14:29 +02:00 • committed by GitHub
commit 3f7578b3ce
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
mcp-core/src/main/java/io/modelcontextprotocol/client/transport/HttpClientStreamableHttpTransport.java
View file

@ -507,8 +507,9 @@ public class HttpClientStreamableHttpTransport implements McpClientTransport {
else if (contentType.contains(APPLICATION_JSON)) { else if (contentType.contains(APPLICATION_JSON)) {
deliveredSink.success(); deliveredSink.success();
String data = ((ResponseSubscribers.AggregateResponseEvent) responseEvent).data(); String data = ((ResponseSubscribers.AggregateResponseEvent) responseEvent).data();
if (sentMessage instanceof McpSchema.JSONRPCNotification && Utils.hasText(data)) { if (sentMessage instanceof McpSchema.JSONRPCNotification) {
logger.warn("Notification: {} received non-compliant response: {}", sentMessage, data); logger.warn("Notification: {} received non-compliant response: {}", sentMessage,
Utils.hasText(data) ? data : "[empty]");
return Mono.empty(); return Mono.empty();
} }

5
mcp-spring/mcp-spring-webflux/src/main/java/io/modelcontextprotocol/client/transport/WebClientStreamableHttpTransport.java
View file

@ -423,8 +423,9 @@ public class WebClientStreamableHttpTransport implements McpClientTransport {
ClientResponse response) { ClientResponse response) {
return response.bodyToMono(String.class).<Iterable<McpSchema.JSONRPCMessage>>handle((responseMessage, s) -> { return response.bodyToMono(String.class).<Iterable<McpSchema.JSONRPCMessage>>handle((responseMessage, s) -> {
try { try {
if (sentMessage instanceof McpSchema.JSONRPCNotification && Utils.hasText(responseMessage)) { if (sentMessage instanceof McpSchema.JSONRPCNotification) {
logger.warn("Notification: {} received non-compliant response: {}", sentMessage, responseMessage); logger.warn("Notification: {} received non-compliant response: {}", sentMessage,
Utils.hasText(responseMessage) ? responseMessage : "[empty]");
s.complete(); s.complete();
} }
else { else {