modelcontextprotocol/java-sdk
Watch
1
0
Fork
You've already forked java-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make McpTransportContext.metadata immutable (#1076)

Browse source 
Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
This commit is contained in:
Iuliia Sobolevska 2026-08-07 18:36:22 +02:00 • committed by GitHub
commit 8ee8ccbc17
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 90 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
mcp-core/src/main/java/io/modelcontextprotocol/common/DefaultMcpTransportContext.java
View file

@ -20,7 +20,7 @@ class DefaultMcpTransportContext implements McpTransportContext {
DefaultMcpTransportContext(Map<String, Object> metadata) {
Assert.notNull(metadata, "The metadata cannot be null");
this.metadata = metadata;
this.metadata = Map.copyOf(metadata);
}
@Override

89
mcp-core/src/test/java/io/modelcontextprotocol/common/McpTransportContextTests.java Normal file
View file

@ -0,0 +1,89 @@
/*
* Copyright 2026-2026 the original author or authors.
*/
package io.modelcontextprotocol.common;
import java.util.HashMap;
import java.util.Map;
import org.junit.jupiter.api.Test;
import static org.assertj.core.api.Assertions.assertThat;
/**
* Tests for {@link McpTransportContext#create(Map)}, which is documented to return an
* unmodifiable context.
*/
class McpTransportContextTests {
@Test
void createdContextShouldNotSeeLaterWritesToTheSourceMap() {
Map<String, Object> metadata = new HashMap<>();
metadata.put("tenant", "acme");
McpTransportContext context = McpTransportContext.create(metadata);
metadata.put("tenant", "other");
assertThat(context.get("tenant")).isEqualTo("acme");
}
@Test
void createdContextShouldNotSeeLaterAdditionsToTheSourceMap() {
Map<String, Object> metadata = new HashMap<>();
metadata.put("tenant", "acme");
McpTransportContext context = McpTransportContext.create(metadata);
metadata.put("added-after-the-fact", "surprise");
assertThat(context.get("added-after-the-fact")).isNull();
}
@Test
void createdContextShouldNotBeEmptiedByClearingTheSourceMap() {
Map<String, Object> metadata = new HashMap<>();
metadata.put("tenant", "acme");
McpTransportContext context = McpTransportContext.create(metadata);
metadata.clear();
assertThat(context.get("tenant")).isEqualTo("acme");
}
@Test
void createdContextShouldRemainUsableAsAMapKey() {
Map<String, Object> metadata = new HashMap<>();
metadata.put("tenant", "acme");
McpTransportContext context = McpTransportContext.create(metadata);
Map<McpTransportContext, String> byContext = new HashMap<>();
byContext.put(context, "value");
metadata.put("tenant", "other");
assertThat(byContext.get(context)).isEqualTo("value");
}
@Test
void twoContextsCreatedFromEqualMapsShouldStayEqual() {
Map<String, Object> first = new HashMap<>();
first.put("tenant", "acme");
Map<String, Object> second = new HashMap<>();
second.put("tenant", "acme");
McpTransportContext firstContext = McpTransportContext.create(first);
McpTransportContext secondContext = McpTransportContext.create(second);
assertThat(firstContext).isEqualTo(secondContext);
first.put("tenant", "other");
assertThat(firstContext).isEqualTo(secondContext);
}
@Test
void createdContextFromAnImmutableMapIsAlreadyCorrect() {
McpTransportContext context = McpTransportContext.create(Map.of("tenant", "acme"));
assertThat(context.get("tenant")).isEqualTo("acme");
}
}