adjust test timeout values

Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
This commit is contained in:
Christian Tzolov 2025-03-19 08:27:38 +01:00 • committed by Christian Tzolov
commit 914a14a92a
7 changed files with 33 additions and 14 deletions

View file

@ -4,6 +4,8 @@
package io.modelcontextprotocol.client; package io.modelcontextprotocol.client;
import java.time.Duration;
import io.modelcontextprotocol.client.transport.WebFluxSseClientTransport; import io.modelcontextprotocol.client.transport.WebFluxSseClientTransport;
import io.modelcontextprotocol.spec.ClientMcpTransport; import io.modelcontextprotocol.spec.ClientMcpTransport;
import org.junit.jupiter.api.Timeout; import org.junit.jupiter.api.Timeout;
@ -46,4 +48,8 @@ class WebFluxSseMcpAsyncClientTests extends AbstractMcpAsyncClientTests {
container.stop(); container.stop();
} }
protected Duration getInitializationTimeout() {
return Duration.ofSeconds(1);
}
} }

View file

@ -4,6 +4,8 @@
package io.modelcontextprotocol.client; package io.modelcontextprotocol.client;
import java.time.Duration;
import io.modelcontextprotocol.client.transport.WebFluxSseClientTransport; import io.modelcontextprotocol.client.transport.WebFluxSseClientTransport;
import io.modelcontextprotocol.spec.ClientMcpTransport; import io.modelcontextprotocol.spec.ClientMcpTransport;
import org.junit.jupiter.api.Timeout; import org.junit.jupiter.api.Timeout;
@ -46,4 +48,8 @@ class WebFluxSseMcpSyncClientTests extends AbstractMcpSyncClientTests {
container.stop(); container.stop();
} }
protected Duration getInitializationTimeout() {
return Duration.ofSeconds(1);
}
} }

View file

@ -63,7 +63,7 @@ public abstract class AbstractMcpAsyncClientTests {
} }
protected Duration getInitializationTimeout() { protected Duration getInitializationTimeout() {
return Duration.ofSeconds(1); return Duration.ofSeconds(2);
} }
@BeforeEach @BeforeEach
@ -90,10 +90,10 @@ public abstract class AbstractMcpAsyncClientTests {
@Test @Test
void testConstructorWithInvalidArguments() { void testConstructorWithInvalidArguments() {
assertThatThrownBy(() -> McpClient.sync(null).build()).isInstanceOf(IllegalArgumentException.class) assertThatThrownBy(() -> McpClient.async(null).build()).isInstanceOf(IllegalArgumentException.class)
.hasMessage("Transport must not be null"); .hasMessage("Transport must not be null");
assertThatThrownBy(() -> McpClient.sync(mcpTransport).requestTimeout(null).build()) assertThatThrownBy(() -> McpClient.async(mcpTransport).requestTimeout(null).build())
.isInstanceOf(IllegalArgumentException.class) .isInstanceOf(IllegalArgumentException.class)
.hasMessage("Request timeout must not be null"); .hasMessage("Request timeout must not be null");
} }

View file

@ -48,16 +48,18 @@ public abstract class AbstractMcpSyncClientTests {
abstract protected ClientMcpTransport createMcpTransport(); abstract protected ClientMcpTransport createMcpTransport();
abstract protected void onStart(); protected void onStart() {
}
abstract protected void onClose(); protected void onClose() {
}
protected Duration getRequestTimeout() { protected Duration getRequestTimeout() {
return Duration.ofSeconds(10); return Duration.ofSeconds(10);
} }
protected Duration getInitializationTimeout() { protected Duration getInitializationTimeout() {
return Duration.ofSeconds(1); return Duration.ofSeconds(2);
} }
@BeforeEach @BeforeEach

View file

@ -49,9 +49,11 @@ public abstract class AbstractMcpSyncClientTests {
abstract protected ClientMcpTransport createMcpTransport(); abstract protected ClientMcpTransport createMcpTransport();
abstract protected void onStart(); protected void onStart() {
}
abstract protected void onClose(); protected void onClose() {
}
protected Duration getRequestTimeout() { protected Duration getRequestTimeout() {
return Duration.ofSeconds(10); return Duration.ofSeconds(10);

View file

@ -4,6 +4,8 @@
package io.modelcontextprotocol.client; package io.modelcontextprotocol.client;
import java.time.Duration;
import io.modelcontextprotocol.client.transport.ServerParameters; import io.modelcontextprotocol.client.transport.ServerParameters;
import io.modelcontextprotocol.client.transport.StdioClientTransport; import io.modelcontextprotocol.client.transport.StdioClientTransport;
import io.modelcontextprotocol.spec.ClientMcpTransport; import io.modelcontextprotocol.spec.ClientMcpTransport;
@ -26,4 +28,8 @@ class StdioMcpAsyncClientTests extends AbstractMcpAsyncClientTests {
return new StdioClientTransport(stdioParams); return new StdioClientTransport(stdioParams);
} }
protected Duration getInitializationTimeout() {
return Duration.ofSeconds(6);
}
} }

View file

@ -4,6 +4,7 @@
package io.modelcontextprotocol.client; package io.modelcontextprotocol.client;
import java.time.Duration;
import java.util.concurrent.atomic.AtomicReference; import java.util.concurrent.atomic.AtomicReference;
import io.modelcontextprotocol.client.transport.ServerParameters; import io.modelcontextprotocol.client.transport.ServerParameters;
@ -44,12 +45,8 @@ class StdioMcpSyncClientTests extends AbstractMcpSyncClientTests {
assertThat(receivedError.get()).isNotNull().isEqualTo(errorMessage); assertThat(receivedError.get()).isNotNull().isEqualTo(errorMessage);
} }
@Override protected Duration getInitializationTimeout() {
protected void onStart() { return Duration.ofSeconds(6);
}
@Override
protected void onClose() {
} }
} }