From d282d40a38a1453ac130c43eb6ca6262f5f8745a Mon Sep 17 00:00:00 2001 From: Sun Yuhan Date: Thu, 10 Jul 2025 20:14:43 +0800 Subject: [PATCH] refactor: replace string concatenation with {} placeholders in log statements Signed-off-by: Sun Yuhan --- .../client/transport/StdioClientTransport.java | 4 ++-- .../io/modelcontextprotocol/spec/McpClientSessionTests.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/mcp/src/main/java/io/modelcontextprotocol/client/transport/StdioClientTransport.java b/mcp/src/main/java/io/modelcontextprotocol/client/transport/StdioClientTransport.java index 5553445..009d415 100644 --- a/mcp/src/main/java/io/modelcontextprotocol/client/transport/StdioClientTransport.java +++ b/mcp/src/main/java/io/modelcontextprotocol/client/transport/StdioClientTransport.java @@ -269,7 +269,7 @@ public class StdioClientTransport implements McpClientTransport { } catch (Exception e) { if (!isClosing) { - logger.error("Error processing inbound message for line: " + line, e); + logger.error("Error processing inbound message for line: {}", line, e); } break; } @@ -366,7 +366,7 @@ public class StdioClientTransport implements McpClientTransport { } })).doOnNext(process -> { if (process.exitValue() != 0) { - logger.warn("Process terminated with code " + process.exitValue()); + logger.warn("Process terminated with code {}", process.exitValue()); } else { logger.info("MCP server process stopped"); diff --git a/mcp/src/test/java/io/modelcontextprotocol/spec/McpClientSessionTests.java b/mcp/src/test/java/io/modelcontextprotocol/spec/McpClientSessionTests.java index f72be43..85dcd26 100644 --- a/mcp/src/test/java/io/modelcontextprotocol/spec/McpClientSessionTests.java +++ b/mcp/src/test/java/io/modelcontextprotocol/spec/McpClientSessionTests.java @@ -47,7 +47,7 @@ class McpClientSessionTests { void setUp() { transport = new MockMcpClientTransport(); session = new McpClientSession(TIMEOUT, transport, Map.of(), - Map.of(TEST_NOTIFICATION, params -> Mono.fromRunnable(() -> logger.info("Status update: " + params)))); + Map.of(TEST_NOTIFICATION, params -> Mono.fromRunnable(() -> logger.info("Status update: {}", params)))); } @AfterEach