refactor: explicit locked detekt config (#729)

Migrate detekt to a convention plugin in `buildSrc`, switch the project
to a fully explicit YAML config (`buildUponDefaultConfig = false`), fix
the real findings that this stricter setup revealed, and remove
`@Suppress` annotations that became unnecessary after the rule changes.

## Motivation and Context
- Explicit visibility into the rule set
- Lock against detekt version upgrades

## Breaking Changes
None

## Types of changes
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [x] Documentation update

## Checklist
- [x] I have read the [MCP
Documentation](https://modelcontextprotocol.io)
- [x] My code follows the repository's style guidelines
- [x] New and existing tests pass locally
- [x] I have added appropriate error handling
- [x] I have added or updated documentation as needed
This commit is contained in:
Pavel Gorgulov 2026-04-29 12:31:49 +02:00 • committed by GitHub
commit 64804a05c2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -2,31 +2,6 @@
<SmellBaseline>
<ManuallySuppressedIssues/>
<CurrentIssues>
<ID>CyclomaticComplexMethod:jsonUtils.kt:@OptIn(ExperimentalUnsignedTypes::class, ExperimentalSerializationApi::class) private fun convertToJsonElement: JsonElement</ID>
<ID>InjectDispatcher:utils.jvm.kt:IO</ID>
<ID>InstanceOfCheckForException:AbstractClientTransport.kt:AbstractClientTransport$e is McpException</ID>
<ID>LongMethod:Protocol.kt:Protocol$public suspend fun &lt;T : RequestResult> request: T</ID>
<ID>MagicNumber:completion.kt:CompleteResult.Completion$100</ID>
<ID>MatchingDeclarationName:capabilities.dsl.kt:ClientCapabilitiesBuilder</ID>
<ID>MatchingDeclarationName:methods.kt:Method</ID>
<ID>MaxLineLength:AbstractClientTransport.kt:AbstractClientTransport$*</ID>
<ID>MaxLineLength:ClientTransportState.kt:ClientTransportState.Initializing$*</ID>
<ID>MaxLineLength:Protocol.kt:Protocol$"Received progress notification: token=${notification.params.progressToken}, progress=${notification.params.progress}/${notification.params.total}"</ID>
<ID>MaxLineLength:Protocol.kt:Protocol$*</ID>
<ID>MaxLineLength:Protocol.kt:RequestOptions$*</ID>
<ID>MaxLineLength:Transport.kt:Transport$*</ID>
<ID>MaxLineLength:TransportSendOptions.kt:TransportSendOptions$*</ID>
<ID>NoNameShadowing:Protocol.kt:Protocol$error</ID>
<ID>ReturnCount:ReadBuffer.kt:ReadBuffer$public fun readMessage: JSONRPCMessage?</ID>
<ID>ThrowsCount:AbstractClientTransport.kt:AbstractClientTransport$public override suspend fun send</ID>
<ID>TooGenericExceptionCaught:AbstractClientTransport.kt:AbstractClientTransport$e: Exception</ID>
<ID>TooGenericExceptionCaught:Protocol.kt:Protocol$cause: Throwable</ID>
<ID>TooGenericExceptionCaught:Protocol.kt:Protocol$error: Throwable</ID>
<ID>TooGenericExceptionCaught:Protocol.kt:Protocol$sendError: Throwable</ID>
<ID>TooGenericExceptionCaught:ReadBuffer.kt:ReadBuffer$e: Exception</ID>
<ID>TooGenericExceptionCaught:WebSocketMcpTransport.kt:WebSocketMcpTransport$e: Exception</ID>
<ID>TooManyFunctions:Protocol.kt:Protocol</ID>
<ID>UnsafeCallOnNullableType:Protocol.kt:Protocol$response!!</ID>
<ID>UseCheckNotNull:Protocol.kt:Protocol$check(error != null)</ID>
</CurrentIssues>
</SmellBaseline>