# Detekt setup hardeing; address some issues - Address some detekt findings: missing KDocs, formatting, use `check*` & `orEmpty()`` - Remove unnecessary KDoc comments from deprecated classes in `types.kt` - Add Detekt baseline XML files for all modules - Enforce stricter Detekt rules by setting `failOnSeverity` from `None` to `Error` ## Motivation and Context Detekt is not actually failing the build on violations. This PR is enabling Detekt to fail on errors. Baseline fines added for historical issues. Follow-up for #501 ## How Has This Been Tested? Regressions ## Breaking Changes No breaking changes. ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Refactoring - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] Documentation update ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [x] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [x] My code follows the repository's style guidelines - [x] New and existing tests pass locally - [ ] I have added appropriate error handling - [ ] I have added or updated documentation as needed
27 lines
1.9 KiB
XML
27 lines
1.9 KiB
XML
<?xml version='1.0' encoding='UTF-8'?>
|
|
<SmellBaseline>
|
|
<ManuallySuppressedIssues/>
|
|
<CurrentIssues>
|
|
<ID>CyclomaticComplexMethod:jsonUtils.kt:@OptIn(ExperimentalUnsignedTypes::class, ExperimentalSerializationApi::class) private fun convertToJsonElement: JsonElement</ID>
|
|
<ID>LongMethod:Protocol.kt:Protocol$public suspend fun <T : RequestResult> request: T</ID>
|
|
<ID>MagicNumber:completion.kt:CompleteResult.Completion$100</ID>
|
|
<ID>MatchingDeclarationName:capabilities.dsl.kt:ClientCapabilitiesBuilder</ID>
|
|
<ID>MatchingDeclarationName:methods.kt:Method</ID>
|
|
<ID>MaxLineLength:AbstractClientTransport.kt:AbstractClientTransport$*</ID>
|
|
<ID>MaxLineLength:ClientTransportState.kt:ClientTransportState.Initializing$*</ID>
|
|
<ID>MaxLineLength:Protocol.kt:Protocol$"Received progress notification: token=${notification.params.progressToken}, progress=${notification.params.progress}/${notification.params.total}"</ID>
|
|
<ID>MaxLineLength:Protocol.kt:Protocol$*</ID>
|
|
<ID>MaxLineLength:Protocol.kt:RequestOptions$*</ID>
|
|
<ID>MaxLineLength:Transport.kt:Transport$*</ID>
|
|
<ID>MaxLineLength:TransportSendOptions.kt:TransportSendOptions$*</ID>
|
|
<ID>ReturnCount:ReadBuffer.kt:ReadBuffer$public fun readMessage: JSONRPCMessage?</ID>
|
|
<ID>ThrowsCount:AbstractClientTransport.kt:AbstractClientTransport$public override suspend fun send</ID>
|
|
<ID>TooGenericExceptionCaught:AbstractClientTransport.kt:AbstractClientTransport$e: Exception</ID>
|
|
<ID>TooGenericExceptionCaught:Protocol.kt:Protocol$cause: Throwable</ID>
|
|
<ID>TooGenericExceptionCaught:Protocol.kt:Protocol$error: Throwable</ID>
|
|
<ID>TooGenericExceptionCaught:Protocol.kt:Protocol$sendError: Throwable</ID>
|
|
<ID>TooGenericExceptionCaught:ReadBuffer.kt:ReadBuffer$e: Exception</ID>
|
|
<ID>TooGenericExceptionCaught:WebSocketMcpTransport.kt:WebSocketMcpTransport$e: Exception</ID>
|
|
<ID>TooManyFunctions:Protocol.kt:Protocol</ID>
|
|
</CurrentIssues>
|
|
</SmellBaseline>
|