modelcontextprotocol/mcpb
Watch
1
0
Fork
You've already forked mcpb
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: move to standard ignore implementation (#50)

Browse source
This commit is contained in:
Samuel Attard 2025-07-06 16:35:24 -07:00 • committed by GitHub
commit 9ce2d6fd0e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 23 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

44
src/node/files.ts
View file

@ -1,5 +1,6 @@
import { existsSync, readdirSync, readFileSync, statSync } from "fs";
import { basename, join, relative, sep } from "path";
import ignore from "ignore";
import { join, relative, sep } from "path";
// Files/patterns to exclude from the package
export const EXCLUDE_PATTERNS = [
@ -115,35 +116,18 @@ function matchesPattern(
return false;
}
function buildIgnoreChecker(additionalPatterns: string[]) {
return ignore().add(EXCLUDE_PATTERNS).add(additionalPatterns);
}
/**
* Used for testing, calls the same methods as the other ignore checks
*/
export function shouldExclude(
filePath: string,
additionalPatterns: string[] = [],
): boolean {
const fileName = basename(filePath);
const allPatterns = [...EXCLUDE_PATTERNS, ...additionalPatterns];
const negationPatterns = allPatterns.filter((p) => p.startsWith("!"));
const exclusionPatterns = allPatterns.filter((p) => !p.startsWith("!"));
let shouldExcludeFile = false;
for (const pattern of exclusionPatterns) {
if (matchesPattern(pattern, filePath, fileName)) {
shouldExcludeFile = true;
break;
}
}
// If excluded, check if any negation pattern un-excludes it
if (shouldExcludeFile) {
for (const pattern of negationPatterns) {
const negatedPattern = pattern.slice(1);
if (matchesPattern(negatedPattern, filePath, fileName)) {
// File should not be excluded (negation pattern matched)
return false;
}
}
}
return shouldExcludeFile;
return buildIgnoreChecker(additionalPatterns).ignores(filePath);
}
export function getAllFiles(
@ -154,11 +138,13 @@ export function getAllFiles(
): Record<string, Uint8Array> {
const files = readdirSync(dirPath);
const ignoreChecker = buildIgnoreChecker(additionalPatterns);
for (const file of files) {
const filePath = join(dirPath, file);
const relativePath = relative(baseDir, filePath);
if (shouldExclude(relativePath, additionalPatterns)) {
if (ignoreChecker.ignores(relativePath)) {
continue;
}
@ -194,11 +180,13 @@ export function getAllFilesWithCount(
): GetAllFilesResult {
const files = readdirSync(dirPath);
const ignoreChecker = buildIgnoreChecker(additionalPatterns);
for (const file of files) {
const filePath = join(dirPath, file);
const relativePath = relative(baseDir, filePath);
if (shouldExclude(relativePath, additionalPatterns)) {
if (ignoreChecker.ignores(relativePath)) {
ignoredCount++;
continue;
}