modelcontextprotocol/php-sdk
Watch
1
0
Fork
You've already forked php-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Schema] Serialize a settingless extension as an object (#438)

Browse source 
* [Schema] Serialize a settingless extension as an object

An extension declaring support with no settings was advertised as `[]`, an
empty JSON array, which the wire schema rejects - `extensions` maps an id to
a settings *object*. Both ServerCapabilities and ClientCapabilities now cast
each entry, so it goes out as `{}`.

* Apply suggestion from @chr-hertel
This commit is contained in:
Christopher Hertel 2026-08-18 14:59:12 +02:00 • committed by GitHub
commit 08d332c7ac
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 28 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

18
tests/Unit/Schema/Extension/CapabilitiesExtensionsTest.php
View file

@ -57,6 +57,24 @@ class CapabilitiesExtensionsTest extends TestCase
$this->assertObjectHasProperty(McpApps::EXTENSION_ID, $json['extensions']);
}
public function testServerCapabilitiesSerializeSettinglessExtensionAsObject(): void
{
$caps = new ServerCapabilities(tools: true, extensions: ['acme/thing' => []]);
$json = json_encode($caps->jsonSerialize(), \JSON_UNESCAPED_SLASHES);
$this->assertStringContainsString('"acme/thing":{}', (string) $json);
}
public function testClientCapabilitiesSerializeSettinglessExtensionAsObject(): void
{
$caps = new ClientCapabilities(elicitation: true, extensions: ['acme/thing' => []]);
$json = json_encode($caps->jsonSerialize(), \JSON_UNESCAPED_SLASHES);
$this->assertStringContainsString('"acme/thing":{}', (string) $json);
}
public function testServerCapabilitiesJsonSerializeWithoutExtensions(): void
{
$caps = new ServerCapabilities(tools: true);