modelcontextprotocol/php-sdk
Watch
1
0
Fork
You've already forked php-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Address issue with pagination limit builder class class (#83)

Browse source
This commit is contained in:
Sule-Balogun Olanrewaju 2025-09-27 12:43:40 +01:00 • committed by GitHub
commit 095ea2af50
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 58 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

47
tests/Unit/Server/RequestHandler/ListToolsHandlerTest.php
View file

@ -137,7 +137,7 @@ class ListToolsHandlerTest extends TestCase
public function testReturnsAllToolsWhenCountIsLessThanPageSize(): void
{
// Arrange
$this->addToolsToRegistry(2); // Less than page size (3)
$this->addToolsToRegistry(2); // Less than page size 3
$request = $this->createListToolsRequest();
// Act
@ -239,6 +239,51 @@ class ListToolsHandlerTest extends TestCase
$this->assertEquals($result1->tools, $result2->tools);
}
#[TestDox('Uses custom page size when provided')]
public function testUsesCustomPageSizeWhenProvided(): void
{
// Arrange
$customPageSize = 5;
$customHandler = new ListToolsHandler($this->registry, pageSize: $customPageSize);
$this->addToolsToRegistry(10);
$request = $this->createListToolsRequest();
// Act
$response = $customHandler->handle($request, $this->session);
// Assert
/** @var ListToolsResult $result */
$result = $response->result;
$this->assertInstanceOf(ListToolsResult::class, $result);
$this->assertCount($customPageSize, $result->tools);
$this->assertNotNull($result->nextCursor);
}
#[TestDox('Different page sizes produce different pagination results')]
public function testDifferentPageSizesProduceDifferentPaginationResults(): void
{
// Arrange
$this->addToolsToRegistry(10);
$smallPageHandler = new ListToolsHandler($this->registry, pageSize: 2);
$largePageHandler = new ListToolsHandler($this->registry, pageSize: 7);
$request = $this->createListToolsRequest();
// Act
$smallPageResponse = $smallPageHandler->handle($request, $this->session);
$largePageResponse = $largePageHandler->handle($request, $this->session);
// Assert
/** @var ListToolsResult $smallResult */
$smallResult = $smallPageResponse->result;
/** @var ListToolsResult $largeResult */
$largeResult = $largePageResponse->result;
$this->assertCount(2, $smallResult->tools);
$this->assertCount(7, $largeResult->tools);
$this->assertNotNull($smallResult->nextCursor);
$this->assertNotNull($largeResult->nextCursor);
}
private function addToolsToRegistry(int $count): void
{
for ($i = 0; $i < $count; ++$i) {