Split testsuite for unit and inspector based tests (#82)

This commit is contained in:
Christopher Hertel 2025-09-25 23:27:41 +02:00 • committed by GitHub
commit 3ec4cf612a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 188 additions and 85 deletions

View file

@ -0,0 +1,118 @@
<?php
/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Mcp\Tests\Unit\JsonRpc;
use Mcp\JsonRpc\Handler;
use Mcp\JsonRpc\MessageFactory;
use Mcp\Schema\JsonRpc\Response;
use Mcp\Server\MethodHandlerInterface;
use Mcp\Server\Session\SessionFactoryInterface;
use Mcp\Server\Session\SessionInterface;
use Mcp\Server\Session\SessionStoreInterface;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Uid\Uuid;
class HandlerTest extends TestCase
{
#[TestDox('Make sure a single notification can be handled by multiple handlers.')]
public function testHandleMultipleNotifications()
{
$handlerA = $this->getMockBuilder(MethodHandlerInterface::class)
->disableOriginalConstructor()
->onlyMethods(['supports', 'handle'])
->getMock();
$handlerA->method('supports')->willReturn(true);
$handlerA->expects($this->once())->method('handle');
$handlerB = $this->getMockBuilder(MethodHandlerInterface::class)
->disableOriginalConstructor()
->onlyMethods(['supports', 'handle'])
->getMock();
$handlerB->method('supports')->willReturn(false);
$handlerB->expects($this->never())->method('handle');
$handlerC = $this->getMockBuilder(MethodHandlerInterface::class)
->disableOriginalConstructor()
->onlyMethods(['supports', 'handle'])
->getMock();
$handlerC->method('supports')->willReturn(true);
$handlerC->expects($this->once())->method('handle');
$sessionFactory = $this->createMock(SessionFactoryInterface::class);
$sessionStore = $this->createMock(SessionStoreInterface::class);
$session = $this->createMock(SessionInterface::class);
$sessionFactory->method('create')->willReturn($session);
$sessionFactory->method('createWithId')->willReturn($session);
$sessionStore->method('exists')->willReturn(true);
$jsonRpc = new Handler(
MessageFactory::make(),
$sessionFactory,
$sessionStore,
[$handlerA, $handlerB, $handlerC]
);
$sessionId = Uuid::v4();
$result = $jsonRpc->process(
'{"jsonrpc": "2.0", "method": "notifications/initialized"}',
$sessionId
);
iterator_to_array($result);
}
#[TestDox('Make sure a single request can NOT be handled by multiple handlers.')]
public function testHandleMultipleRequests()
{
$handlerA = $this->getMockBuilder(MethodHandlerInterface::class)
->disableOriginalConstructor()
->onlyMethods(['supports', 'handle'])
->getMock();
$handlerA->method('supports')->willReturn(true);
$handlerA->expects($this->once())->method('handle')->willReturn(new Response(1, ['result' => 'success']));
$handlerB = $this->getMockBuilder(MethodHandlerInterface::class)
->disableOriginalConstructor()
->onlyMethods(['supports', 'handle'])
->getMock();
$handlerB->method('supports')->willReturn(false);
$handlerB->expects($this->never())->method('handle');
$handlerC = $this->getMockBuilder(MethodHandlerInterface::class)
->disableOriginalConstructor()
->onlyMethods(['supports', 'handle'])
->getMock();
$handlerC->method('supports')->willReturn(true);
$handlerC->expects($this->never())->method('handle');
$sessionFactory = $this->createMock(SessionFactoryInterface::class);
$sessionStore = $this->createMock(SessionStoreInterface::class);
$session = $this->createMock(SessionInterface::class);
$sessionFactory->method('create')->willReturn($session);
$sessionFactory->method('createWithId')->willReturn($session);
$sessionStore->method('exists')->willReturn(true);
$jsonRpc = new Handler(
MessageFactory::make(),
$sessionFactory,
$sessionStore,
[$handlerA, $handlerB, $handlerC]
);
$sessionId = Uuid::v4();
$result = $jsonRpc->process(
'{"jsonrpc": "2.0", "id": 1, "method": "tools/list"}',
$sessionId
);
iterator_to_array($result);
}
}

View file

@ -0,0 +1,95 @@
<?php
/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Mcp\Tests\Unit\JsonRpc;
use Mcp\Exception\InvalidInputMessageException;
use Mcp\JsonRpc\MessageFactory;
use Mcp\Schema\Notification\CancelledNotification;
use Mcp\Schema\Notification\InitializedNotification;
use Mcp\Schema\Request\GetPromptRequest;
use PHPUnit\Framework\TestCase;
final class MessageFactoryTest extends TestCase
{
private MessageFactory $factory;
protected function setUp(): void
{
$this->factory = new MessageFactory([
CancelledNotification::class,
InitializedNotification::class,
GetPromptRequest::class,
]);
}
public function testCreateRequest()
{
$json = '{"jsonrpc": "2.0", "method": "prompts/get", "params": {"name": "create_story"}, "id": 123}';
$result = $this->first($this->factory->create($json));
$this->assertInstanceOf(GetPromptRequest::class, $result);
$this->assertSame('prompts/get', $result::getMethod());
$this->assertSame('create_story', $result->name);
$this->assertSame(123, $result->getId());
}
public function testCreateNotification()
{
$json = '{"jsonrpc": "2.0", "method": "notifications/cancelled", "params": {"requestId": 12345}}';
$result = $this->first($this->factory->create($json));
$this->assertInstanceOf(CancelledNotification::class, $result);
$this->assertSame('notifications/cancelled', $result::getMethod());
$this->assertSame(12345, $result->requestId);
}
public function testInvalidJson()
{
$this->expectException(\JsonException::class);
$this->first($this->factory->create('invalid json'));
}
public function testMissingMethod()
{
$result = $this->first($this->factory->create('{"jsonrpc": "2.0", "params": {}, "id": 1}'));
$this->assertInstanceOf(InvalidInputMessageException::class, $result);
$this->assertEquals('Invalid JSON-RPC request, missing valid "method".', $result->getMessage());
}
public function testBatchMissingMethod()
{
$results = $this->factory->create('[{"jsonrpc": "2.0", "params": {}, "id": 1}, {"jsonrpc": "2.0", "method": "notifications/initialized", "params": {}}]');
$results = iterator_to_array($results);
$result = array_shift($results);
$this->assertInstanceOf(InvalidInputMessageException::class, $result);
$this->assertEquals('Invalid JSON-RPC request, missing valid "method".', $result->getMessage());
$result = array_shift($results);
$this->assertInstanceOf(InitializedNotification::class, $result);
}
/**
* @param iterable<mixed> $items
*/
private function first(iterable $items): mixed
{
foreach ($items as $item) {
return $item;
}
return null;
}
}