From 4486776e7d2582ea2557c68fb7a2fefaa1b8ac70 Mon Sep 17 00:00:00 2001 From: Adebayo120 <54323098+Adebayo120@users.noreply.github.com> Date: Sun, 12 Oct 2025 13:51:21 +0100 Subject: [PATCH] [Server] Remove redundant Builder.setServerCapabilities method (#107) --- .../stdio-explicit-registration/server.php | 2 +- src/Server/Builder.php | 18 +++++------------- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/examples/stdio-explicit-registration/server.php b/examples/stdio-explicit-registration/server.php index e44d1ff..2189bf1 100644 --- a/examples/stdio-explicit-registration/server.php +++ b/examples/stdio-explicit-registration/server.php @@ -28,7 +28,7 @@ $server = Server::builder() ->addResource([SimpleHandlers::class, 'getAppVersion'], 'app://version', 'application_version', mimeType: 'text/plain') ->addPrompt([SimpleHandlers::class, 'greetingPrompt'], 'personalized_greeting') ->addResourceTemplate([SimpleHandlers::class, 'getItemDetails'], 'item://{itemId}/details', 'get_item_details', mimeType: 'application/json') - ->setServerCapabilities(new ServerCapabilities( + ->setCapabilities(new ServerCapabilities( tools: true, toolsListChanged: false, resources: true, diff --git a/src/Server/Builder.php b/src/Server/Builder.php index 39f2cb8..35f5d3f 100644 --- a/src/Server/Builder.php +++ b/src/Server/Builder.php @@ -75,8 +75,6 @@ final class Builder private ?string $instructions = null; - private ?ServerCapabilities $explicitCapabilities = null; - /** * @var array */ @@ -177,9 +175,9 @@ final class Builder /** * Explicitly set server capabilities. If set, this overrides automatic detection. */ - public function setCapabilities(ServerCapabilities $capabilities): self + public function setCapabilities(ServerCapabilities $serverCapabilities): self { - $this->explicitCapabilities = $capabilities; + $this->serverCapabilities = $serverCapabilities; return $this; } @@ -266,13 +264,6 @@ final class Builder return $this; } - public function setServerCapabilities(ServerCapabilities $serverCapabilities): self - { - $this->serverCapabilities = $serverCapabilities; - - return $this; - } - /** * Manually registers a tool handler. * @@ -370,7 +361,7 @@ final class Builder $sessionStore = $this->sessionStore ?? new InMemorySessionStore($sessionTtl); $messageFactory = MessageFactory::make(); - $capabilities = $this->explicitCapabilities ?? $registry->getCapabilities(); + $capabilities = $registry->getCapabilities(); $configuration = new Configuration($this->serverInfo, $capabilities, $this->paginationLimit, $this->instructions); $referenceHandler = new ReferenceHandler($container); @@ -597,7 +588,8 @@ final class Builder } if (\is_array($handler)) { - return \sprintf('%s::%s', + return \sprintf( + '%s::%s', \is_object($handler[0]) ? $handler[0]::class : $handler[0], $handler[1], );