[Server] Stop Session::forget() from creating missing segments (#484)

src/Server/Session/Session.php

@@ -110,15 +110,12 @@ class Session implements SessionInterface
         while (\count($segments) > 1) {
             $segment = array_shift($segments);
             if (!isset($data[$segment]) || !\is_array($data[$segment])) {
-                $data[$segment] = [];
+                return;
             }
             $data = &$data[$segment];
         }
 
-        $lastKey = array_shift($segments);
+        unset($data[array_shift($segments)]);
-        if (isset($data[$lastKey])) {
-            unset($data[$lastKey]);
-        }
     }
 
     public function clear(): void

tests/Unit/Server/Session/SessionTest.php

@@ -245,6 +245,21 @@ class SessionTest extends TestCase
         $this->assertFalse($this->session->has('nonexistent'));
     }
 
+    public function testForgetDoesNotCreateIntermediateSegments(): void
+    {
+        $this->session->forget('a.b');
+
+        $this->assertSame([], $this->session->all());
+    }
+
+    public function testForgetDoesNotOverwriteNonArrayIntermediateValue(): void
+    {
+        $this->session->set('key', 'string_value');
+        $this->session->forget('key.nested');
+
+        $this->assertSame('string_value', $this->session->get('key'));
+    }
+
     public function testSessionCanStoreVariousDataTypes(): void
     {
         $this->session->set('string', 'value');