modelcontextprotocol/php-sdk
Watch
1
0
Fork
You've already forked php-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(session): initialize data lazily in save() to prevent uninitialized property access (#252)

Browse source
This commit is contained in:
Antoine Bluchet 2026-03-05 00:07:49 +01:00 • committed by GitHub
commit 61c20f1450
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/Server/Session/Session.php
View file

@ -51,7 +51,7 @@ class Session implements SessionInterface
public function save(): bool public function save(): bool
{ {
return $this->store->write($this->id, json_encode($this->data, \JSON_THROW_ON_ERROR)); return $this->store->write($this->id, json_encode($this->readData(), \JSON_THROW_ON_ERROR));
} }
public function get(string $key, mixed $default = null): mixed public function get(string $key, mixed $default = null): mixed

9
tests/Unit/Server/Session/SessionTest.php
View file

@ -34,6 +34,15 @@ class SessionTest extends TestCase
$this->assertEquals(['foo' => 'bar'], $result); $this->assertEquals(['foo' => 'bar'], $result);
} }
public function testSaveBeforeReadInitializesData()
{
$store = new InMemorySessionStore();
$session = new Session($store);
// save() before any get()/set() should not crash
$this->assertTrue($session->save());
}
public function testAllReturnsEmptyArrayForNullPayload() public function testAllReturnsEmptyArrayForNullPayload()
{ {
$store = $this->getMockBuilder(InMemorySessionStore::class) $store = $this->getMockBuilder(InMemorySessionStore::class)