modelcontextprotocol/php-sdk
Watch
1
0
Fork
You've already forked php-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(server): consistent arg name in session store impl (#127)

Browse source
This commit is contained in:
Christopher Hertel 2025-10-31 21:02:54 +01:00 • committed by GitHub
commit 67cc641247
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/Server/Session/FileSessionStore.php
View file

@ -50,9 +50,9 @@ class FileSessionStore implements SessionStoreInterface
return ($this->clock->now()->getTimestamp() - $mtime) <= $this->ttl;
}
public function read(Uuid $sessionId): string|false
public function read(Uuid $id): string|false
{
$path = $this->pathFor($sessionId);
$path = $this->pathFor($id);
if (!is_file($path)) {
return false;
@ -73,9 +73,9 @@ class FileSessionStore implements SessionStoreInterface
return $data;
}
public function write(Uuid $sessionId, string $data): bool
public function write(Uuid $id, string $data): bool
{
$path = $this->pathFor($sessionId);
$path = $this->pathFor($id);
$tmp = $path.'.tmp';
if (false === @file_put_contents($tmp, $data, \LOCK_EX)) {
@ -98,9 +98,9 @@ class FileSessionStore implements SessionStoreInterface
return true;
}
public function destroy(Uuid $sessionId): bool
public function destroy(Uuid $id): bool
{
$path = $this->pathFor($sessionId);
$path = $this->pathFor($id);
if (is_file($path)) {
@unlink($path);

16
src/Server/Session/InMemorySessionStore.php
View file

@ -35,9 +35,9 @@ class InMemorySessionStore implements SessionStoreInterface
return isset($this->store[$id->toRfc4122()]);
}
public function read(Uuid $sessionId): string|false
public function read(Uuid $id): string|false
{
$session = $this->store[$sessionId->toRfc4122()] ?? '';
$session = $this->store[$id->toRfc4122()] ?? '';
if ('' === $session) {
return false;
}
@ -45,7 +45,7 @@ class InMemorySessionStore implements SessionStoreInterface
$currentTimestamp = $this->clock->now()->getTimestamp();
if ($currentTimestamp - $session['timestamp'] > $this->ttl) {
unset($this->store[$sessionId->toRfc4122()]);
unset($this->store[$id->toRfc4122()]);
return false;
}
@ -53,9 +53,9 @@ class InMemorySessionStore implements SessionStoreInterface
return $session['data'];
}
public function write(Uuid $sessionId, string $data): bool
public function write(Uuid $id, string $data): bool
{
$this->store[$sessionId->toRfc4122()] = [
$this->store[$id->toRfc4122()] = [
'data' => $data,
'timestamp' => $this->clock->now()->getTimestamp(),
];
@ -63,10 +63,10 @@ class InMemorySessionStore implements SessionStoreInterface
return true;
}
public function destroy(Uuid $sessionId): bool
public function destroy(Uuid $id): bool
{
if (isset($this->store[$sessionId->toRfc4122()])) {
unset($this->store[$sessionId->toRfc4122()]);
if (isset($this->store[$id->toRfc4122()])) {
unset($this->store[$id->toRfc4122()]);
}
return true;