modelcontextprotocol/php-sdk
Watch
1
0
Fork
You've already forked php-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Add PSR-3 compliant exception context when logging exceptions (#300)

Browse source 
* Add PSR-3 exception context to caught error logs

* Apply review feedback
This commit is contained in:
Sven Münnich 2026-05-12 23:20:42 +02:00 • committed by GitHub
commit 73414d65f6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 88 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/Client/Handler/Request/SamplingRequestHandler.php
View file

@ -55,7 +55,7 @@ class SamplingRequestHandler implements RequestHandlerInterface
return new Response($request->getId(), $result);
} catch (SamplingException $e) {
$this->logger->error('Sampling failed: '.$e->getMessage());
$this->logger->error('Sampling failed: '.$e->getMessage(), ['exception' => $e]);
return Error::forInternalError($e->getMessage(), $request->getId());
} catch (\Throwable $e) {

2
src/Client/Transport/HttpTransport.php
View file

@ -170,7 +170,7 @@ class HttpTransport extends BaseTransport
$this->httpClient->sendRequest($request);
$this->logger->info('Session closed', ['session_id' => $this->sessionId]);
} catch (\Throwable $e) {
$this->logger->warning('Failed to close session', ['error' => $e->getMessage()]);
$this->logger->warning('Failed to close session', ['exception' => $e]);
}
}