Registry Architecture Refactoring - Enhanced Separation of Concerns (#46)
* refactor: Separate Registry concerns following SOLID principles [WIP] - Extract ReferenceProvider and ReferenceRegistryInterface interfaces - Create DefaultToolExecutor with ReferenceHandlerInterface - Remove execution responsibility from Registry class - Enable custom handler and executor implementations * refactor: implement SOLID principles with separated execution concerns * Create DefaultResourceReader, DefaultPromptGetter * Refactor JsonRpc Handler and RequestHandlers to use dedicated executors * Update ServerBuilder to support custom executors via dependency injection * chore: remove extra comments * feat: introduce DispatchableRegistry for enhanced tool and resource management * refactor: use proper interfaces * refactor: implement HandlerInterface for improved abstraction and flexibility * test: add unit tests for DispatchableRegistry and Registry classes * refactor: cover with unit tests Resource reader, Prompt getter and Tool executor * cs fix * phpstan fix * test: add unit tests for CallToolHandler, GetPromptHandler, PingHandler, and ReadResourceHandler * refactor: revert Handler * chore: remove style guide for tests * refactor: remove "Default" prefix from classes * refactor: remove DispatchableRegistry * refactor: use package specific exception classes * refactor: remove DispatchableRegistry * refactor: add logger support to PromptGetter and ResourceReader classes * Update src/Capability/Prompt/PromptGetter.php Co-authored-by: Christopher Hertel <mail@christopher-hertel.de> * refactor: Use FQN for Resource class to avoid cs-fixer misinterpreting it as `resource` * refactor: rename ToolExecutor to ToolCaller and related classes for clarity and consistency * refactor: add missed docblock * refactor: rename ToolExecutor references to ToolCaller * refactor: rename ToolCallerTest property and variable references * cs fix * ignore some phpstan errors --------- Co-authored-by: Christopher Hertel <mail@christopher-hertel.de>
This commit is contained in:
Pavel Buchnev
GitHub
parent
bfc3b82d19
commit
99bf56eef8
1 changed files with 4656 additions and 334 deletions
147
tests/Server/RequestHandler/PingHandlerTest.php
Normal file
147
tests/Server/RequestHandler/PingHandlerTest.php
Normal file
|
|
@ -0,0 +1,147 @@
|
|||
<?php
|
||||
|
||||
/*
|
||||
* This file is part of the official PHP MCP SDK.
|
||||
*
|
||||
* A collaboration between Symfony and the PHP Foundation.
|
||||
*
|
||||
* For the full copyright and license information, please view the LICENSE
|
||||
* file that was distributed with this source code.
|
||||
*/
|
||||
|
||||
namespace Mcp\Tests\Server\RequestHandler;
|
||||
|
||||
use Mcp\Schema\JsonRpc\Request;
|
||||
use Mcp\Schema\JsonRpc\Response;
|
||||
use Mcp\Schema\Request\PingRequest;
|
||||
use Mcp\Schema\Result\EmptyResult;
|
||||
use Mcp\Server\RequestHandler\PingHandler;
|
||||
use PHPUnit\Framework\TestCase;
|
||||
|
||||
class PingHandlerTest extends TestCase
|
||||
{
|
||||
private PingHandler $handler;
|
||||
|
||||
protected function setUp(): void
|
||||
{
|
||||
$this->handler = new PingHandler();
|
||||
}
|
||||
|
||||
public function testSupportsPingRequest(): void
|
||||
{
|
||||
$request = $this->createPingRequest();
|
||||
|
||||
$this->assertTrue($this->handler->supports($request));
|
||||
}
|
||||
|
||||
public function testHandlePingRequest(): void
|
||||
{
|
||||
$request = $this->createPingRequest();
|
||||
|
||||
$response = $this->handler->handle($request);
|
||||
|
||||
$this->assertInstanceOf(Response::class, $response);
|
||||
$this->assertEquals($request->getId(), $response->id);
|
||||
$this->assertInstanceOf(EmptyResult::class, $response->result);
|
||||
}
|
||||
|
||||
public function testHandleMultiplePingRequests(): void
|
||||
{
|
||||
$request1 = $this->createPingRequest();
|
||||
$request2 = $this->createPingRequest();
|
||||
|
||||
$response1 = $this->handler->handle($request1);
|
||||
$response2 = $this->handler->handle($request2);
|
||||
|
||||
$this->assertInstanceOf(Response::class, $response1);
|
||||
$this->assertInstanceOf(Response::class, $response2);
|
||||
$this->assertInstanceOf(EmptyResult::class, $response1->result);
|
||||
$this->assertInstanceOf(EmptyResult::class, $response2->result);
|
||||
$this->assertEquals($request1->getId(), $response1->id);
|
||||
$this->assertEquals($request2->getId(), $response2->id);
|
||||
}
|
||||
|
||||
public function testHandlerHasNoSideEffects(): void
|
||||
{
|
||||
$request = $this->createPingRequest();
|
||||
|
||||
// Handle same request multiple times
|
||||
$response1 = $this->handler->handle($request);
|
||||
$response2 = $this->handler->handle($request);
|
||||
|
||||
// Both responses should be identical
|
||||
$this->assertEquals($response1->id, $response2->id);
|
||||
$this->assertEquals(
|
||||
\get_class($response1->result),
|
||||
\get_class($response2->result),
|
||||
);
|
||||
}
|
||||
|
||||
public function testEmptyResultIsCorrectType(): void
|
||||
{
|
||||
$request = $this->createPingRequest();
|
||||
$response = $this->handler->handle($request);
|
||||
|
||||
$this->assertInstanceOf(EmptyResult::class, $response->result);
|
||||
|
||||
// Verify EmptyResult serializes to empty object
|
||||
$serialized = json_encode($response->result);
|
||||
$this->assertEquals('{}', $serialized);
|
||||
}
|
||||
|
||||
public function testHandlerIsStateless(): void
|
||||
{
|
||||
$handler1 = new PingHandler();
|
||||
$handler2 = new PingHandler();
|
||||
|
||||
$request = $this->createPingRequest();
|
||||
|
||||
$response1 = $handler1->handle($request);
|
||||
$response2 = $handler2->handle($request);
|
||||
|
||||
// Both handlers should produce equivalent results
|
||||
$this->assertEquals($response1->id, $response2->id);
|
||||
$this->assertEquals(
|
||||
\get_class($response1->result),
|
||||
\get_class($response2->result),
|
||||
);
|
||||
}
|
||||
|
||||
public function testSupportsMethodIsConsistent(): void
|
||||
{
|
||||
$request = $this->createPingRequest();
|
||||
|
||||
// Multiple calls to supports should return same result
|
||||
$this->assertTrue($this->handler->supports($request));
|
||||
$this->assertTrue($this->handler->supports($request));
|
||||
$this->assertTrue($this->handler->supports($request));
|
||||
}
|
||||
|
||||
public function testHandlerCanBeReused(): void
|
||||
{
|
||||
$requests = [];
|
||||
$responses = [];
|
||||
|
||||
// Create multiple ping requests
|
||||
for ($i = 0; $i < 5; ++$i) {
|
||||
$requests[$i] = $this->createPingRequest();
|
||||
$responses[$i] = $this->handler->handle($requests[$i]);
|
||||
}
|
||||
|
||||
// All responses should be valid
|
||||
foreach ($responses as $i => $response) {
|
||||
$this->assertInstanceOf(Response::class, $response);
|
||||
$this->assertEquals($requests[$i]->getId(), $response->id);
|
||||
$this->assertInstanceOf(EmptyResult::class, $response->result);
|
||||
}
|
||||
}
|
||||
|
||||
private function createPingRequest(): Request
|
||||
{
|
||||
return PingRequest::fromArray([
|
||||
'jsonrpc' => '2.0',
|
||||
'method' => PingRequest::getMethod(),
|
||||
'id' => 'test-request-'.uniqid(),
|
||||
]);
|
||||
}
|
||||
}
|
||||
Loading…
Reference in a new issue