modelcontextprotocol/php-sdk
Watch
1
0
Fork
You've already forked php-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Server] Make resource subscribe/unsubscribe errors protocol-version-aware (SEP-2164) (#474)

Browse source 
* [Server] Make resource subscribe/unsubscribe errors protocol-version-aware (SEP-2164)

ReadResourceHandler already picked -32602 vs -32002 based on the
negotiated revision; ResourceSubscribeHandler and
ResourceUnsubscribeHandler still hard-coded the retired -32002 for
every client. Bring them in line.

* Remove unnecessary comments

Co-authored-by: Christopher Hertel <mail@christopher-hertel.de>
This commit is contained in:
Christopher Hertel 2026-08-24 01:17:09 +02:00 • committed by GitHub
commit d09fe3019e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 262 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/Server/Handler/Request/ResourceUnsubscribeHandler.php
View file

@ -18,6 +18,7 @@ use Mcp\Schema\JsonRpc\Request;
use Mcp\Schema\JsonRpc\Response;
use Mcp\Schema\Request\ResourceUnsubscribeRequest;
use Mcp\Schema\Result\EmptyResult;
use Mcp\Server\RequestContext;
use Mcp\Server\Resource\SubscriptionManagerInterface;
use Mcp\Server\Session\SessionInterface;
use Psr\Log\LoggerInterface;
@ -57,7 +58,9 @@ final class ResourceUnsubscribeHandler implements RequestHandlerInterface
} catch (ResourceNotFoundException $e) {
$this->logger->error('Resource not found', ['uri' => $uri, 'exception' => $e]);
return Error::forResourceNotFound($e->getMessage(), $request->getId());
return (new RequestContext($session, $request))->getProtocolVersion()->usesInvalidParamsForResourceNotFound()
? Error::forInvalidParams($e->getMessage(), $request->getId(), ['uri' => $uri])
: Error::forResourceNotFound($e->getMessage(), $request->getId());
}
$this->logger->debug('Unsubscribing from resource', ['uri' => $uri]);