php-sdk/tests/Unit/Schema/Elicitation/EnumSchemaDefinitionTest.php
Christopher Hertel cf2c4d4ead
[Schema] Stop rejecting elicitation schemas the specification allows (#437)
* [Schema] Stop rejecting elicitation schemas the specification allows

The specification makes `title` optional on every elicitation schema
definition. AbstractSchemaDefinition required it, so a client reading a
conformant server's elicitation/create refused the request - and a server
building one could not omit it either.

`title` is now nullable on all seven definitions, omitted from the
serialized form when absent, and rejected only when present and not a
string.

* Fix stale title docblocks; allow omitting title where safe

* Give Number's title param a default too

* Apply suggestions from code review

Co-authored-by: Christopher Hertel <mail@christopher-hertel.de>
2026-08-18 19:49:15 +02:00

175 lines
5.8 KiB
PHP

<?php
/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Mcp\Tests\Unit\Schema\Elicitation;
use Mcp\Exception\InvalidArgumentException;
use Mcp\Schema\Elicitation\EnumSchemaDefinition;
use PHPUnit\Framework\TestCase;
final class EnumSchemaDefinitionTest extends TestCase
{
public function testConstructorWithMinimalParams(): void
{
$schema = new EnumSchemaDefinition('Rating', ['1', '2', '3', '4', '5']);
$this->assertSame('Rating', $schema->title);
$this->assertSame(['1', '2', '3', '4', '5'], $schema->enum);
$this->assertNull($schema->description);
$this->assertNull($schema->default);
$this->assertNull($schema->enumNames);
}
public function testConstructorWithAllParams(): void
{
$schema = new EnumSchemaDefinition(
title: 'Satisfaction',
enum: ['poor', 'fair', 'good', 'excellent'],
description: 'Rate your satisfaction',
default: 'good',
enumNames: ['Poor', 'Fair', 'Good', 'Excellent'],
);
$this->assertSame('Satisfaction', $schema->title);
$this->assertSame(['poor', 'fair', 'good', 'excellent'], $schema->enum);
$this->assertSame('Rate your satisfaction', $schema->description);
$this->assertSame('good', $schema->default);
$this->assertSame(['Poor', 'Fair', 'Good', 'Excellent'], $schema->enumNames);
}
public function testConstructorWithEmptyEnum(): void
{
$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage('enum array must not be empty');
new EnumSchemaDefinition('Test', []);
}
public function testConstructorWithNonStringEnumValue(): void
{
$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage('All enum values must be strings');
/* @phpstan-ignore argument.type */
new EnumSchemaDefinition('Test', ['a', 1, 'b']);
}
public function testConstructorWithEnumNamesMismatch(): void
{
$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage('enumNames length must match enum length');
new EnumSchemaDefinition(
title: 'Test',
enum: ['a', 'b', 'c'],
enumNames: ['A', 'B'],
);
}
public function testConstructorWithInvalidDefault(): void
{
$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage('Default value "invalid" is not in the enum array');
new EnumSchemaDefinition(
title: 'Test',
enum: ['a', 'b', 'c'],
default: 'invalid',
);
}
public function testFromArrayWithMinimalParams(): void
{
$schema = EnumSchemaDefinition::fromArray([
'title' => 'Rating',
'enum' => ['1', '2', '3'],
]);
$this->assertSame('Rating', $schema->title);
$this->assertSame(['1', '2', '3'], $schema->enum);
}
public function testFromArrayWithAllParams(): void
{
$schema = EnumSchemaDefinition::fromArray([
'title' => 'Satisfaction',
'enum' => ['poor', 'fair', 'good'],
'description' => 'Rate your satisfaction',
'default' => 'fair',
'enumNames' => ['Poor', 'Fair', 'Good'],
]);
$this->assertSame('Satisfaction', $schema->title);
$this->assertSame(['poor', 'fair', 'good'], $schema->enum);
$this->assertSame('Rate your satisfaction', $schema->description);
$this->assertSame('fair', $schema->default);
$this->assertSame(['Poor', 'Fair', 'Good'], $schema->enumNames);
}
public function testFromArrayWithoutTitleIsAccepted(): void
{
// `title` is optional in the specification, so a server that omits it
// must still be readable.
$schema = EnumSchemaDefinition::fromArray(['enum' => ['a', 'b']]);
$this->assertNull($schema->title);
$this->assertArrayNotHasKey('title', $schema->jsonSerialize());
}
public function testFromArrayRejectsNonStringTitle(): void
{
$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage('Invalid "title" for enum schema definition.');
/* @phpstan-ignore argument.type */
EnumSchemaDefinition::fromArray(['title' => 42]);
}
public function testFromArrayWithMissingEnum(): void
{
$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage('Missing or invalid "enum"');
/* @phpstan-ignore argument.type */
EnumSchemaDefinition::fromArray(['title' => 'Test']);
}
public function testJsonSerializeWithMinimalParams(): void
{
$schema = new EnumSchemaDefinition('Rating', ['1', '2', '3']);
$this->assertSame([
'type' => 'string',
'title' => 'Rating',
'enum' => ['1', '2', '3'],
], $schema->jsonSerialize());
}
public function testJsonSerializeWithAllParams(): void
{
$schema = new EnumSchemaDefinition(
title: 'Satisfaction',
enum: ['poor', 'fair', 'good'],
description: 'Rate your satisfaction',
default: 'fair',
enumNames: ['Poor', 'Fair', 'Good'],
);
$this->assertSame([
'type' => 'string',
'title' => 'Satisfaction',
'enum' => ['poor', 'fair', 'good'],
'description' => 'Rate your satisfaction',
'default' => 'fair',
'enumNames' => ['Poor', 'Fair', 'Good'],
], $schema->jsonSerialize());
}
}