php-sdk/tests/Unit/Server/Handler/Request/ListToolsHandlerTest.php
Mateu Aguiló Bosch fb2c8c2ee4
[Schema][Server] Add top-level title to Tool (#288)
* feat(schema): add top-level title to Tool

Mirror PR #278's Prompt change for Tool:

- Add optional ?string $title to Mcp\Schema\Tool between $name
  and $inputSchema. fromArray() now reads $data['title'];
  jsonSerialize() emits 'title' right after 'name'. The
  @phpstan-type ToolData gains title?: string.
- Add ?string $title to the #[McpTool] attribute between $name
  and $description.
- Note ToolAnnotations::$title as deprecated-for-display in
  favor of Tool::$title per MCP spec 2025-06-18 (PHPDoc only,
  field retained for BC).

Phase 1 of plan 01--tool-title-spec-compliance. Later phases
update Discoverer, Builder::addTool(), ArrayLoader, and the
conformance fixture to match the new signature.

* feat(server): thread title through discovery

- Discoverer::processMethod() now propagates McpTool::$title
  into every discovered Tool via named arguments.
- Builder::addTool() accepts ?string $title between $name and
  $description. [BC Break] positional callers passing the old
  $description as 3rd positional argument must switch to named
  arguments, matching the precedent set for addPrompt() in
  0.5.0.
- tests/Conformance/server.php migrated to named-argument form
  for every addTool() call.

Phase 2 of plan 01--tool-title-spec-compliance.

* feat(loader): forward title in ArrayLoader

ArrayLoader now reads 'title' from each tool config entry and
passes it into the Tool constructor, completing the wiring
from Builder::addTool() through array-driven registration.

The $tools @param array-shape typedef gains title: ?string
between name and description.

Phase 3 of plan 01--tool-title-spec-compliance.

* test(schema): cover Tool.title end-to-end

- New tests/Unit/Schema/ToolTest.php: constructor round-trip,
  jsonSerialize key-order when title set vs null, fromArray
  tolerance.
- New tests/Unit/Capability/Discovery/DiscovererToolTitleTest
  plus a TitleFixture class verifying McpTool(title: ...)
  propagates through discovery into the registered Tool.
- New tests/Unit/Capability/Registry/Loader/ArrayLoader...
  test verifying array-driven title propagation.
- Extend McpToolTest for title named-arg and default-null.
- Extend BuilderTest with addTool(title: 't') propagation.
- Update tests/Unit/.../RegistryTest, CallToolHandlerTest,
  ListToolsHandlerTest and examples/.../server.php
  new Tool(...) call sites to pass title (named args) so
  they match the new constructor signature.
- CHANGELOG 0.6.0 section: feature bullet + [BC Break]
  note for addTool() signature, mirroring 0.5.0 Prompt
  entries.
- docs/server-builder.md: addTool() row and prose now
  list title? between name and description.

Phase 4 of plan 01--tool-title-spec-compliance. All 730
phpunit tests pass; remaining phpstan warnings are
pre-existing and unrelated to Tool.title.

* refactor(schema): make Tool.title non-BC-breaking

Move `title` to the end of the Tool, Builder::addTool, and McpTool
attribute constructors with a default of null. This preserves
positional-argument compatibility and removes the need for
`title: null` boilerplate at call sites. JSON serialization order
(name, title, inputSchema, ...) is unchanged.

Also tighten the new tests: parameterize ToolTest with data
providers, fold the Discoverer title fixture into the existing
DiscoverableToolHandler, and drop the reflection-heavy Builder
test that overlapped with ArrayLoaderToolTitleTest.

* fix: move title after name

---------

Co-authored-by: DDEV User <nobody@example.com>
2026-04-26 15:37:40 +02:00

320 lines
11 KiB
PHP

<?php
/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Mcp\Tests\Unit\Server\Handler\Request;
use Mcp\Capability\Registry;
use Mcp\Exception\InvalidCursorException;
use Mcp\Schema\Request\ListToolsRequest;
use Mcp\Schema\Result\ListToolsResult;
use Mcp\Schema\Tool;
use Mcp\Server\Handler\Request\ListToolsHandler;
use Mcp\Server\Session\InMemorySessionStore;
use Mcp\Server\Session\Session;
use Mcp\Server\Session\SessionInterface;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;
class ListToolsHandlerTest extends TestCase
{
private Registry $registry;
private ListToolsHandler $handler;
private SessionInterface $session;
protected function setUp(): void
{
$this->registry = new Registry();
$this->handler = new ListToolsHandler($this->registry, pageSize: 3); // Use small page size for testing
$this->session = new Session(new InMemorySessionStore());
}
#[TestDox('Returns first page when no cursor provided')]
public function testReturnsFirstPageWhenNoCursorProvided(): void
{
// Arrange
$this->addToolsToRegistry(5);
$request = $this->createListToolsRequest();
// Act
$response = $this->handler->handle($request, $this->session);
// Assert
/** @var ListToolsResult $result */
$result = $response->result;
$this->assertInstanceOf(ListToolsResult::class, $result);
$this->assertCount(3, $result->tools);
$this->assertNotNull($result->nextCursor);
$this->assertEquals('tool_0', $result->tools[0]->name);
$this->assertEquals('tool_1', $result->tools[1]->name);
$this->assertEquals('tool_2', $result->tools[2]->name);
}
#[TestDox('Returns paginated tools with cursor')]
public function testReturnsPaginatedToolsWithCursor(): void
{
// Arrange
$this->addToolsToRegistry(10);
$request = $this->createListToolsRequest(cursor: null);
// Act
$response = $this->handler->handle($request, $this->session);
// Assert
/** @var ListToolsResult $result */
$result = $response->result;
$this->assertInstanceOf(ListToolsResult::class, $result);
$this->assertCount(3, $result->tools);
$this->assertNotNull($result->nextCursor);
$this->assertEquals('tool_0', $result->tools[0]->name);
$this->assertEquals('tool_1', $result->tools[1]->name);
$this->assertEquals('tool_2', $result->tools[2]->name);
}
#[TestDox('Returns second page with cursor')]
public function testReturnsSecondPageWithCursor(): void
{
// Arrange
$this->addToolsToRegistry(10);
$firstPageRequest = $this->createListToolsRequest();
$firstPageResponse = $this->handler->handle($firstPageRequest, $this->session);
/** @var ListToolsResult $firstPageResult */
$firstPageResult = $firstPageResponse->result;
$secondPageRequest = $this->createListToolsRequest(cursor: $firstPageResult->nextCursor);
// Act
$response = $this->handler->handle($secondPageRequest, $this->session);
// Assert
/** @var ListToolsResult $result */
$result = $response->result;
$this->assertInstanceOf(ListToolsResult::class, $result);
$this->assertCount(3, $result->tools);
$this->assertNotNull($result->nextCursor);
$this->assertEquals('tool_3', $result->tools[0]->name);
$this->assertEquals('tool_4', $result->tools[1]->name);
$this->assertEquals('tool_5', $result->tools[2]->name);
}
#[TestDox('Returns last page with null cursor')]
public function testReturnsLastPageWithNullCursor(): void
{
// Arrange
$this->addToolsToRegistry(5);
$firstPageRequest = $this->createListToolsRequest();
$firstPageResponse = $this->handler->handle($firstPageRequest, $this->session);
/** @var ListToolsResult $firstPageResult */
$firstPageResult = $firstPageResponse->result;
$secondPageRequest = $this->createListToolsRequest(cursor: $firstPageResult->nextCursor);
// Act
$response = $this->handler->handle($secondPageRequest, $this->session);
// Assert
/** @var ListToolsResult $result */
$result = $response->result;
$this->assertInstanceOf(ListToolsResult::class, $result);
$this->assertCount(2, $result->tools);
$this->assertNull($result->nextCursor);
$this->assertEquals('tool_3', $result->tools[0]->name);
$this->assertEquals('tool_4', $result->tools[1]->name);
}
#[TestDox('Returns all tools when count is less than page size')]
public function testReturnsAllToolsWhenCountIsLessThanPageSize(): void
{
// Arrange
$this->addToolsToRegistry(2); // Less than page size 3
$request = $this->createListToolsRequest();
// Act
$response = $this->handler->handle($request, $this->session);
// Assert
/** @var ListToolsResult $result */
$result = $response->result;
$this->assertInstanceOf(ListToolsResult::class, $result);
$this->assertCount(2, $result->tools);
$this->assertNull($result->nextCursor);
$this->assertEquals('tool_0', $result->tools[0]->name);
$this->assertEquals('tool_1', $result->tools[1]->name);
}
#[TestDox('Handles empty registry')]
public function testHandlesEmptyRegistry(): void
{
// Arrange
$request = $this->createListToolsRequest();
// Act
$response = $this->handler->handle($request, $this->session);
// Assert
/** @var ListToolsResult $result */
$result = $response->result;
$this->assertInstanceOf(ListToolsResult::class, $result);
$this->assertCount(0, $result->tools);
$this->assertNull($result->nextCursor);
}
#[TestDox('Throws exception for invalid cursor')]
public function testThrowsExceptionForInvalidCursor(): void
{
// Arrange
$this->addToolsToRegistry(5);
$request = $this->createListToolsRequest(cursor: 'invalid-cursor');
// Assert
$this->expectException(InvalidCursorException::class);
// Act
$this->handler->handle($request, $this->session);
}
#[TestDox('Throws exception for cursor beyond bounds')]
public function testThrowsExceptionForCursorBeyondBounds(): void
{
// Arrange
$this->addToolsToRegistry(5);
$outOfBoundsCursor = base64_encode('100');
$request = $this->createListToolsRequest(cursor: $outOfBoundsCursor);
// Assert
$this->expectException(InvalidCursorException::class);
// Act
$this->handler->handle($request, $this->session);
}
#[TestDox('Handles cursor at exact boundary')]
public function testHandlesCursorAtExactBoundary(): void
{
// Arrange
$this->addToolsToRegistry(6);
$exactBoundaryCursor = base64_encode('6');
$request = $this->createListToolsRequest(cursor: $exactBoundaryCursor);
// Act
$response = $this->handler->handle($request, $this->session);
// Assert
/** @var ListToolsResult $result */
$result = $response->result;
$this->assertInstanceOf(ListToolsResult::class, $result);
$this->assertCount(0, $result->tools);
$this->assertNull($result->nextCursor);
}
#[TestDox('Maintains stable cursors across calls')]
public function testMaintainsStableCursorsAcrossCalls(): void
{
// Arrange
$this->addToolsToRegistry(10);
// Act
$request = $this->createListToolsRequest();
$response1 = $this->handler->handle($request, $this->session);
$response2 = $this->handler->handle($request, $this->session);
// Assert
/** @var ListToolsResult $result1 */
$result1 = $response1->result;
/** @var ListToolsResult $result2 */
$result2 = $response2->result;
$this->assertEquals($result1->nextCursor, $result2->nextCursor);
$this->assertEquals($result1->tools, $result2->tools);
}
#[TestDox('Uses custom page size when provided')]
public function testUsesCustomPageSizeWhenProvided(): void
{
// Arrange
$customPageSize = 5;
$customHandler = new ListToolsHandler($this->registry, pageSize: $customPageSize);
$this->addToolsToRegistry(10);
$request = $this->createListToolsRequest();
// Act
$response = $customHandler->handle($request, $this->session);
// Assert
/** @var ListToolsResult $result */
$result = $response->result;
$this->assertInstanceOf(ListToolsResult::class, $result);
$this->assertCount($customPageSize, $result->tools);
$this->assertNotNull($result->nextCursor);
}
#[TestDox('Different page sizes produce different pagination results')]
public function testDifferentPageSizesProduceDifferentPaginationResults(): void
{
// Arrange
$this->addToolsToRegistry(10);
$smallPageHandler = new ListToolsHandler($this->registry, pageSize: 2);
$largePageHandler = new ListToolsHandler($this->registry, pageSize: 7);
$request = $this->createListToolsRequest();
// Act
$smallPageResponse = $smallPageHandler->handle($request, $this->session);
$largePageResponse = $largePageHandler->handle($request, $this->session);
// Assert
/** @var ListToolsResult $smallResult */
$smallResult = $smallPageResponse->result;
/** @var ListToolsResult $largeResult */
$largeResult = $largePageResponse->result;
$this->assertCount(2, $smallResult->tools);
$this->assertCount(7, $largeResult->tools);
$this->assertNotNull($smallResult->nextCursor);
$this->assertNotNull($largeResult->nextCursor);
}
private function addToolsToRegistry(int $count): void
{
for ($i = 0; $i < $count; ++$i) {
$tool = new Tool(
name: "tool_$i",
title: null,
inputSchema: [
'type' => 'object',
'properties' => [],
'required' => [],
],
description: "Test tool $i",
annotations: null
);
$this->registry->registerTool($tool, static fn () => null);
}
}
private function createListToolsRequest(?string $cursor = null): ListToolsRequest
{
$data = [
'jsonrpc' => '2.0',
'id' => 'test-request-id',
'method' => 'tools/list',
];
if (null !== $cursor) {
$data['params'] = ['cursor' => $cursor];
}
return ListToolsRequest::fromArray($data);
}
}