modelcontextprotocol/python-sdk
Watch
1
0
Fork
You've already forked python-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove the unused timeout parameter from OAuthClientProvider (#3165)

Browse source
This commit is contained in:
Max 2026-07-26 00:22:15 +01:00 • committed by GitHub
commit 47bfa85e83
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 24 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

1
tests/client/test_auth.py
View file

@ -192,7 +192,6 @@ class TestOAuthContext:
assert oauth_provider.context.server_url == "https://api.example.com/v1/mcp"
assert oauth_provider.context.client_metadata == client_metadata
assert oauth_provider.context.storage == mock_storage
assert oauth_provider.context.timeout == 300.0
assert oauth_provider.context is not None
def test_context_url_parsing(self, oauth_provider: OAuthClientProvider):

6
tests/docs_src/test_oauth_clients.py
View file

@ -80,11 +80,11 @@ async def test_client_credentials_provider_builds_its_own_metadata() -> None:
assert metadata.scope == "user"
async def test_the_three_remaining_keyword_arguments_have_defaults() -> None:
"""The page names `timeout`, `client_metadata_url` and `validate_resource_url` as the remainder."""
async def test_the_two_remaining_keyword_arguments_have_defaults() -> None:
"""The page names `client_metadata_url` and `validate_resource_url` as the remainder."""
parameters = inspect.signature(OAuthClientProvider.__init__).parameters
supplied = ["server_url", "client_metadata", "storage", "redirect_handler", "callback_handler"]
remainder = ["timeout", "client_metadata_url", "validate_resource_url"]
remainder = ["client_metadata_url", "validate_resource_url"]
assert list(parameters) == ["self", *supplied, *remainder]
assert all(parameters[name].default is not inspect.Parameter.empty for name in remainder)