modelcontextprotocol/python-sdk
Watch
1
0
Fork
You've already forked python-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tests: remove lax-no-cover pragmas by moving assertions before cancellation (#2206)

Browse source
This commit is contained in:
Max Isbey 2026-03-04 16:11:34 +00:00 • committed by GitHub
commit 528abfab86
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 36 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

19
tests/shared/test_sse.py
View file

@ -203,19 +203,15 @@ async def test_sse_client_basic_connection(server: None, server_url: str) -> Non
@pytest.mark.anyio
async def test_sse_client_on_session_created(server: None, server_url: str) -> None:
captured_session_id: str | None = None
captured: list[str] = []
def on_session_created(session_id: str) -> None:
nonlocal captured_session_id
captured_session_id = session_id
async with sse_client(server_url + "/sse", on_session_created=on_session_created) as streams:
async with sse_client(server_url + "/sse", on_session_created=captured.append) as streams:
async with ClientSession(*streams) as session:
result = await session.initialize()
assert isinstance(result, InitializeResult)
assert captured_session_id is not None # pragma: lax no cover
assert len(captured_session_id) > 0 # pragma: lax no cover
# Callback fires when the endpoint event arrives, before sse_client yields.
assert len(captured) == 1
assert len(captured[0]) > 0
@pytest.mark.parametrize(
@ -248,8 +244,9 @@ async def test_sse_client_on_session_created_not_called_when_no_session_id(
async with ClientSession(*streams) as session:
result = await session.initialize()
assert isinstance(result, InitializeResult)
callback_mock.assert_not_called() # pragma: lax no cover
# Callback would have fired by now (endpoint event arrives before
# sse_client yields); if it hasn't, it won't.
callback_mock.assert_not_called()
@pytest.fixture