Return HTTP 403 for invalid Origin headers (#1353)
This commit is contained in:
parent
ca34666663
commit
7e93a9fc19
3 changed files with 3 additions and 3 deletions
|
|
@ -122,6 +122,6 @@ class TransportSecurityMiddleware:
|
||||||
# Validate Origin header
|
# Validate Origin header
|
||||||
origin = request.headers.get("origin")
|
origin = request.headers.get("origin")
|
||||||
if not self._validate_origin(origin):
|
if not self._validate_origin(origin):
|
||||||
return Response("Invalid Origin header", status_code=400)
|
return Response("Invalid Origin header", status_code=403)
|
||||||
|
|
||||||
return None
|
return None
|
||||||
|
|
|
||||||
|
|
@ -127,7 +127,7 @@ async def test_sse_security_invalid_origin_header(server_port: int):
|
||||||
|
|
||||||
async with httpx.AsyncClient() as client:
|
async with httpx.AsyncClient() as client:
|
||||||
response = await client.get(f"http://127.0.0.1:{server_port}/sse", headers=headers)
|
response = await client.get(f"http://127.0.0.1:{server_port}/sse", headers=headers)
|
||||||
assert response.status_code == 400
|
assert response.status_code == 403
|
||||||
assert response.text == "Invalid Origin header"
|
assert response.text == "Invalid Origin header"
|
||||||
|
|
||||||
finally:
|
finally:
|
||||||
|
|
|
||||||
|
|
@ -155,7 +155,7 @@ async def test_streamable_http_security_invalid_origin_header(server_port: int):
|
||||||
json={"jsonrpc": "2.0", "method": "initialize", "id": 1, "params": {}},
|
json={"jsonrpc": "2.0", "method": "initialize", "id": 1, "params": {}},
|
||||||
headers=headers,
|
headers=headers,
|
||||||
)
|
)
|
||||||
assert response.status_code == 400
|
assert response.status_code == 403
|
||||||
assert response.text == "Invalid Origin header"
|
assert response.text == "Invalid Origin header"
|
||||||
|
|
||||||
finally:
|
finally:
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue