modelcontextprotocol/python-sdk
Watch
1
0
Fork
You've already forked python-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ci: add strict-no-cover to detect unnecessary coverage pragmas (#1897)

Browse source
This commit is contained in:
Max Isbey 2026-01-23 20:00:20 +00:00 • committed by GitHub
commit a7ddfdae07
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 355 additions and 358 deletions
Download patch file Download diff file Expand all files Collapse all files

26
src/mcp/shared/session.py
View file

@ -150,7 +150,7 @@ class RequestResponder(Generic[ReceiveRequestT, SendResultT]):
return not self._completed and not self.cancelled
@property
def cancelled(self) -> bool: # pragma: no cover
def cancelled(self) -> bool:
return self._cancel_scope.cancel_called
@ -250,11 +250,11 @@ class BaseSession(
# Set up progress token if progress callback is provided
request_data = request.model_dump(by_alias=True, mode="json", exclude_none=True)
if progress_callback is not None: # pragma: no cover
if progress_callback is not None:
# Use request_id as progress token
if "params" not in request_data:
if "params" not in request_data: # pragma: lax no cover
request_data["params"] = {}
if "_meta" not in request_data["params"]: # pragma: no branch
if "_meta" not in request_data["params"]: # pragma: lax no cover
request_data["params"]["_meta"] = {}
request_data["params"]["_meta"]["progressToken"] = request_id
# Store the callback for this request
@ -304,7 +304,7 @@ class BaseSession(
jsonrpc="2.0",
**notification.model_dump(by_alias=True, mode="json", exclude_none=True),
)
session_message = SessionMessage( # pragma: no cover
session_message = SessionMessage(
message=jsonrpc_notification,
metadata=ServerMessageMetadata(related_request_id=related_request_id) if related_request_id else None,
)
@ -384,7 +384,7 @@ class BaseSession(
await self._in_flight[cancelled_id].cancel()
else:
# Handle progress notifications callback
if isinstance(notification, ProgressNotification): # pragma: no cover
if isinstance(notification, ProgressNotification):
progress_token = notification.params.progress_token
# If there is a progress callback for this token,
# call it with the progress information
@ -400,9 +400,9 @@ class BaseSession(
logging.exception("Progress callback raised an exception")
await self._received_notification(notification)
await self._handle_incoming(notification)
except Exception: # pragma: no cover
except Exception:
# For other validation errors, log and continue
logging.warning(
logging.warning( # pragma: no cover
f"Failed to validate notification:. Message was: {message.message}",
exc_info=True,
)
@ -413,11 +413,11 @@ class BaseSession(
# This is expected when the client disconnects abruptly.
# Without this handler, the exception would propagate up and
# crash the server's task group.
logging.debug("Read stream closed by client") # pragma: no cover
except Exception as e: # pragma: no cover
logging.debug("Read stream closed by client")
except Exception as e:
# Other exceptions are not expected and should be logged. We purposefully
# catch all exceptions here to avoid crashing the server.
logging.exception(f"Unhandled exception in receive loop: {e}")
logging.exception(f"Unhandled exception in receive loop: {e}") # pragma: no cover
finally:
# after the read stream is closed, we need to send errors
# to any pending requests
@ -482,9 +482,9 @@ class BaseSession(
# Fall back to normal response streams
stream = self._response_streams.pop(response_id, None)
if stream: # pragma: no cover
if stream:
await stream.send(message.message)
else: # pragma: no cover
else:
await self._handle_incoming(RuntimeError(f"Received response with an unknown request ID: {message}"))
async def _received_request(self, responder: RequestResponder[ReceiveRequestT, SendResultT]) -> None: