ci: add strict-no-cover to detect unnecessary coverage pragmas (#1897)

This commit is contained in:
Max Isbey 2026-01-23 20:00:20 +00:00 • committed by GitHub
commit a7ddfdae07
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -310,8 +310,7 @@ async def test_task_metadata_in_call_tool_request() -> None:
async with anyio.create_task_group() as tg:
async def handle_messages():
# TODO(Marcelo): Drop the pragma once https://github.com/coveragepy/coveragepy/issues/1987 is fixed.
async for message in server_session.incoming_messages: # pragma: no cover
async for message in server_session.incoming_messages: # pragma: no branch
await server._handle_message(message, server_session, {}, False)
tg.start_soon(handle_messages)
@ -388,9 +387,9 @@ async def test_task_metadata_is_task_property() -> None:
),
) as server_session:
async with anyio.create_task_group() as tg:
# TODO(Marcelo): Drop the pragma once https://github.com/coveragepy/coveragepy/issues/1987 is fixed.
async def handle_messages(): # pragma: no cover
async for message in server_session.incoming_messages:
async def handle_messages():
async for message in server_session.incoming_messages: # pragma: no branch
await server._handle_message(message, server_session, {}, False)
tg.start_soon(handle_messages)
@ -573,7 +572,7 @@ async def test_build_elicit_form_request() -> None:
assert (
request_with_task.params["_meta"]["io.modelcontextprotocol/related-task"]["taskId"] == "test-task-123"
)
finally: # pragma: no cover
finally:
await server_to_client_send.aclose()
await server_to_client_receive.aclose()
await client_to_server_send.aclose()
@ -619,7 +618,7 @@ async def test_build_elicit_url_request() -> None:
assert (
request_with_task.params["_meta"]["io.modelcontextprotocol/related-task"]["taskId"] == "test-task-789"
)
finally: # pragma: no cover
finally:
await server_to_client_send.aclose()
await server_to_client_receive.aclose()
await client_to_server_send.aclose()
@ -670,7 +669,7 @@ async def test_build_create_message_request() -> None:
request_with_task.params["_meta"]["io.modelcontextprotocol/related-task"]["taskId"]
== "sampling-task-456"
)
finally: # pragma: no cover
finally:
await server_to_client_send.aclose()
await server_to_client_receive.aclose()
await client_to_server_send.aclose()
@ -707,7 +706,7 @@ async def test_send_message() -> None:
received = await server_to_client_receive.receive()
assert isinstance(received.message, JSONRPCNotification)
assert received.message.method == "test/notification"
finally: # pragma: no cover
finally: # pragma: lax no cover
await server_to_client_send.aclose()
await server_to_client_receive.aclose()
await client_to_server_send.aclose()
@ -761,7 +760,7 @@ async def test_response_routing_success() -> None:
assert len(routed_responses) == 1
assert routed_responses[0]["id"] == "test-req-1"
assert routed_responses[0]["response"]["status"] == "ok"
finally: # pragma: no cover
finally: # pragma: lax no cover
await server_to_client_send.aclose()
await server_to_client_receive.aclose()
await client_to_server_send.aclose()
@ -816,7 +815,7 @@ async def test_response_routing_error() -> None:
assert len(routed_errors) == 1
assert routed_errors[0]["id"] == "test-req-2"
assert routed_errors[0]["error"].message == "Test error"
finally: # pragma: no cover
finally: # pragma: lax no cover
await server_to_client_send.aclose()
await server_to_client_receive.aclose()
await client_to_server_send.aclose()
@ -874,7 +873,7 @@ async def test_response_routing_skips_non_matching_routers() -> None:
# Verify both routers were called (first returned False, second returned True)
assert router_calls == ["non_matching_response", "matching_response"]
finally: # pragma: no cover
finally: # pragma: lax no cover
await server_to_client_send.aclose()
await server_to_client_receive.aclose()
await client_to_server_send.aclose()
@ -933,7 +932,7 @@ async def test_error_routing_skips_non_matching_routers() -> None:
# Verify both routers were called (first returned False, second returned True)
assert router_calls == ["non_matching_error", "matching_error"]
finally: # pragma: no cover
finally: # pragma: lax no cover
await server_to_client_send.aclose()
await server_to_client_receive.aclose()
await client_to_server_send.aclose()