modelcontextprotocol/python-sdk
Watch
1
0
Fork
You've already forked python-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix hanging on streams when stdio_client exiting (#559)

Browse source
This commit is contained in:
Lion Yang 2025-05-14 01:36:33 +08:00 • committed by GitHub
commit c5782129bc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/mcp/client/stdio/__init__.py
View file

@ -181,6 +181,8 @@ async def stdio_client(server: StdioServerParameters, errlog: TextIO = sys.stder
await terminate_windows_process(process) await terminate_windows_process(process)
else: else:
process.terminate() process.terminate()
await read_stream.aclose()
await write_stream.aclose()
def _get_executable_command(command: str) -> str: def _get_executable_command(command: str) -> str:

7
tests/client/test_stdio.py
View file

@ -9,6 +9,13 @@ from mcp.types import JSONRPCMessage, JSONRPCRequest, JSONRPCResponse
tee: str = shutil.which("tee") # type: ignore tee: str = shutil.which("tee") # type: ignore
@pytest.mark.anyio
@pytest.mark.skipif(tee is None, reason="could not find tee command")
async def test_stdio_context_manager_exiting():
async with stdio_client(StdioServerParameters(command=tee)) as (_, _):
pass
@pytest.mark.anyio @pytest.mark.anyio
@pytest.mark.skipif(tee is None, reason="could not find tee command") @pytest.mark.skipif(tee is None, reason="could not find tee command")
async def test_stdio_client(): async def test_stdio_client():