Make mcpb package version optional and fix schema validation (#686)
<!-- Provide a brief summary of your changes --> ## Motivation and Context <!-- Why is this change needed? What problem does it solve? --> The following PR: * Makes mcpb package version property optional * Bumps the schema and reflects that in the code * Makes sure the publisher tests are being covered by doing `make check` ## How Has This Been Tested? <!-- Have you tested this in a real application? Which scenarios were tested? --> ## Breaking Changes <!-- Will users need to update their code or configurations? --> ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [ ] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [ ] My code follows the repository's style guidelines - [ ] New and existing tests pass locally - [ ] I have added appropriate error handling - [ ] I have added or updated documentation as needed ## Additional context <!-- Add any other context, implementation notes, or design decisions --> --------- Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
This commit is contained in:
parent
f870a4c000
commit
0828bc483c
1 changed files with 131 additions and 81 deletions
|
|
@ -27,14 +27,13 @@ func ValidateMCPB(ctx context.Context, pkg model.Package, _ string) error {
|
|||
return ErrMissingIdentifierForMCPB
|
||||
}
|
||||
|
||||
// Validate that old format fields are not present
|
||||
// MCPB packages use URL in identifier, version is embedded in the URL
|
||||
if pkg.Version != "" {
|
||||
return fmt.Errorf("MCPB packages must not have 'version' field - version should be embedded in the download URL")
|
||||
}
|
||||
// Validate that registryBaseUrl is not present
|
||||
// MCPB packages use full download URLs in identifier
|
||||
if pkg.RegistryBaseURL != "" {
|
||||
return fmt.Errorf("MCPB packages must not have 'registryBaseUrl' field - use the full download URL in 'identifier' instead")
|
||||
}
|
||||
// Note: version field is optional for MCPB packages
|
||||
// It can be included for clarity or omitted if the version is embedded in the download URL
|
||||
|
||||
err := validateMCPBUrl(pkg.Identifier)
|
||||
if err != nil {
|
||||
|
|
|
|||
Loading…
Reference in a new issue