## Summary Fixes #1081. When the version flagged `is_latest` was soft-deleted, no other version was promoted, and because `GetCurrentLatestVersion` didn't filter deleted rows, subsequent publishes with a lower semver never became latest — leaving `/v0/servers/{name}/versions/latest` permanently 404. This PR has two parts: ### 1. Code fix — recalculate `is_latest` on every status change - Recalculate `is_latest` after every status mutation (`UpdateServerStatus`, `UpdateAllVersionsStatus`, and the inline status change in `UpdateServer`), in the same transaction that already holds the per-server advisory lock. - Winner selection reuses the existing `CompareVersions` logic: highest non-deleted version gets the flag; if every version is deleted, the highest deleted version keeps it so admin lookups via `includeDeleted=true` still resolve the server (important for restore flows). - New `SetLatestVersion` DB primitive issues two statements (clear old, set new) — `idx_unique_latest_per_server` is a non-deferrable unique partial index, so a single `UPDATE` that flips two rows trips the constraint. ### 2. One-shot migration — heal servers already affected (no manual SQL needed) `014_heal_is_latest.sql` promotes the highest non-deleted version on every server whose `is_latest` flag is on a deleted row (or absent entirely). Picker parses `major.minor.patch` numerically and falls back to `published_at` for non-semver or as a tiebreaker. Heals `io.github.containers/kubernetes-mcp-server` to `0.0.61` automatically and catches any other servers silently affected by the original bug, without hardcoded version numbers. Picker behavior vs. `CompareVersions`: - Standard `M.m.p` semver: matches exactly, including the backport-after-delete case (e.g. published 1.0.1 then 1.0.0 hotfix after deleting 2.0.0 → picks 1.0.1, not 1.0.0). - Non-semver: falls through to `published_at DESC`. Reasonable. - Prereleases (`1.0.0-alpha` vs `1.0.0`): both parse to `(1,0,0)`, tiebreak by `published_at`. Diverges from `CompareVersions` (which always says `1.0.0 > 1.0.0-alpha`). Edge case requires (a) server hit by this bug AND (b) prereleases at the top of the version list. Acceptable; the publisher can flip it with one `mcp-publisher status` call (which now triggers proper recalc thanks to part 1). ## Verification End-to-end curl repro of the exact scenario from the issue, run against both `main` and this branch: **Before (main):** ``` publish 1.0.0 → 200 publish 0.0.59 → 200 PATCH .../1.0.0/status {deleted} → 200 GET /versions/latest → 404 ← bug publish 0.0.60 → 200 GET /versions/latest → 404 ← bug persists, 0.0.60 has isLatest=False ``` **After (this branch):** ``` publish 1.0.0 → 200 publish 0.0.59 → 200 PATCH .../1.0.0/status {deleted} → 200 GET /versions/latest → 200 (0.0.59, isLatest=true) publish 0.0.60 → 200 GET /versions/latest → 200 (0.0.60, isLatest=true) ``` ## Test plan - [x] Service tests covering: soft-delete latest → next highest active promoted; the exact #1081 repro end-to-end through the service; all-versions-deleted still keeps highest addressable for admin; restore-to-higher-version reclaims latest. - [x] Migration tests covering: kubernetes-mcp-server scenario (heals to highest semver); backport scenario (semver beats most-recent-published); no-is_latest-row defensive case; all-deleted server left untouched; healthy server left untouched; non-semver versions fall back to `published_at`. - [x] Full unit test suite (`./internal/... ./cmd/...`) passes against a real Postgres. - [x] `make lint` (0 issues) and `make validate` pass. - [x] Manual curl repro against a running registry confirms the fix resolves the failure mode and `main` still reproduces it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
c5f50e817b
commit
0cb1f6bf52
1 changed files with 465 additions and 5 deletions
|
|
@ -982,6 +982,160 @@ func TestUpdateServerStatus_NoConflictWhenRestoringWithUniqueURLs(t *testing.T)
|
|||
assert.Equal(t, model.StatusActive, result.Meta.Official.Status)
|
||||
}
|
||||
|
||||
func TestRecalculateLatest_PromotesNextHighestWhenLatestSoftDeleted(t *testing.T) {
|
||||
ctx := context.Background()
|
||||
testDB := database.NewTestDB(t)
|
||||
service := NewRegistryService(testDB, &config.Config{EnableRegistryValidation: false})
|
||||
|
||||
serverName := "com.example/delete-latest-server"
|
||||
|
||||
// Publish 1.0.0, then 0.0.59. 1.0.0 is latest.
|
||||
_, err := service.CreateServer(ctx, &apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL, Name: serverName, Description: "v1", Version: "1.0.0",
|
||||
})
|
||||
require.NoError(t, err)
|
||||
_, err = service.CreateServer(ctx, &apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL, Name: serverName, Description: "v0.0.59", Version: "0.0.59",
|
||||
})
|
||||
require.NoError(t, err)
|
||||
|
||||
// Soft-delete 1.0.0.
|
||||
_, err = service.UpdateServerStatus(ctx, serverName, "1.0.0", &StatusChangeRequest{
|
||||
NewStatus: model.StatusDeleted,
|
||||
})
|
||||
require.NoError(t, err)
|
||||
|
||||
// 0.0.59 should now be latest.
|
||||
latest, err := service.GetServerByName(ctx, serverName, false)
|
||||
require.NoError(t, err)
|
||||
assert.Equal(t, "0.0.59", latest.Server.Version)
|
||||
assert.True(t, latest.Meta.Official.IsLatest)
|
||||
}
|
||||
|
||||
func TestRecalculateLatest_ReproFromIssue1081(t *testing.T) {
|
||||
ctx := context.Background()
|
||||
testDB := database.NewTestDB(t)
|
||||
service := NewRegistryService(testDB, &config.Config{EnableRegistryValidation: false})
|
||||
|
||||
serverName := "com.example/issue-1081-repro"
|
||||
|
||||
// 1. Publish 1.0.0.
|
||||
_, err := service.CreateServer(ctx, &apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL, Name: serverName, Description: "v1", Version: "1.0.0",
|
||||
})
|
||||
require.NoError(t, err)
|
||||
|
||||
// 2. Publish 0.0.59 — expected not latest at this point.
|
||||
_, err = service.CreateServer(ctx, &apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL, Name: serverName, Description: "v0.0.59", Version: "0.0.59",
|
||||
})
|
||||
require.NoError(t, err)
|
||||
|
||||
// 3. Delete 1.0.0.
|
||||
_, err = service.UpdateServerStatus(ctx, serverName, "1.0.0", &StatusChangeRequest{
|
||||
NewStatus: model.StatusDeleted,
|
||||
})
|
||||
require.NoError(t, err)
|
||||
|
||||
// 4. /versions/latest must not 404.
|
||||
latest, err := service.GetServerByName(ctx, serverName, false)
|
||||
require.NoError(t, err)
|
||||
assert.Equal(t, "0.0.59", latest.Server.Version)
|
||||
|
||||
// 5. Publish 0.0.60 — should become latest because compare now excludes deleted 1.0.0.
|
||||
_, err = service.CreateServer(ctx, &apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL, Name: serverName, Description: "v0.0.60", Version: "0.0.60",
|
||||
})
|
||||
require.NoError(t, err)
|
||||
|
||||
latest, err = service.GetServerByName(ctx, serverName, false)
|
||||
require.NoError(t, err)
|
||||
assert.Equal(t, "0.0.60", latest.Server.Version)
|
||||
assert.True(t, latest.Meta.Official.IsLatest)
|
||||
|
||||
// Only one row should be flagged latest.
|
||||
all, err := service.GetAllVersionsByServerName(ctx, serverName, true)
|
||||
require.NoError(t, err)
|
||||
latestCount := 0
|
||||
for _, v := range all {
|
||||
if v.Meta.Official.IsLatest {
|
||||
latestCount++
|
||||
}
|
||||
}
|
||||
assert.Equal(t, 1, latestCount)
|
||||
}
|
||||
|
||||
func TestRecalculateLatest_AllDeletedKeepsHighestAsLatest(t *testing.T) {
|
||||
ctx := context.Background()
|
||||
testDB := database.NewTestDB(t)
|
||||
service := NewRegistryService(testDB, &config.Config{EnableRegistryValidation: false})
|
||||
|
||||
serverName := "com.example/all-deleted-server"
|
||||
|
||||
_, err := service.CreateServer(ctx, &apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL, Name: serverName, Description: "v1", Version: "1.0.0",
|
||||
})
|
||||
require.NoError(t, err)
|
||||
_, err = service.CreateServer(ctx, &apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL, Name: serverName, Description: "v2", Version: "2.0.0",
|
||||
})
|
||||
require.NoError(t, err)
|
||||
|
||||
// Delete all versions in one call.
|
||||
_, err = service.UpdateAllVersionsStatus(ctx, serverName, &StatusChangeRequest{
|
||||
NewStatus: model.StatusDeleted,
|
||||
})
|
||||
require.NoError(t, err)
|
||||
|
||||
// Public lookup (includeDeleted=false) must now 404.
|
||||
_, err = service.GetServerByName(ctx, serverName, false)
|
||||
require.ErrorIs(t, err, database.ErrNotFound)
|
||||
|
||||
// Admin lookup (includeDeleted=true) must still find the server: the highest deleted
|
||||
// version keeps is_latest=true so the server remains addressable for restore flows.
|
||||
latest, err := service.GetServerByName(ctx, serverName, true)
|
||||
require.NoError(t, err)
|
||||
assert.Equal(t, "2.0.0", latest.Server.Version)
|
||||
assert.True(t, latest.Meta.Official.IsLatest)
|
||||
}
|
||||
|
||||
func TestRecalculateLatest_RestoringHigherVersionPromotesIt(t *testing.T) {
|
||||
ctx := context.Background()
|
||||
testDB := database.NewTestDB(t)
|
||||
service := NewRegistryService(testDB, &config.Config{EnableRegistryValidation: false})
|
||||
|
||||
serverName := "com.example/restore-server"
|
||||
|
||||
// Publish 2.0.0 and 1.0.0 — 2.0.0 is latest.
|
||||
_, err := service.CreateServer(ctx, &apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL, Name: serverName, Description: "v2", Version: "2.0.0",
|
||||
})
|
||||
require.NoError(t, err)
|
||||
_, err = service.CreateServer(ctx, &apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL, Name: serverName, Description: "v1", Version: "1.0.0",
|
||||
})
|
||||
require.NoError(t, err)
|
||||
|
||||
// Delete 2.0.0 — 1.0.0 gets promoted.
|
||||
_, err = service.UpdateServerStatus(ctx, serverName, "2.0.0", &StatusChangeRequest{
|
||||
NewStatus: model.StatusDeleted,
|
||||
})
|
||||
require.NoError(t, err)
|
||||
latest, err := service.GetServerByName(ctx, serverName, false)
|
||||
require.NoError(t, err)
|
||||
require.Equal(t, "1.0.0", latest.Server.Version)
|
||||
|
||||
// Restore 2.0.0 — it should reclaim latest.
|
||||
_, err = service.UpdateServerStatus(ctx, serverName, "2.0.0", &StatusChangeRequest{
|
||||
NewStatus: model.StatusActive,
|
||||
})
|
||||
require.NoError(t, err)
|
||||
latest, err = service.GetServerByName(ctx, serverName, false)
|
||||
require.NoError(t, err)
|
||||
assert.Equal(t, "2.0.0", latest.Server.Version)
|
||||
assert.True(t, latest.Meta.Official.IsLatest)
|
||||
}
|
||||
|
||||
// Helper functions
|
||||
func stringPtr(s string) *string {
|
||||
return &s
|
||||
|
|
|
|||
Loading…
Reference in a new issue