Enforce schema validation on the publish and edit API level (#598)
<!-- Provide a brief summary of your changes --> ## Motivation and Context <!-- Why is this change needed? What problem does it solve? --> The following PR: * Enforces schema validation on the API level (requests without schema or older schema will fail) * Updates the unit tests and examples to match that ## How Has This Been Tested? <!-- Have you tested this in a real application? Which scenarios were tested? --> ## Breaking Changes <!-- Will users need to update their code or configurations? --> **Note this can be considered breaking if clients have not included it before.** ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [ ] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [ ] My code follows the repository's style guidelines - [ ] New and existing tests pass locally - [ ] I have added appropriate error handling - [ ] I have added or updated documentation as needed ## Additional context <!-- Add any other context, implementation notes, or design decisions --> --------- Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
This commit is contained in:
parent
e0f30f1a29
commit
44950c23bb
1 changed files with 244 additions and 21 deletions
|
|
@ -56,6 +56,7 @@ func TestPublishEndpoint(t *testing.T) {
|
|||
{
|
||||
name: "successful publish with GitHub auth",
|
||||
requestBody: apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL,
|
||||
Name: "io.github.example/test-server",
|
||||
Description: "A test server",
|
||||
Repository: model.Repository{
|
||||
|
|
@ -80,6 +81,7 @@ func TestPublishEndpoint(t *testing.T) {
|
|||
{
|
||||
name: "successful publish with no auth (AuthMethodNone)",
|
||||
requestBody: apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL,
|
||||
Name: "example/test-server",
|
||||
Description: "A test server without auth",
|
||||
Repository: model.Repository{
|
||||
|
|
@ -113,6 +115,7 @@ func TestPublishEndpoint(t *testing.T) {
|
|||
{
|
||||
name: "invalid authorization header format",
|
||||
requestBody: apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL,
|
||||
Name: "io.github.domdomegg/test-server",
|
||||
Description: "Test server",
|
||||
Version: "1.0.0",
|
||||
|
|
@ -127,6 +130,7 @@ func TestPublishEndpoint(t *testing.T) {
|
|||
{
|
||||
name: "invalid token",
|
||||
requestBody: apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL,
|
||||
Name: "test-server",
|
||||
Description: "A test server",
|
||||
Version: "1.0.0",
|
||||
|
|
@ -141,6 +145,7 @@ func TestPublishEndpoint(t *testing.T) {
|
|||
{
|
||||
name: "permission denied",
|
||||
requestBody: apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL,
|
||||
Name: "io.github.other/test-server",
|
||||
Description: "A test server",
|
||||
Version: "1.0.0",
|
||||
|
|
@ -165,6 +170,7 @@ func TestPublishEndpoint(t *testing.T) {
|
|||
{
|
||||
name: "registry service error",
|
||||
requestBody: apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL,
|
||||
Name: "example/test-server",
|
||||
Description: "A test server",
|
||||
Version: "1.0.0",
|
||||
|
|
@ -183,6 +189,7 @@ func TestPublishEndpoint(t *testing.T) {
|
|||
setupRegistryService: func(registry service.RegistryService) {
|
||||
// Pre-publish the same server to cause duplicate version error
|
||||
existingServer := apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL,
|
||||
Name: "example/test-server",
|
||||
Description: "Existing test server",
|
||||
Version: "1.0.0",
|
||||
|
|
@ -200,6 +207,7 @@ func TestPublishEndpoint(t *testing.T) {
|
|||
{
|
||||
name: "package validation success - MCPB package",
|
||||
requestBody: apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL,
|
||||
Name: "com.example/test-server-mcpb",
|
||||
Description: "A test server with MCPB package",
|
||||
Version: "1.0.0",
|
||||
|
|
@ -227,6 +235,7 @@ func TestPublishEndpoint(t *testing.T) {
|
|||
{
|
||||
name: "invalid server name - multiple slashes (two slashes)",
|
||||
requestBody: apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL,
|
||||
Name: "com.example/server/path",
|
||||
Description: "Server with multiple slashes in name",
|
||||
Version: "1.0.0",
|
||||
|
|
@ -249,6 +258,7 @@ func TestPublishEndpoint(t *testing.T) {
|
|||
{
|
||||
name: "invalid server name - multiple slashes (three slashes)",
|
||||
requestBody: apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL,
|
||||
Name: "org.company/dept/team/project",
|
||||
Description: "Server with three slashes in name",
|
||||
Version: "1.0.0",
|
||||
|
|
@ -266,6 +276,7 @@ func TestPublishEndpoint(t *testing.T) {
|
|||
{
|
||||
name: "invalid server name - consecutive slashes",
|
||||
requestBody: apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL,
|
||||
Name: "com.example//double-slash",
|
||||
Description: "Server with consecutive slashes",
|
||||
Version: "1.0.0",
|
||||
|
|
@ -283,6 +294,7 @@ func TestPublishEndpoint(t *testing.T) {
|
|||
{
|
||||
name: "invalid server name - URL-like path",
|
||||
requestBody: apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL,
|
||||
Name: "com.example/servers/v1/api",
|
||||
Description: "Server with URL-like path structure",
|
||||
Version: "1.0.0",
|
||||
|
|
@ -300,6 +312,7 @@ func TestPublishEndpoint(t *testing.T) {
|
|||
{
|
||||
name: "invalid server name - many slashes",
|
||||
requestBody: apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL,
|
||||
Name: "a/b/c/d/e/f",
|
||||
Description: "Server with many slashes",
|
||||
Version: "1.0.0",
|
||||
|
|
@ -317,6 +330,7 @@ func TestPublishEndpoint(t *testing.T) {
|
|||
{
|
||||
name: "invalid server name - with packages and remotes",
|
||||
requestBody: apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL,
|
||||
Name: "com.example/test/server/v2",
|
||||
Description: "Complex server with invalid name",
|
||||
Version: "2.0.0",
|
||||
|
|
@ -470,6 +484,7 @@ func TestPublishEndpoint_MultipleSlashesEdgeCases(t *testing.T) {
|
|||
|
||||
// Create request body
|
||||
requestBody := apiv0.ServerJSON{
|
||||
Schema: model.CurrentSchemaURL,
|
||||
Name: tc.serverName,
|
||||
Description: "Test server",
|
||||
Version: "1.0.0",
|
||||
|
|
|
|||
Loading…
Reference in a new issue