Enforce schema validation on the publish and edit API level (#598)

<!-- Provide a brief summary of your changes -->

## Motivation and Context
<!-- Why is this change needed? What problem does it solve? -->
The following PR:
* Enforces schema validation on the API level (requests without schema
or older schema will fail)
* Updates the unit tests and examples to match that

## How Has This Been Tested?
<!-- Have you tested this in a real application? Which scenarios were
tested? -->

## Breaking Changes
<!-- Will users need to update their code or configurations? -->
**Note this can be considered breaking if clients have not included it
before.**

## Types of changes
<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Documentation update

## Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply. -->
- [ ] I have read the [MCP
Documentation](https://modelcontextprotocol.io)
- [ ] My code follows the repository's style guidelines
- [ ] New and existing tests pass locally
- [ ] I have added appropriate error handling
- [ ] I have added or updated documentation as needed

## Additional context
<!-- Add any other context, implementation notes, or design decisions
-->

---------

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
This commit is contained in:
Radoslav Dimitrov 2025-10-05 15:57:10 +03:00 • committed by GitHub
commit 44950c23bb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -26,6 +26,7 @@ func TestListServersEndpoint(t *testing.T) {
// Setup test data
_, err := registryService.CreateServer(ctx, &apiv0.ServerJSON{
Schema: model.CurrentSchemaURL,
Name: "com.example/server-alpha",
Description: "Alpha test server",
Version: "1.0.0",
@ -33,6 +34,7 @@ func TestListServersEndpoint(t *testing.T) {
require.NoError(t, err)
_, err = registryService.CreateServer(ctx, &apiv0.ServerJSON{
Schema: model.CurrentSchemaURL,
Name: "com.example/server-beta",
Description: "Beta test server",
Version: "2.0.0",
@ -118,6 +120,7 @@ func TestGetServerByNameEndpoint(t *testing.T) {
// Setup test data
_, err := registryService.CreateServer(ctx, &apiv0.ServerJSON{
Schema: model.CurrentSchemaURL,
Name: "com.example/detail-server",
Description: "Server for detail testing",
Version: "1.0.0",
@ -180,6 +183,7 @@ func TestGetServerVersionEndpoint(t *testing.T) {
// Setup test data with multiple versions
_, err := registryService.CreateServer(ctx, &apiv0.ServerJSON{
Schema: model.CurrentSchemaURL,
Name: serverName,
Description: "Version test server v1",
Version: "1.0.0",
@ -187,6 +191,7 @@ func TestGetServerVersionEndpoint(t *testing.T) {
require.NoError(t, err)
_, err = registryService.CreateServer(ctx, &apiv0.ServerJSON{
Schema: model.CurrentSchemaURL,
Name: serverName,
Description: "Version test server v2",
Version: "2.0.0",
@ -195,6 +200,7 @@ func TestGetServerVersionEndpoint(t *testing.T) {
// Add version with build metadata for URL encoding test
_, err = registryService.CreateServer(ctx, &apiv0.ServerJSON{
Schema: model.CurrentSchemaURL,
Name: serverName,
Description: "Version test server with build metadata",
Version: "1.0.0+20130313144700",
@ -304,6 +310,7 @@ func TestGetAllVersionsEndpoint(t *testing.T) {
versions := []string{"1.0.0", "1.1.0", "2.0.0"}
for _, version := range versions {
_, err := registryService.CreateServer(ctx, &apiv0.ServerJSON{
Schema: model.CurrentSchemaURL,
Name: serverName,
Description: "Multi-version test server " + version,
Version: version,
@ -402,6 +409,7 @@ func TestServersEndpointEdgeCases(t *testing.T) {
for _, server := range specialServers {
_, err := registryService.CreateServer(ctx, &apiv0.ServerJSON{
Schema: model.CurrentSchemaURL,
Name: server.name,
Description: server.description,
Version: server.version,