From 502b628ac85221d61a130a82ee5381f995ba97e7 Mon Sep 17 00:00:00 2001 From: Ashish Kumar Jain <91244412+8806667653@users.noreply.github.com> Date: Wed, 6 Aug 2025 16:11:46 +0530 Subject: [PATCH] fix: resolve registry image conflict in docker-compose (#114) Issue: links directive was failing on podman - Removed unsupported 'links' directive for Podman compatibility It was failing on Podman because Podman doesn't support the links directive that Docker Compose does, and we already using depends_on, which establishes the dependency relationship between services; we can simply remove the links section from your docker-compose.yml file. ## Motivation and Context docker-compose -links deprecated #107 Fix the defect by removing link. ## How Has This Been Tested? Yes. Test by running on both. For Docker run. docker build -t registry . docker compose up For Podman podman build -t registry . podman compose up ## Breaking Changes Yes for podman. ## Types of changes - [ x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ x] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update ## Checklist - [x ] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [ x] My code follows the repository's style guidelines - [ x] New and existing tests pass locally - [ x] I have added appropriate error handling - [x ] I have added or updated documentation as needed ## Additional context It is related to issue #107 Co-authored-by: Avinash Sridhar Co-authored-by: adam jones --- docker-compose.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/docker-compose.yml b/docker-compose.yml index 7c7dae5..0135521 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -4,8 +4,6 @@ services: container_name: registry build: dockerfile: Dockerfile - links: - - mongodb depends_on: - mongodb environment: