Introduce serverId, rename id to versionId (#465)
Wielded Claude Code to do this; across many iterations and have reviewed all the code + largely rewritten the PR commentary here. This PR implements the server ID consistency changes from [#396](https://github.com/modelcontextprotocol/registry/issues/396). Our goal is to: - Rename `id` to `versionId` to make it clear that it is the ID for a specific version, not a server - Introduce `serverId` as a net new concept. This will be 1:1 with `name`. While not strictly necessary (we could just use name as a PK), the convention of having a UUID as an ID on our objects is just a helpful subjective architecture decision. Plus also leaves open the door to reconsidering the "should we allow renames" question. ## Key Changes ### 🗄️ Database Schema Changes - **Renamed**: `id` column → `version_id` (unique identifier for each server version) ### 📋 Metadata Structure Updates - **JSON Schema**: Updated `_meta.io.modelcontextprotocol.registry/official` to include: - `serverId`: Consistent ID across all versions of a server - `versionId`: Unique ID for this specific version (renamed from `id`) ### 🔧 API Endpoint Updates - **New endpoint structure**: Changed from version-ID-based to server-ID-based URLs: - `GET /v0/servers/{server_id}` - Get latest version of server - `GET /v0/servers/{server_id}?version=X.X.X` - Get specific version - `GET /v0/servers/{server_id}/versions` - List all versions of a server - `PUT /v0/servers/{server_id}?version=X.X.X` - Edit specific version - **Consistent URL patterns**: All server endpoints now use `server_id` as the primary identifier ### Database Migration Strategy The migration (`005_add_server_id_rename_version_id.sql`): 1. Adds new `version_id` column 2. Generates deterministic UUIDs for servers with the same name 3. Updates JSON metadata to add `serverId` and rename `id` to `versionId` 4. Copies existing `id` values to `version_id` column 5. Drops old `id` column and makes `version_id` the new primary key ## Testing Besides of course automated tests passing, I: 1. Set up my local db with the pre-005-migration state, imported all the production data 2. Ran the migration 3. Spot checked some diffs of the data that resulted -- ```json // before { "name": "io.github.ruvnet/ruv-swarm", "_meta": { "io.modelcontextprotocol.registry/official": { "id": "0a9cda7f-2b73-4839-844b-6582f335de42", "is_latest": false, "updated_at": "2025-09-10T17:21:34.92137012Z", "published_at": "2025-09-10T17:15:32.69690433Z" } }, "version": "1.0.18", "repository": { "url": "", "source": "" }, "description": "Neural network swarm orchestration with WebAssembly acceleration and MCP integration" } // after { "name": "io.github.ruvnet/ruv-swarm", "_meta": { "io.modelcontextprotocol.registry/official": { "serverId": "e8538952-96af-4a33-9e31-7fbed012521e", "is_latest": false, "versionId": "0a9cda7f-2b73-4839-844b-6582f335de42", "updated_at": "2025-09-10T17:21:34.92137012Z", "published_at": "2025-09-10T17:15:32.69690433Z" } }, "version": "1.0.18", "repository": { "url": "", "source": "" }, "description": "Neural network swarm orchestration with WebAssembly acceleration and MCP integration" } ``` Servers that have multiple versions stayed consistent in their `serverId`: ```json // First version { "name": "app.getdialer/dialer", "_meta": { "io.modelcontextprotocol.registry/official": { "serverId": "80f08bdb-f3e4-4f19-b072-1676ae49b663", "is_latest": false, "versionId": "04f25b17-331d-48d7-b08b-37baece208a7", "updated_at": "2025-09-09T00:16:49.162620072Z", "published_at": "2025-09-08T23:47:09.452137971Z" } }, "status": "active", "$schema": "https://static.modelcontextprotocol.io/schemas/2025-07-09/server.schema.json", "remotes": [ { "url": "https://getdialer.app/mcp", "type": "streamable-http" }, { "url": "https://getdialer.app/sse", "type": "sse" } ], "version": "1.0.0", "repository": { "url": "", "source": "" }, "description": "An MCP server that provides your you make outbound phone calls using your own phone number" } // Second version { "name": "app.getdialer/dialer", "_meta": { "io.modelcontextprotocol.registry/official": { "serverId": "80f08bdb-f3e4-4f19-b072-1676ae49b663", "is_latest": true, "versionId": "faa26cb9-3aad-415e-aece-f715fff5fe5e", "updated_at": "2025-09-09T00:16:49.107842808Z", "published_at": "2025-09-09T00:16:49.107842808Z" } }, "status": "active", "$schema": "https://static.modelcontextprotocol.io/schemas/2025-07-09/server.schema.json", "remotes": [ { "url": "https://getdialer.app/mcp", "type": "streamable-http" }, { "url": "https://getdialer.app/sse", "type": "sse" } ], "version": "1.0.1", "repository": { "url": "", "source": "" }, "description": "An MCP server that provides lets you make outbound phone calls using your own phone number" } ``` And I also tried publishing a test server anew; looked good: ```bash ⏺ Bash(curl -s "http://localhost:8080/v0/servers/102dc4e4-6ca8-40e6-aa11-cd45763d3352" | jq '.') ⎿ { "$schema": "https://static.modelcontextprotocol.io/schemas/2025-07-09/server.schema.json", "name": "io.modelcontextprotocol.anonymous/test-claude-migration-server", "description": "A test server to verify the new migration and API endpoints work correctly", "status": "active", "repository": { "url": "https://github.com/example/test-claude-migration-server", "source": "github", "id": "example/test-claude-migration-server" }, "version": "1.0.0", "_meta": { "io.modelcontextprotocol.registry/official": { "serverId": "102dc4e4-6ca8-40e6-aa11-cd45763d3352", "versionId": "48c9cd55-7bc4-4ac2-896e-59e81eb653e4", "published_at": "2025-09-12T18:33:23.264203-07:00", "updated_at": "2025-09-12T18:33:23.264203-07:00", "is_latest": true } } } ⏺ Bash(curl -s "http://localhost:8080/v0/servers/102dc4e4-6ca8-40e6-aa11-cd45763d3352/versions" | jq '.') ⎿ { "servers": [ { "$schema": "https://static.modelcontextprotocol.io/schemas/2025-07-09/server.schema.json", "name": "io.modelcontextprotocol.anonymous/test-claude-migration-server", "description": "A test server to verify the new migration and API endpoints work correctly", "status": "active", "repository": { "url": "https://github.com/example/test-claude-migration-server", "source": "github", "id": "example/test-claude-migration-server" }, "version": "1.0.0", "_meta": { "io.modelcontextprotocol.registry/official": { "serverId": "102dc4e4-6ca8-40e6-aa11-cd45763d3352", "versionId": "48c9cd55-7bc4-4ac2-896e-59e81eb653e4", "published_at": "2025-09-12T18:33:23.264203-07:00", "updated_at": "2025-09-12T18:33:23.264203-07:00", "is_latest": true } } } ], "metadata": { "count": 1 } } ``` Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Preeti Dewani <preetidewani1990@gmail.com> Co-authored-by: adam jones <adamj+git@anthropic.com> Co-authored-by: Adam Jones <adamj@anthropic.com>
This commit is contained in:
parent
52b1dc71b6
commit
56e8b4879b
4 changed files with 5185 additions and 3466 deletions
|
|
@ -32,8 +32,14 @@ type ServerFilter struct {
|
|||
type Database interface {
|
||||
// Retrieve server entries with optional filtering
|
||||
List(ctx context.Context, filter *ServerFilter, cursor string, limit int) ([]*apiv0.ServerJSON, string, error)
|
||||
// Retrieve a single server by its ID
|
||||
GetByID(ctx context.Context, id string) (*apiv0.ServerJSON, error)
|
||||
// Retrieve a single server by its version ID
|
||||
GetByVersionID(ctx context.Context, versionID string) (*apiv0.ServerJSON, error)
|
||||
// Retrieve latest version of a server by server ID
|
||||
GetByServerID(ctx context.Context, serverID string) (*apiv0.ServerJSON, error)
|
||||
// Retrieve specific version of a server by server ID and version
|
||||
GetByServerIDAndVersion(ctx context.Context, serverID string, version string) (*apiv0.ServerJSON, error)
|
||||
// Retrieve all versions of a server by server ID
|
||||
GetAllVersionsByServerID(ctx context.Context, serverID string) ([]*apiv0.ServerJSON, error)
|
||||
// CreateServer adds a new server to the database
|
||||
CreateServer(ctx context.Context, server *apiv0.ServerJSON) (*apiv0.ServerJSON, error)
|
||||
// UpdateServer updates an existing server record
|
||||
|
|
|
|||
|
|
@ -12,7 +12,7 @@ import (
|
|||
|
||||
// MemoryDB is an in-memory implementation of the Database interface
|
||||
type MemoryDB struct {
|
||||
entries map[string]*apiv0.ServerJSON // maps registry metadata ID to ServerJSON
|
||||
entries map[string]*apiv0.ServerJSON // maps registry metadata version_id to ServerJSON
|
||||
mu sync.RWMutex
|
||||
}
|
||||
|
||||
|
|
@ -80,7 +80,7 @@ func (db *MemoryDB) List(
|
|||
return result, nextCursor, nil
|
||||
}
|
||||
|
||||
func (db *MemoryDB) GetByID(ctx context.Context, id string) (*apiv0.ServerJSON, error) {
|
||||
func (db *MemoryDB) GetByVersionID(ctx context.Context, versionID string) (*apiv0.ServerJSON, error) {
|
||||
if ctx.Err() != nil {
|
||||
return nil, ctx.Err()
|
||||
}
|
||||
|
|
@ -88,8 +88,8 @@ func (db *MemoryDB) GetByID(ctx context.Context, id string) (*apiv0.ServerJSON,
|
|||
db.mu.RLock()
|
||||
defer db.mu.RUnlock()
|
||||
|
||||
// Find entry by registry metadata ID
|
||||
if entry, exists := db.entries[id]; exists {
|
||||
// Find entry by registry metadata version_id
|
||||
if entry, exists := db.entries[versionID]; exists {
|
||||
// Return a copy of the ServerRecord
|
||||
entryCopy := *entry
|
||||
return &entryCopy, nil
|
||||
|
|
@ -98,23 +98,112 @@ func (db *MemoryDB) GetByID(ctx context.Context, id string) (*apiv0.ServerJSON,
|
|||
return nil, ErrNotFound
|
||||
}
|
||||
|
||||
// GetByServerID retrieves the latest version of a server by server ID
|
||||
func (db *MemoryDB) GetByServerID(ctx context.Context, serverID string) (*apiv0.ServerJSON, error) {
|
||||
if ctx.Err() != nil {
|
||||
return nil, ctx.Err()
|
||||
}
|
||||
|
||||
db.mu.RLock()
|
||||
defer db.mu.RUnlock()
|
||||
|
||||
// Find the latest version with the given server ID
|
||||
var latestEntry *apiv0.ServerJSON
|
||||
for _, entry := range db.entries {
|
||||
if entry.Meta != nil && entry.Meta.Official != nil &&
|
||||
entry.Meta.Official.ServerID == serverID &&
|
||||
entry.Meta.Official.IsLatest {
|
||||
latestEntry = entry
|
||||
break
|
||||
}
|
||||
}
|
||||
|
||||
if latestEntry == nil {
|
||||
return nil, ErrNotFound
|
||||
}
|
||||
|
||||
// Return a copy
|
||||
entryCopy := *latestEntry
|
||||
return &entryCopy, nil
|
||||
}
|
||||
|
||||
// GetByServerIDAndVersion retrieves a specific version of a server by server ID and version
|
||||
func (db *MemoryDB) GetByServerIDAndVersion(ctx context.Context, serverID string, version string) (*apiv0.ServerJSON, error) {
|
||||
if ctx.Err() != nil {
|
||||
return nil, ctx.Err()
|
||||
}
|
||||
|
||||
db.mu.RLock()
|
||||
defer db.mu.RUnlock()
|
||||
|
||||
// Find the entry with matching server ID and version
|
||||
for _, entry := range db.entries {
|
||||
if entry.Meta != nil && entry.Meta.Official != nil &&
|
||||
entry.Meta.Official.ServerID == serverID &&
|
||||
entry.Version == version {
|
||||
// Return a copy
|
||||
entryCopy := *entry
|
||||
return &entryCopy, nil
|
||||
}
|
||||
}
|
||||
|
||||
return nil, ErrNotFound
|
||||
}
|
||||
|
||||
// GetAllVersionsByServerID retrieves all versions of a server by server ID
|
||||
func (db *MemoryDB) GetAllVersionsByServerID(ctx context.Context, serverID string) ([]*apiv0.ServerJSON, error) {
|
||||
if ctx.Err() != nil {
|
||||
return nil, ctx.Err()
|
||||
}
|
||||
|
||||
db.mu.RLock()
|
||||
defer db.mu.RUnlock()
|
||||
|
||||
var results []*apiv0.ServerJSON
|
||||
for _, entry := range db.entries {
|
||||
if entry.Meta != nil && entry.Meta.Official != nil &&
|
||||
entry.Meta.Official.ServerID == serverID {
|
||||
// Add a copy
|
||||
entryCopy := *entry
|
||||
results = append(results, &entryCopy)
|
||||
}
|
||||
}
|
||||
|
||||
if len(results) == 0 {
|
||||
return nil, ErrNotFound
|
||||
}
|
||||
|
||||
// Sort by published date, latest first
|
||||
sort.Slice(results, func(i, j int) bool {
|
||||
iTime := results[i].Meta.Official.PublishedAt
|
||||
jTime := results[j].Meta.Official.PublishedAt
|
||||
return iTime.After(jTime)
|
||||
})
|
||||
|
||||
return results, nil
|
||||
}
|
||||
|
||||
func (db *MemoryDB) CreateServer(ctx context.Context, server *apiv0.ServerJSON) (*apiv0.ServerJSON, error) {
|
||||
if ctx.Err() != nil {
|
||||
return nil, ctx.Err()
|
||||
}
|
||||
|
||||
// Get the ID from the registry metadata
|
||||
// Get the VersionID from the registry metadata
|
||||
if server.Meta == nil || server.Meta.Official == nil {
|
||||
return nil, fmt.Errorf("server must have registry metadata with ID")
|
||||
return nil, fmt.Errorf("server must have registry metadata with ServerID and VersionID")
|
||||
}
|
||||
|
||||
id := server.Meta.Official.ID
|
||||
versionID := server.Meta.Official.VersionID
|
||||
|
||||
if versionID == "" {
|
||||
return nil, fmt.Errorf("server must have VersionID in registry metadata")
|
||||
}
|
||||
|
||||
db.mu.Lock()
|
||||
defer db.mu.Unlock()
|
||||
|
||||
// Store the record using registry metadata ID
|
||||
db.entries[id] = server
|
||||
// Store the record using registry metadata VersionID
|
||||
db.entries[versionID] = server
|
||||
|
||||
return server, nil
|
||||
}
|
||||
|
|
@ -124,6 +213,11 @@ func (db *MemoryDB) UpdateServer(ctx context.Context, id string, server *apiv0.S
|
|||
return nil, ctx.Err()
|
||||
}
|
||||
|
||||
// Validate that meta structure exists and VersionID matches path (consistent with PostgreSQL implementation)
|
||||
if server.Meta == nil || server.Meta.Official == nil || server.Meta.Official.VersionID != id {
|
||||
return nil, fmt.Errorf("%w: io.modelcontextprotocol.registry/official.version_id must match path id (%s)", ErrInvalidInput, id)
|
||||
}
|
||||
|
||||
db.mu.Lock()
|
||||
defer db.mu.Unlock()
|
||||
|
||||
|
|
@ -165,6 +259,7 @@ func (db *MemoryDB) filterAndSort(allEntries []*apiv0.ServerJSON, filter *Server
|
|||
}
|
||||
|
||||
// matchesFilter checks if an entry matches the provided filter
|
||||
//
|
||||
//nolint:cyclop // Filter matching logic is inherently complex but clear
|
||||
func (db *MemoryDB) matchesFilter(entry *apiv0.ServerJSON, filter *ServerFilter) bool {
|
||||
if filter == nil {
|
||||
|
|
@ -218,7 +313,7 @@ func (db *MemoryDB) matchesFilter(entry *apiv0.ServerJSON, filter *ServerFilter)
|
|||
}
|
||||
}
|
||||
|
||||
// Check is_latest filter
|
||||
// Check isLatest filter
|
||||
if filter.IsLatest != nil {
|
||||
if entry.Meta == nil || entry.Meta.Official == nil {
|
||||
return false
|
||||
|
|
@ -231,10 +326,10 @@ func (db *MemoryDB) matchesFilter(entry *apiv0.ServerJSON, filter *ServerFilter)
|
|||
return true
|
||||
}
|
||||
|
||||
// getRegistryID safely extracts the registry ID from an entry
|
||||
// getRegistryID safely extracts the registry version ID from an entry
|
||||
func (db *MemoryDB) getRegistryID(entry *apiv0.ServerJSON) string {
|
||||
if entry.Meta != nil && entry.Meta.Official != nil {
|
||||
return entry.Meta.Official.ID
|
||||
return entry.Meta.Official.VersionID
|
||||
}
|
||||
return ""
|
||||
}
|
||||
|
|
|
|||
|
|
@ -0,0 +1,90 @@
|
|||
-- Migration to rename id to version_id and update JSON metadata
|
||||
-- This implements the server ID consistency changes from GitHub issue #396
|
||||
--
|
||||
-- Current schema: servers(id VARCHAR, value JSONB)
|
||||
-- Target schema: servers(version_id VARCHAR, value JSONB)
|
||||
-- JSON metadata changes:
|
||||
-- - rename "id" to "versionId"
|
||||
-- - add "serverId" (consistent across versions of same server)
|
||||
|
||||
BEGIN;
|
||||
|
||||
-- Add the new version_id column
|
||||
ALTER TABLE servers ADD COLUMN version_id VARCHAR(255);
|
||||
|
||||
-- Create a temporary function to:
|
||||
-- 1. Migrate id -> version_id column
|
||||
-- 2. Update JSON metadata to add serverId and rename id to versionId
|
||||
CREATE OR REPLACE FUNCTION migrate_to_server_version_ids()
|
||||
RETURNS VOID AS $$
|
||||
DECLARE
|
||||
rec RECORD;
|
||||
server_name TEXT;
|
||||
server_id_map JSONB := '{}';
|
||||
new_server_id UUID;
|
||||
updated_meta JSONB;
|
||||
updated_value JSONB;
|
||||
BEGIN
|
||||
-- Iterate through all records and assign server_id and version_id
|
||||
FOR rec IN SELECT id, value FROM servers ORDER BY id LOOP
|
||||
-- Extract server name from the JSONB value
|
||||
server_name := rec.value->>'name';
|
||||
|
||||
-- Check if we already have a server_id for this server name
|
||||
IF (server_id_map ? server_name) THEN
|
||||
new_server_id := (server_id_map->>server_name)::UUID;
|
||||
ELSE
|
||||
-- Generate a new server_id for this server name
|
||||
new_server_id := uuid_generate_v4();
|
||||
server_id_map := jsonb_set(server_id_map, ARRAY[server_name], to_jsonb(new_server_id::TEXT));
|
||||
END IF;
|
||||
|
||||
-- Update the JSON metadata
|
||||
updated_meta := rec.value->'_meta'->'io.modelcontextprotocol.registry/official';
|
||||
|
||||
-- Add serverId and rename id to versionId
|
||||
updated_meta := updated_meta || jsonb_build_object(
|
||||
'serverId', new_server_id::TEXT,
|
||||
'versionId', updated_meta->>'id'
|
||||
);
|
||||
|
||||
-- Remove the old 'id' field
|
||||
updated_meta := updated_meta - 'id';
|
||||
|
||||
-- Update the full value with new metadata
|
||||
updated_value := jsonb_set(
|
||||
rec.value,
|
||||
'{_meta,io.modelcontextprotocol.registry/official}',
|
||||
updated_meta
|
||||
);
|
||||
|
||||
-- Update the record with version_id and updated JSON
|
||||
UPDATE servers
|
||||
SET
|
||||
version_id = rec.id,
|
||||
value = updated_value
|
||||
WHERE id = rec.id;
|
||||
END LOOP;
|
||||
END;
|
||||
$$ LANGUAGE plpgsql;
|
||||
|
||||
-- Execute the migration function
|
||||
SELECT migrate_to_server_version_ids();
|
||||
|
||||
-- Drop the temporary function
|
||||
DROP FUNCTION migrate_to_server_version_ids();
|
||||
|
||||
-- Make version_id NOT NULL now that all records have values
|
||||
ALTER TABLE servers ALTER COLUMN version_id SET NOT NULL;
|
||||
|
||||
-- Drop the old id column (replaced by version_id)
|
||||
ALTER TABLE servers DROP COLUMN id;
|
||||
|
||||
-- Make version_id the new primary key
|
||||
ALTER TABLE servers ADD CONSTRAINT servers_pkey PRIMARY KEY (version_id);
|
||||
|
||||
-- Update existing indexes to use version_id instead of id
|
||||
DROP INDEX IF EXISTS idx_servers_id;
|
||||
CREATE INDEX idx_servers_version_id ON servers(version_id);
|
||||
|
||||
COMMIT;
|
||||
|
|
@ -11,6 +11,7 @@ import (
|
|||
"github.com/google/uuid"
|
||||
"github.com/jackc/pgx/v5"
|
||||
"github.com/jackc/pgx/v5/pgxpool"
|
||||
|
||||
apiv0 "github.com/modelcontextprotocol/registry/pkg/api/v0"
|
||||
)
|
||||
|
||||
|
|
@ -50,7 +51,7 @@ func NewPostgreSQL(ctx context.Context, connectionURI string) (*PostgreSQL, erro
|
|||
return nil, fmt.Errorf("failed to acquire connection for migrations: %w", err)
|
||||
}
|
||||
defer conn.Release()
|
||||
|
||||
|
||||
migrator := NewMigrator(conn.Conn())
|
||||
if err := migrator.Migrate(ctx); err != nil {
|
||||
return nil, fmt.Errorf("failed to run database migrations: %w", err)
|
||||
|
|
@ -94,7 +95,7 @@ func (db *PostgreSQL) List(
|
|||
argIndex++
|
||||
}
|
||||
if filter.UpdatedSince != nil {
|
||||
whereConditions = append(whereConditions, fmt.Sprintf("(value->'_meta'->'io.modelcontextprotocol.registry/official'->>'updated_at')::timestamp > $%d", argIndex))
|
||||
whereConditions = append(whereConditions, fmt.Sprintf("(value->'_meta'->'io.modelcontextprotocol.registry/official'->>'updatedAt')::timestamp > $%d", argIndex))
|
||||
args = append(args, *filter.UpdatedSince)
|
||||
argIndex++
|
||||
}
|
||||
|
|
@ -109,18 +110,18 @@ func (db *PostgreSQL) List(
|
|||
argIndex++
|
||||
}
|
||||
if filter.IsLatest != nil {
|
||||
whereConditions = append(whereConditions, fmt.Sprintf("(value->'_meta'->'io.modelcontextprotocol.registry/official'->>'is_latest')::boolean = $%d", argIndex))
|
||||
whereConditions = append(whereConditions, fmt.Sprintf("(value->'_meta'->'io.modelcontextprotocol.registry/official'->>'isLatest')::boolean = $%d", argIndex))
|
||||
args = append(args, *filter.IsLatest)
|
||||
argIndex++
|
||||
}
|
||||
}
|
||||
|
||||
// Add cursor pagination using primary key ID
|
||||
// Add cursor pagination using primary key version_id
|
||||
if cursor != "" {
|
||||
if _, err := uuid.Parse(cursor); err != nil {
|
||||
return nil, "", fmt.Errorf("invalid cursor format: %w", err)
|
||||
}
|
||||
whereConditions = append(whereConditions, fmt.Sprintf("id > $%d", argIndex))
|
||||
whereConditions = append(whereConditions, fmt.Sprintf("version_id > $%d", argIndex))
|
||||
args = append(args, cursor)
|
||||
argIndex++
|
||||
}
|
||||
|
|
@ -136,7 +137,7 @@ func (db *PostgreSQL) List(
|
|||
SELECT value
|
||||
FROM servers
|
||||
%s
|
||||
ORDER BY id
|
||||
ORDER BY version_id
|
||||
LIMIT $%d
|
||||
`, whereClause, argIndex)
|
||||
args = append(args, limit)
|
||||
|
|
@ -169,19 +170,19 @@ func (db *PostgreSQL) List(
|
|||
return nil, "", fmt.Errorf("error iterating rows: %w", err)
|
||||
}
|
||||
|
||||
// Determine next cursor using registry metadata ID
|
||||
// Determine next cursor using registry metadata VersionID
|
||||
nextCursor := ""
|
||||
if len(results) > 0 && len(results) >= limit {
|
||||
lastResult := results[len(results)-1]
|
||||
if lastResult.Meta != nil && lastResult.Meta.Official != nil {
|
||||
nextCursor = lastResult.Meta.Official.ID
|
||||
nextCursor = lastResult.Meta.Official.VersionID
|
||||
}
|
||||
}
|
||||
|
||||
return results, nextCursor, nil
|
||||
}
|
||||
|
||||
func (db *PostgreSQL) GetByID(ctx context.Context, id string) (*apiv0.ServerJSON, error) {
|
||||
func (db *PostgreSQL) GetByVersionID(ctx context.Context, versionID string) (*apiv0.ServerJSON, error) {
|
||||
if ctx.Err() != nil {
|
||||
return nil, ctx.Err()
|
||||
}
|
||||
|
|
@ -189,12 +190,12 @@ func (db *PostgreSQL) GetByID(ctx context.Context, id string) (*apiv0.ServerJSON
|
|||
query := `
|
||||
SELECT value
|
||||
FROM servers
|
||||
WHERE id = $1
|
||||
WHERE version_id = $1
|
||||
`
|
||||
|
||||
var valueJSON []byte
|
||||
|
||||
err := db.pool.QueryRow(ctx, query, id).Scan(&valueJSON)
|
||||
err := db.pool.QueryRow(ctx, query, versionID).Scan(&valueJSON)
|
||||
|
||||
if err != nil {
|
||||
if errors.Is(err, pgx.ErrNoRows) {
|
||||
|
|
@ -212,18 +213,138 @@ func (db *PostgreSQL) GetByID(ctx context.Context, id string) (*apiv0.ServerJSON
|
|||
return &serverJSON, nil
|
||||
}
|
||||
|
||||
// GetByServerID retrieves the latest version of a server by server ID
|
||||
func (db *PostgreSQL) GetByServerID(ctx context.Context, serverID string) (*apiv0.ServerJSON, error) {
|
||||
if ctx.Err() != nil {
|
||||
return nil, ctx.Err()
|
||||
}
|
||||
|
||||
query := `
|
||||
SELECT value
|
||||
FROM servers
|
||||
WHERE (value->'_meta'->'io.modelcontextprotocol.registry/official'->>'serverId') = $1 AND (value->'_meta'->'io.modelcontextprotocol.registry/official'->>'isLatest')::boolean = true
|
||||
ORDER BY (value->'_meta'->'io.modelcontextprotocol.registry/official'->>'publishedAt')::timestamp DESC
|
||||
LIMIT 1
|
||||
`
|
||||
|
||||
var valueJSON []byte
|
||||
|
||||
err := db.pool.QueryRow(ctx, query, serverID).Scan(&valueJSON)
|
||||
|
||||
if err != nil {
|
||||
if errors.Is(err, pgx.ErrNoRows) {
|
||||
return nil, ErrNotFound
|
||||
}
|
||||
return nil, fmt.Errorf("failed to get server by server ID: %w", err)
|
||||
}
|
||||
|
||||
// Parse the complete ServerJSON from JSONB
|
||||
var serverJSON apiv0.ServerJSON
|
||||
if err := json.Unmarshal(valueJSON, &serverJSON); err != nil {
|
||||
return nil, fmt.Errorf("failed to unmarshal server JSON: %w", err)
|
||||
}
|
||||
|
||||
return &serverJSON, nil
|
||||
}
|
||||
|
||||
// GetByServerIDAndVersion retrieves a specific version of a server by server ID and version
|
||||
func (db *PostgreSQL) GetByServerIDAndVersion(ctx context.Context, serverID string, version string) (*apiv0.ServerJSON, error) {
|
||||
if ctx.Err() != nil {
|
||||
return nil, ctx.Err()
|
||||
}
|
||||
|
||||
query := `
|
||||
SELECT value
|
||||
FROM servers
|
||||
WHERE (value->'_meta'->'io.modelcontextprotocol.registry/official'->>'serverId') = $1 AND value->>'version' = $2
|
||||
LIMIT 1
|
||||
`
|
||||
|
||||
var valueJSON []byte
|
||||
|
||||
err := db.pool.QueryRow(ctx, query, serverID, version).Scan(&valueJSON)
|
||||
|
||||
if err != nil {
|
||||
if errors.Is(err, pgx.ErrNoRows) {
|
||||
return nil, ErrNotFound
|
||||
}
|
||||
return nil, fmt.Errorf("failed to get server by server ID and version: %w", err)
|
||||
}
|
||||
|
||||
// Parse the complete ServerJSON from JSONB
|
||||
var serverJSON apiv0.ServerJSON
|
||||
if err := json.Unmarshal(valueJSON, &serverJSON); err != nil {
|
||||
return nil, fmt.Errorf("failed to unmarshal server JSON: %w", err)
|
||||
}
|
||||
|
||||
return &serverJSON, nil
|
||||
}
|
||||
|
||||
// GetAllVersionsByServerID retrieves all versions of a server by server ID
|
||||
func (db *PostgreSQL) GetAllVersionsByServerID(ctx context.Context, serverID string) ([]*apiv0.ServerJSON, error) {
|
||||
if ctx.Err() != nil {
|
||||
return nil, ctx.Err()
|
||||
}
|
||||
|
||||
query := `
|
||||
SELECT value
|
||||
FROM servers
|
||||
WHERE (value->'_meta'->'io.modelcontextprotocol.registry/official'->>'serverId') = $1
|
||||
ORDER BY (value->'_meta'->'io.modelcontextprotocol.registry/official'->>'publishedAt')::timestamp DESC
|
||||
`
|
||||
|
||||
rows, err := db.pool.Query(ctx, query, serverID)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("failed to query server versions: %w", err)
|
||||
}
|
||||
defer rows.Close()
|
||||
|
||||
var results []*apiv0.ServerJSON
|
||||
for rows.Next() {
|
||||
var valueJSON []byte
|
||||
|
||||
err := rows.Scan(&valueJSON)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("failed to scan server row: %w", err)
|
||||
}
|
||||
|
||||
// Parse the complete ServerJSON from JSONB
|
||||
var serverJSON apiv0.ServerJSON
|
||||
if err := json.Unmarshal(valueJSON, &serverJSON); err != nil {
|
||||
return nil, fmt.Errorf("failed to unmarshal server JSON: %w", err)
|
||||
}
|
||||
|
||||
results = append(results, &serverJSON)
|
||||
}
|
||||
|
||||
if err := rows.Err(); err != nil {
|
||||
return nil, fmt.Errorf("error iterating rows: %w", err)
|
||||
}
|
||||
|
||||
if len(results) == 0 {
|
||||
return nil, ErrNotFound
|
||||
}
|
||||
|
||||
return results, nil
|
||||
}
|
||||
|
||||
// CreateServer adds a new server to the database
|
||||
func (db *PostgreSQL) CreateServer(ctx context.Context, server *apiv0.ServerJSON) (*apiv0.ServerJSON, error) {
|
||||
if ctx.Err() != nil {
|
||||
return nil, ctx.Err()
|
||||
}
|
||||
|
||||
// Get the ID from the registry metadata
|
||||
// Get the IDs from the registry metadata
|
||||
if server.Meta == nil || server.Meta.Official == nil {
|
||||
return nil, fmt.Errorf("server must have registry metadata with ID")
|
||||
return nil, fmt.Errorf("server must have registry metadata with ServerID and VersionID")
|
||||
}
|
||||
|
||||
id := server.Meta.Official.ID
|
||||
serverID := server.Meta.Official.ServerID
|
||||
versionID := server.Meta.Official.VersionID
|
||||
|
||||
if serverID == "" || versionID == "" {
|
||||
return nil, fmt.Errorf("server must have both ServerID and VersionID in registry metadata")
|
||||
}
|
||||
|
||||
// Marshal the complete server to JSONB
|
||||
valueJSON, err := json.Marshal(server)
|
||||
|
|
@ -231,13 +352,13 @@ func (db *PostgreSQL) CreateServer(ctx context.Context, server *apiv0.ServerJSON
|
|||
return nil, fmt.Errorf("failed to marshal server JSON: %w", err)
|
||||
}
|
||||
|
||||
// Insert into simple servers table
|
||||
// Insert into servers table with new schema (only version_id column, serverId is in JSON)
|
||||
query := `
|
||||
INSERT INTO servers (id, value)
|
||||
INSERT INTO servers (version_id, value)
|
||||
VALUES ($1, $2)
|
||||
`
|
||||
|
||||
_, err = db.pool.Exec(ctx, query, id, valueJSON)
|
||||
_, err = db.pool.Exec(ctx, query, versionID, valueJSON)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("failed to insert server: %w", err)
|
||||
}
|
||||
|
|
@ -251,9 +372,9 @@ func (db *PostgreSQL) UpdateServer(ctx context.Context, id string, server *apiv0
|
|||
return nil, ctx.Err()
|
||||
}
|
||||
|
||||
// Validate that meta structure exists and ID matches path
|
||||
if server.Meta == nil || server.Meta.Official == nil || server.Meta.Official.ID != id {
|
||||
return nil, fmt.Errorf("%w: io.modelcontextprotocol.registry/official.id must match path id (%s)", ErrInvalidInput, id)
|
||||
// Validate that meta structure exists and VersionID matches path
|
||||
if server.Meta == nil || server.Meta.Official == nil || server.Meta.Official.VersionID != id {
|
||||
return nil, fmt.Errorf("%w: io.modelcontextprotocol.registry/official.version_id must match path id (%s)", ErrInvalidInput, id)
|
||||
}
|
||||
|
||||
// Marshal updated server
|
||||
|
|
@ -262,11 +383,11 @@ func (db *PostgreSQL) UpdateServer(ctx context.Context, id string, server *apiv0
|
|||
return nil, fmt.Errorf("failed to marshal updated server: %w", err)
|
||||
}
|
||||
|
||||
// Update the complete server record in simple table
|
||||
// Update the complete server record using version_id
|
||||
query := `
|
||||
UPDATE servers
|
||||
SET value = $1
|
||||
WHERE id = $2
|
||||
WHERE version_id = $2
|
||||
`
|
||||
|
||||
result, err := db.pool.Exec(ctx, query, valueJSON, id)
|
||||
|
|
|
|||
Loading…
Reference in a new issue