refactor: extract readBody helper to remove duplicate io.ReadAll calls (#1241)

The same pattern for reading an error response body appeared in three
places across the auth handlers:

- `internal/api/handlers/v0/auth/github_at.go` (twice)
- `internal/api/handlers/v0/auth/github_oidc.go` (once)

A shared `readBody` helper function added to `common.go` now handles
this in one place.
The `io` import is removed from both files since it is no longer used
directly there.

---------

Co-authored-by: Radoslav Dimitrov <radoslav@stacklok.com>
This commit is contained in:
Mesut Oezdil 2026-05-04 12:57:02 +02:00 • committed by GitHub
commit 6f9bd6661c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -10,6 +10,7 @@ import (
"encoding/hex"
"errors"
"fmt"
"io"
"math/big"
"net"
"regexp"
@ -20,6 +21,11 @@ import (
"github.com/modelcontextprotocol/registry/internal/config"
)
func readBody(r io.Reader) string {
b, _ := io.ReadAll(r)
return string(b)
}
// ErrSignatureMismatch is returned by VerifySignature when the signature is structurally
// valid but does not verify against the public key. Distinguishing this from structural
// failures (wrong size, bad key format) lets the caller add fingerprint hints only when