feat: implement DNS namespace validation and remote URL uniqueness checks (#306)
## Summary - Add reverse-DNS namespace format validation for server names (namespace/name) - Validate remote URLs match the DNS namespace derived from hostname - Prevent duplicate remote URLs across different servers - Support localhost/development URLs without namespace restrictions - Add comprehensive test coverage for validation logic - Update database layer to support remote_url filtering Fixes #180 by ensuring proper namespace governance and preventing URL conflicts. --------- Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
parent
d663406280
commit
923b2e07b9
11 changed files with 497 additions and 29 deletions
|
|
@ -186,7 +186,7 @@ This will essentially instruct the MCP client to execute `dnx Knapcode.SampleMcp
|
||||||
```json
|
```json
|
||||||
{
|
{
|
||||||
"server": {
|
"server": {
|
||||||
"name": "com.example/mcp-fs",
|
"name": "io.modelcontextprotocol.anonymous/mcp-fs",
|
||||||
"description": "Cloud-hosted MCP filesystem server",
|
"description": "Cloud-hosted MCP filesystem server",
|
||||||
"repository": {
|
"repository": {
|
||||||
"url": "https://github.com/example/remote-fs",
|
"url": "https://github.com/example/remote-fs",
|
||||||
|
|
@ -199,7 +199,7 @@ This will essentially instruct the MCP client to execute `dnx Knapcode.SampleMcp
|
||||||
"remotes": [
|
"remotes": [
|
||||||
{
|
{
|
||||||
"transport_type": "sse",
|
"transport_type": "sse",
|
||||||
"url": "http://mcp-fs.example.com/sse"
|
"url": "http://mcp-fs.anonymous.modelcontextprotocol.io/sse"
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
},
|
},
|
||||||
|
|
@ -418,7 +418,7 @@ The `dnx` tool ships with the .NET 10 SDK, starting with Preview 6.
|
||||||
```json
|
```json
|
||||||
{
|
{
|
||||||
"server": {
|
"server": {
|
||||||
"name": "com.example/hybrid-mcp",
|
"name": "io.modelcontextprotocol.anonymous/hybrid-mcp",
|
||||||
"description": "MCP server available as both local package and remote service",
|
"description": "MCP server available as both local package and remote service",
|
||||||
"repository": {
|
"repository": {
|
||||||
"url": "https://github.com/example/hybrid-mcp",
|
"url": "https://github.com/example/hybrid-mcp",
|
||||||
|
|
@ -448,7 +448,7 @@ The `dnx` tool ships with the .NET 10 SDK, starting with Preview 6.
|
||||||
"remotes": [
|
"remotes": [
|
||||||
{
|
{
|
||||||
"transport_type": "sse",
|
"transport_type": "sse",
|
||||||
"url": "https://mcp.example.com/sse",
|
"url": "https://mcp.anonymous.modelcontextprotocol.io/sse",
|
||||||
"headers": [
|
"headers": [
|
||||||
{
|
{
|
||||||
"name": "X-API-Key",
|
"name": "X-API-Key",
|
||||||
|
|
@ -466,7 +466,7 @@ The `dnx` tool ships with the .NET 10 SDK, starting with Preview 6.
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
"transport_type": "streamable",
|
"transport_type": "streamable",
|
||||||
"url": "https://mcp.example.com/http"
|
"url": "https://mcp.anonymous.modelcontextprotocol.io/http"
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
},
|
},
|
||||||
|
|
|
||||||
|
|
@ -71,7 +71,7 @@ func RegisterPublishEndpoint(api huma.API, registry service.RegistryService, cfg
|
||||||
// Publish the server with extensions
|
// Publish the server with extensions
|
||||||
publishedServer, err := registry.Publish(publishRequest)
|
publishedServer, err := registry.Publish(publishRequest)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, huma.Error500InternalServerError("Failed to publish server", err)
|
return nil, huma.Error400BadRequest("Failed to publish server", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Return the published server in extension wrapper format
|
// Return the published server in extension wrapper format
|
||||||
|
|
|
||||||
|
|
@ -99,10 +99,10 @@ func TestPublishIntegration(t *testing.T) {
|
||||||
assert.Equal(t, publishReq.Server.VersionDetail.Version, response.Server.VersionDetail.Version)
|
assert.Equal(t, publishReq.Server.VersionDetail.Version, response.Server.VersionDetail.Version)
|
||||||
})
|
})
|
||||||
|
|
||||||
t.Run("successful publish without auth (no prefix)", func(t *testing.T) {
|
t.Run("successful publish with none auth (no prefix)", func(t *testing.T) {
|
||||||
publishReq := model.PublishRequest{
|
publishReq := model.PublishRequest{
|
||||||
Server: model.ServerDetail{
|
Server: model.ServerDetail{
|
||||||
Name: "test-mcp-server-no-auth",
|
Name: "com.example/test-mcp-server-no-auth",
|
||||||
Description: "A test MCP server without authentication",
|
Description: "A test MCP server without authentication",
|
||||||
Repository: model.Repository{
|
Repository: model.Repository{
|
||||||
URL: "https://example.com/test-mcp-server",
|
URL: "https://example.com/test-mcp-server",
|
||||||
|
|
|
||||||
|
|
@ -203,9 +203,9 @@ func TestPublishEndpoint(t *testing.T) {
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
setupMocks: func(registry *MockRegistryService) {
|
setupMocks: func(registry *MockRegistryService) {
|
||||||
registry.On("Publish", mock.AnythingOfType("model.PublishRequest")).Return(nil, errors.New("database error"))
|
registry.On("Publish", mock.AnythingOfType("model.PublishRequest")).Return(nil, errors.New("cannot publish duplicate version"))
|
||||||
},
|
},
|
||||||
expectedStatus: http.StatusInternalServerError,
|
expectedStatus: http.StatusBadRequest,
|
||||||
expectedError: "Failed to publish server",
|
expectedError: "Failed to publish server",
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
|
||||||
|
|
@ -13,7 +13,7 @@ var (
|
||||||
ErrAlreadyExists = errors.New("record already exists")
|
ErrAlreadyExists = errors.New("record already exists")
|
||||||
ErrInvalidInput = errors.New("invalid input")
|
ErrInvalidInput = errors.New("invalid input")
|
||||||
ErrDatabase = errors.New("database error")
|
ErrDatabase = errors.New("database error")
|
||||||
ErrInvalidVersion = errors.New("invalid version: cannot publish older version after newer version")
|
ErrInvalidVersion = errors.New("invalid version: cannot publish duplicate version")
|
||||||
ErrMaxServersReached = errors.New("maximum number of versions for this server reached (10000): please reach out at https://github.com/modelcontextprotocol/registry to explain your use case")
|
ErrMaxServersReached = errors.New("maximum number of versions for this server reached (10000): please reach out at https://github.com/modelcontextprotocol/registry to explain your use case")
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -42,7 +42,7 @@ func NewMemoryDB(e map[string]*model.ServerDetail) *MemoryDB {
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
// List retrieves ServerRecord entries with optional filtering and pagination
|
//nolint:cyclop // Complexity from filtering logic is acceptable for memory implementation
|
||||||
func (db *MemoryDB) List(
|
func (db *MemoryDB) List(
|
||||||
ctx context.Context,
|
ctx context.Context,
|
||||||
filter map[string]any,
|
filter map[string]any,
|
||||||
|
|
@ -89,6 +89,18 @@ func (db *MemoryDB) List(
|
||||||
if string(entry.ServerJSON.Status) != value.(string) {
|
if string(entry.ServerJSON.Status) != value.(string) {
|
||||||
include = false
|
include = false
|
||||||
}
|
}
|
||||||
|
case "remote_url":
|
||||||
|
found := false
|
||||||
|
remoteURL := value.(string)
|
||||||
|
for _, remote := range entry.ServerJSON.Remotes {
|
||||||
|
if remote.URL == remoteURL {
|
||||||
|
found = true
|
||||||
|
break
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if !found {
|
||||||
|
include = false
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -76,6 +76,10 @@ func (db *PostgreSQL) List(
|
||||||
whereClause += fmt.Sprintf(" AND s.status = $%d", argIndex)
|
whereClause += fmt.Sprintf(" AND s.status = $%d", argIndex)
|
||||||
args = append(args, v)
|
args = append(args, v)
|
||||||
argIndex++
|
argIndex++
|
||||||
|
case "remote_url":
|
||||||
|
whereClause += fmt.Sprintf(" AND EXISTS (SELECT 1 FROM jsonb_array_elements(CASE WHEN jsonb_typeof(s.remotes) = 'array' THEN s.remotes ELSE '[]'::jsonb END) AS remote WHERE remote->>'url' = $%d)", argIndex)
|
||||||
|
args = append(args, v)
|
||||||
|
argIndex++
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -3,6 +3,9 @@ package model
|
||||||
import (
|
import (
|
||||||
"encoding/json"
|
"encoding/json"
|
||||||
"fmt"
|
"fmt"
|
||||||
|
"net/url"
|
||||||
|
"slices"
|
||||||
|
"strings"
|
||||||
"time"
|
"time"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|
@ -32,7 +35,6 @@ const (
|
||||||
ServerStatusDeprecated ServerStatus = "deprecated"
|
ServerStatusDeprecated ServerStatus = "deprecated"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
// Repository represents a source code repository as defined in the spec
|
// Repository represents a source code repository as defined in the spec
|
||||||
type Repository struct {
|
type Repository struct {
|
||||||
URL string `json:"url" bson:"url"`
|
URL string `json:"url" bson:"url"`
|
||||||
|
|
@ -40,7 +42,6 @@ type Repository struct {
|
||||||
ID string `json:"id,omitempty" bson:"id,omitempty"`
|
ID string `json:"id,omitempty" bson:"id,omitempty"`
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
// create an enum for Format
|
// create an enum for Format
|
||||||
type Format string
|
type Format string
|
||||||
|
|
||||||
|
|
@ -108,7 +109,6 @@ type VersionDetail struct {
|
||||||
Version string `json:"version" bson:"version"`
|
Version string `json:"version" bson:"version"`
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
// ServerDetail represents complete server information as defined in the MCP spec (pure, no registry metadata)
|
// ServerDetail represents complete server information as defined in the MCP spec (pure, no registry metadata)
|
||||||
type ServerDetail struct {
|
type ServerDetail struct {
|
||||||
Name string `json:"name" bson:"name"`
|
Name string `json:"name" bson:"name"`
|
||||||
|
|
@ -131,8 +131,8 @@ type RegistryMetadata struct {
|
||||||
|
|
||||||
// ServerRecord represents the complete storage model that separates server.json from registry metadata
|
// ServerRecord represents the complete storage model that separates server.json from registry metadata
|
||||||
type ServerRecord struct {
|
type ServerRecord struct {
|
||||||
ServerJSON ServerDetail `json:"server" bson:"server"` // Pure MCP server.json
|
ServerJSON ServerDetail `json:"server" bson:"server"` // Pure MCP server.json
|
||||||
RegistryMetadata RegistryMetadata `json:"registry_metadata" bson:"registry_metadata"` // Registry-generated data
|
RegistryMetadata RegistryMetadata `json:"registry_metadata" bson:"registry_metadata"` // Registry-generated data
|
||||||
PublisherExtensions map[string]interface{} `json:"publisher_extensions" bson:"publisher_extensions"` // x-publisher extensions
|
PublisherExtensions map[string]interface{} `json:"publisher_extensions" bson:"publisher_extensions"` // x-publisher extensions
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
@ -244,9 +244,101 @@ func ParseServerName(serverDetail ServerDetail) (string, error) {
|
||||||
if name == "" {
|
if name == "" {
|
||||||
return "", fmt.Errorf("server name is required and must be a string")
|
return "", fmt.Errorf("server name is required and must be a string")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Validate format: dns-namespace/name
|
||||||
|
if !strings.Contains(name, "/") {
|
||||||
|
return "", fmt.Errorf("server name must be in format 'dns-namespace/name' (e.g., 'com.example.api/server')")
|
||||||
|
}
|
||||||
|
|
||||||
|
parts := strings.SplitN(name, "/", 2)
|
||||||
|
if len(parts) != 2 || parts[0] == "" || parts[1] == "" {
|
||||||
|
return "", fmt.Errorf("server name must be in format 'dns-namespace/name' with non-empty namespace and name parts")
|
||||||
|
}
|
||||||
|
|
||||||
return name, nil
|
return name, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// ValidateRemoteNamespaceMatch validates that remote URLs match the reverse-DNS namespace
|
||||||
|
func ValidateRemoteNamespaceMatch(serverDetail ServerDetail) error {
|
||||||
|
namespace := serverDetail.Name
|
||||||
|
|
||||||
|
for _, remote := range serverDetail.Remotes {
|
||||||
|
if err := validateRemoteURLMatchesNamespace(remote.URL, namespace); err != nil {
|
||||||
|
return fmt.Errorf("remote URL %s does not match namespace %s: %w", remote.URL, namespace, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// validateRemoteURLMatchesNamespace checks if a remote URL's hostname matches the publisher domain from the namespace
|
||||||
|
func validateRemoteURLMatchesNamespace(remoteURL, namespace string) error {
|
||||||
|
// Parse the URL to extract the hostname
|
||||||
|
parsedURL, err := url.Parse(remoteURL)
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("invalid URL format: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
hostname := parsedURL.Hostname()
|
||||||
|
if hostname == "" {
|
||||||
|
return fmt.Errorf("URL must have a valid hostname")
|
||||||
|
}
|
||||||
|
|
||||||
|
// Skip validation for localhost and local development URLs
|
||||||
|
if hostname == "localhost" || strings.HasSuffix(hostname, ".localhost") || hostname == "127.0.0.1" {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// Extract publisher domain from reverse-DNS namespace
|
||||||
|
publisherDomain := extractPublisherDomainFromNamespace(namespace)
|
||||||
|
if publisherDomain == "" {
|
||||||
|
return fmt.Errorf("invalid namespace format: cannot extract domain from %s", namespace)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Check if the remote URL hostname matches the publisher domain or is a subdomain
|
||||||
|
if !isValidHostForDomain(hostname, publisherDomain) {
|
||||||
|
return fmt.Errorf("remote URL host %s does not match publisher domain %s", hostname, publisherDomain)
|
||||||
|
}
|
||||||
|
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// extractPublisherDomainFromNamespace converts reverse-DNS namespace to normal domain format
|
||||||
|
// e.g., "com.example" -> "example.com"
|
||||||
|
func extractPublisherDomainFromNamespace(namespace string) string {
|
||||||
|
// Extract the namespace part before the first slash
|
||||||
|
namespacePart := namespace
|
||||||
|
if slashIdx := strings.Index(namespace, "/"); slashIdx != -1 {
|
||||||
|
namespacePart = namespace[:slashIdx]
|
||||||
|
}
|
||||||
|
|
||||||
|
// Split into parts and reverse them to get normal domain format
|
||||||
|
parts := strings.Split(namespacePart, ".")
|
||||||
|
if len(parts) < 2 {
|
||||||
|
return ""
|
||||||
|
}
|
||||||
|
|
||||||
|
// Reverse the parts to convert from reverse-DNS to normal domain
|
||||||
|
slices.Reverse(parts)
|
||||||
|
|
||||||
|
return strings.Join(parts, ".")
|
||||||
|
}
|
||||||
|
|
||||||
|
// isValidHostForDomain checks if a hostname is the domain or a subdomain of the publisher domain
|
||||||
|
func isValidHostForDomain(hostname, publisherDomain string) bool {
|
||||||
|
// Exact match
|
||||||
|
if hostname == publisherDomain {
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
|
||||||
|
// Subdomain match - hostname should end with "." + publisherDomain
|
||||||
|
if strings.HasSuffix(hostname, "."+publisherDomain) {
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
|
||||||
// ToServerResponse converts a ServerRecord to API response format
|
// ToServerResponse converts a ServerRecord to API response format
|
||||||
func (sr *ServerRecord) ToServerResponse() ServerResponse {
|
func (sr *ServerRecord) ToServerResponse() ServerResponse {
|
||||||
response := ServerResponse{
|
response := ServerResponse{
|
||||||
|
|
|
||||||
|
|
@ -98,7 +98,7 @@ func TestExtractPublisherExtensions_DoesNotDoubleNest(t *testing.T) {
|
||||||
request := PublishRequest{
|
request := PublishRequest{
|
||||||
Server: ServerDetail{Name: "test"},
|
Server: ServerDetail{Name: "test"},
|
||||||
XPublisher: map[string]interface{}{
|
XPublisher: map[string]interface{}{
|
||||||
"tool": "publisher-cli",
|
"tool": "publisher-cli",
|
||||||
"version": "1.0.0",
|
"version": "1.0.0",
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
@ -263,3 +263,206 @@ func TestServerResponse_EmptyExtensions(t *testing.T) {
|
||||||
assert.Nil(t, publisherValue)
|
assert.Nil(t, publisherValue)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestValidateRemoteNamespaceMatch(t *testing.T) {
|
||||||
|
tests := []struct {
|
||||||
|
name string
|
||||||
|
serverDetail ServerDetail
|
||||||
|
expectError bool
|
||||||
|
errorMsg string
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
name: "valid match - example.com domain",
|
||||||
|
serverDetail: ServerDetail{
|
||||||
|
Name: "com.example/test-server",
|
||||||
|
Remotes: []Remote{
|
||||||
|
{URL: "https://example.com/mcp"},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectError: false,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "valid match - subdomain mcp.example.com",
|
||||||
|
serverDetail: ServerDetail{
|
||||||
|
Name: "com.example/test-server",
|
||||||
|
Remotes: []Remote{
|
||||||
|
{URL: "https://mcp.example.com/endpoint"},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectError: false,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "valid match - api subdomain",
|
||||||
|
serverDetail: ServerDetail{
|
||||||
|
Name: "com.example/api-server",
|
||||||
|
Remotes: []Remote{
|
||||||
|
{URL: "https://api.example.com/mcp"},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectError: false,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "invalid - wrong domain",
|
||||||
|
serverDetail: ServerDetail{
|
||||||
|
Name: "com.example/test-server",
|
||||||
|
Remotes: []Remote{
|
||||||
|
{URL: "https://google.com/mcp"},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectError: true,
|
||||||
|
errorMsg: "remote URL host google.com does not match publisher domain example.com",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "invalid - different domain entirely",
|
||||||
|
serverDetail: ServerDetail{
|
||||||
|
Name: "com.microsoft/server",
|
||||||
|
Remotes: []Remote{
|
||||||
|
{URL: "https://api.github.com/endpoint"},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectError: true,
|
||||||
|
errorMsg: "remote URL host api.github.com does not match publisher domain microsoft.com",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "localhost URLs allowed with any namespace",
|
||||||
|
serverDetail: ServerDetail{
|
||||||
|
Name: "com.example/test-server",
|
||||||
|
Remotes: []Remote{
|
||||||
|
{URL: "http://localhost:3000/sse"},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectError: false,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "invalid URL format",
|
||||||
|
serverDetail: ServerDetail{
|
||||||
|
Name: "com.example/test",
|
||||||
|
Remotes: []Remote{
|
||||||
|
{URL: "not-a-valid-url"},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectError: true,
|
||||||
|
errorMsg: "URL must have a valid hostname",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "empty remotes array",
|
||||||
|
serverDetail: ServerDetail{
|
||||||
|
Name: "com.example/test",
|
||||||
|
Remotes: []Remote{},
|
||||||
|
},
|
||||||
|
expectError: false,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "multiple valid remotes - different subdomains",
|
||||||
|
serverDetail: ServerDetail{
|
||||||
|
Name: "com.example/server",
|
||||||
|
Remotes: []Remote{
|
||||||
|
{URL: "https://api.example.com/sse"},
|
||||||
|
{URL: "https://mcp.example.com/websocket"},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectError: false,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "one valid, one invalid remote",
|
||||||
|
serverDetail: ServerDetail{
|
||||||
|
Name: "com.example/server",
|
||||||
|
Remotes: []Remote{
|
||||||
|
{URL: "https://example.com/sse"},
|
||||||
|
{URL: "https://google.com/websocket"},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectError: true,
|
||||||
|
errorMsg: "remote URL host google.com does not match publisher domain example.com",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tt := range tests {
|
||||||
|
t.Run(tt.name, func(t *testing.T) {
|
||||||
|
err := ValidateRemoteNamespaceMatch(tt.serverDetail)
|
||||||
|
|
||||||
|
if tt.expectError {
|
||||||
|
assert.Error(t, err)
|
||||||
|
assert.Contains(t, err.Error(), tt.errorMsg)
|
||||||
|
} else {
|
||||||
|
assert.NoError(t, err)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestParseServerName(t *testing.T) {
|
||||||
|
tests := []struct {
|
||||||
|
name string
|
||||||
|
serverDetail ServerDetail
|
||||||
|
expectError bool
|
||||||
|
errorMsg string
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
name: "valid namespace/name format",
|
||||||
|
serverDetail: ServerDetail{
|
||||||
|
Name: "com.example.api/server",
|
||||||
|
},
|
||||||
|
expectError: false,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "valid complex namespace",
|
||||||
|
serverDetail: ServerDetail{
|
||||||
|
Name: "com.github.microsoft.azure/webapp-server",
|
||||||
|
},
|
||||||
|
expectError: false,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "empty server name",
|
||||||
|
serverDetail: ServerDetail{
|
||||||
|
Name: "",
|
||||||
|
},
|
||||||
|
expectError: true,
|
||||||
|
errorMsg: "server name is required",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "missing slash separator",
|
||||||
|
serverDetail: ServerDetail{
|
||||||
|
Name: "com.example.server",
|
||||||
|
},
|
||||||
|
expectError: true,
|
||||||
|
errorMsg: "server name must be in format 'dns-namespace/name'",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "empty namespace part",
|
||||||
|
serverDetail: ServerDetail{
|
||||||
|
Name: "/server-name",
|
||||||
|
},
|
||||||
|
expectError: true,
|
||||||
|
errorMsg: "non-empty namespace and name parts",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "empty name part",
|
||||||
|
serverDetail: ServerDetail{
|
||||||
|
Name: "com.example/",
|
||||||
|
},
|
||||||
|
expectError: true,
|
||||||
|
errorMsg: "non-empty namespace and name parts",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "multiple slashes - uses first as separator",
|
||||||
|
serverDetail: ServerDetail{
|
||||||
|
Name: "com.example/server/path",
|
||||||
|
},
|
||||||
|
expectError: false,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tt := range tests {
|
||||||
|
t.Run(tt.name, func(t *testing.T) {
|
||||||
|
_, err := ParseServerName(tt.serverDetail)
|
||||||
|
|
||||||
|
if tt.expectError {
|
||||||
|
assert.Error(t, err)
|
||||||
|
assert.Contains(t, err.Error(), tt.errorMsg)
|
||||||
|
} else {
|
||||||
|
assert.NoError(t, err)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
|
||||||
|
|
@ -3,6 +3,7 @@ package service
|
||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
"errors"
|
"errors"
|
||||||
|
"fmt"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"github.com/google/uuid"
|
"github.com/google/uuid"
|
||||||
|
|
@ -78,11 +79,21 @@ func (s *registryServiceImpl) Publish(req model.PublishRequest) (*model.ServerRe
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
|
|
||||||
// Validate server name exists
|
// Validate server name exists and format
|
||||||
if _, err := model.ParseServerName(req.Server); err != nil {
|
if _, err := model.ParseServerName(req.Server); err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Validate reverse-DNS namespace matching for remote URLs
|
||||||
|
if err := model.ValidateRemoteNamespaceMatch(req.Server); err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
|
||||||
|
// Check for duplicate remote URLs
|
||||||
|
if err := s.validateNoDuplicateRemoteURLs(ctx, req.Server); err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
|
||||||
// Get the new version's details
|
// Get the new version's details
|
||||||
newVersion := req.Server.VersionDetail.Version
|
newVersion := req.Server.VersionDetail.Version
|
||||||
newName := req.Server.Name
|
newName := req.Server.Name
|
||||||
|
|
@ -154,3 +165,28 @@ func (s *registryServiceImpl) Publish(req model.PublishRequest) (*model.ServerRe
|
||||||
response := serverRecord.ToServerResponse()
|
response := serverRecord.ToServerResponse()
|
||||||
return &response, nil
|
return &response, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// validateNoDuplicateRemoteURLs checks that no other server is using the same remote URLs
|
||||||
|
func (s *registryServiceImpl) validateNoDuplicateRemoteURLs(ctx context.Context, serverDetail model.ServerDetail) error {
|
||||||
|
// Check each remote URL in the new server for conflicts
|
||||||
|
for _, remote := range serverDetail.Remotes {
|
||||||
|
// Use filter to find servers with this remote URL
|
||||||
|
filter := map[string]any{
|
||||||
|
"remote_url": remote.URL,
|
||||||
|
}
|
||||||
|
|
||||||
|
conflictingServers, _, err := s.db.List(ctx, filter, "", 1000)
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("failed to check remote URL conflict: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Check if any conflicting server has a different name
|
||||||
|
for _, conflictingServer := range conflictingServers {
|
||||||
|
if conflictingServer.ServerJSON.Name != serverDetail.Name {
|
||||||
|
return fmt.Errorf("remote URL %s is already used by server %s", remote.URL, conflictingServer.ServerJSON.Name)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
|
||||||
121
internal/service/registry_service_test.go
Normal file
121
internal/service/registry_service_test.go
Normal file
|
|
@ -0,0 +1,121 @@
|
||||||
|
//nolint:testpackage
|
||||||
|
package service
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"testing"
|
||||||
|
|
||||||
|
"github.com/modelcontextprotocol/registry/internal/database"
|
||||||
|
"github.com/modelcontextprotocol/registry/internal/model"
|
||||||
|
"github.com/stretchr/testify/assert"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestValidateNoDuplicateRemoteURLs(t *testing.T) {
|
||||||
|
// Create test data
|
||||||
|
existingServers := map[string]*model.ServerDetail{
|
||||||
|
"existing1": {
|
||||||
|
Name: "com.example/existing-server",
|
||||||
|
Description: "An existing server",
|
||||||
|
VersionDetail: model.VersionDetail{
|
||||||
|
Version: "1.0.0",
|
||||||
|
},
|
||||||
|
Remotes: []model.Remote{
|
||||||
|
{URL: "https://api.example.com/mcp"},
|
||||||
|
{URL: "https://webhook.example.com/sse"},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
"existing2": {
|
||||||
|
Name: "com.microsoft/another-server",
|
||||||
|
Description: "Another existing server",
|
||||||
|
VersionDetail: model.VersionDetail{
|
||||||
|
Version: "1.0.0",
|
||||||
|
},
|
||||||
|
Remotes: []model.Remote{
|
||||||
|
{URL: "https://api.microsoft.com/mcp"},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
memDB := database.NewMemoryDB(existingServers)
|
||||||
|
service := NewRegistryServiceWithDB(memDB)
|
||||||
|
|
||||||
|
tests := []struct {
|
||||||
|
name string
|
||||||
|
serverDetail model.ServerDetail
|
||||||
|
expectError bool
|
||||||
|
errorMsg string
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
name: "no remote URLs - should pass",
|
||||||
|
serverDetail: model.ServerDetail{
|
||||||
|
Name: "com.example/new-server",
|
||||||
|
Description: "A new server with no remotes",
|
||||||
|
VersionDetail: model.VersionDetail{
|
||||||
|
Version: "1.0.0",
|
||||||
|
},
|
||||||
|
Remotes: []model.Remote{},
|
||||||
|
},
|
||||||
|
expectError: false,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "new unique remote URLs - should pass",
|
||||||
|
serverDetail: model.ServerDetail{
|
||||||
|
Name: "com.example/new-server",
|
||||||
|
Description: "A new server",
|
||||||
|
VersionDetail: model.VersionDetail{
|
||||||
|
Version: "1.0.0",
|
||||||
|
},
|
||||||
|
Remotes: []model.Remote{
|
||||||
|
{URL: "https://new.example.com/mcp"},
|
||||||
|
{URL: "https://unique.example.com/sse"},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectError: false,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "duplicate remote URL - should fail",
|
||||||
|
serverDetail: model.ServerDetail{
|
||||||
|
Name: "com.example/new-server",
|
||||||
|
Description: "A new server with duplicate URL",
|
||||||
|
VersionDetail: model.VersionDetail{
|
||||||
|
Version: "1.0.0",
|
||||||
|
},
|
||||||
|
Remotes: []model.Remote{
|
||||||
|
{URL: "https://api.example.com/mcp"}, // This URL already exists
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectError: true,
|
||||||
|
errorMsg: "remote URL https://api.example.com/mcp is already used by server com.example/existing-server",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "updating same server with same URLs - should pass",
|
||||||
|
serverDetail: model.ServerDetail{
|
||||||
|
Name: "com.example/existing-server", // Same name as existing
|
||||||
|
Description: "Updated existing server",
|
||||||
|
VersionDetail: model.VersionDetail{
|
||||||
|
Version: "1.1.0",
|
||||||
|
},
|
||||||
|
Remotes: []model.Remote{
|
||||||
|
{URL: "https://api.example.com/mcp"}, // Same URL as before
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectError: false,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tt := range tests {
|
||||||
|
t.Run(tt.name, func(t *testing.T) {
|
||||||
|
ctx := context.Background()
|
||||||
|
impl := service.(*registryServiceImpl)
|
||||||
|
|
||||||
|
err := impl.validateNoDuplicateRemoteURLs(ctx, tt.serverDetail)
|
||||||
|
|
||||||
|
if tt.expectError {
|
||||||
|
assert.Error(t, err)
|
||||||
|
assert.Contains(t, err.Error(), tt.errorMsg)
|
||||||
|
} else {
|
||||||
|
assert.NoError(t, err)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
Loading…
Reference in a new issue