From be6c2d9142d718c4c62a01c06696733b5d5d6974 Mon Sep 17 00:00:00 2001 From: adam jones Date: Mon, 8 Sep 2025 13:40:22 -0700 Subject: [PATCH] Add security warnings to Argument schema definition (#371) ## Summary - Add comprehensive security warnings to the `Argument` type in server.schema.json - Warn about command injection risks from user-provided input in arguments - Include concrete example of malicious payload (`;rm -rf ~/Development`) - Recommend non-shell execution methods and user consent for safer command execution Fixes #41 --- docs/reference/server-json/server.schema.json | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/reference/server-json/server.schema.json b/docs/reference/server-json/server.schema.json index 573b26a..319dfb7 100644 --- a/docs/reference/server-json/server.schema.json +++ b/docs/reference/server-json/server.schema.json @@ -330,6 +330,7 @@ ] }, "Argument": { + "description": "Warning: Arguments construct command-line parameters that may contain user-provided input. This creates potential command injection risks if clients execute commands in a shell environment. For example, a malicious argument value like ';rm -rf ~/Development' could execute dangerous commands. Clients should prefer non-shell execution methods (e.g., posix_spawn) when possible to eliminate injection risks entirely. Where not possible, clients should obtain consent from users or agents to run the resolved command before execution.", "anyOf": [ { "$ref": "#/$defs/PositionalArgument"