From ddd694acdfb24bccc7a7f50aebda2d6de8ef95b2 Mon Sep 17 00:00:00 2001 From: Radoslav Dimitrov Date: Tue, 14 Oct 2025 19:33:19 +0300 Subject: [PATCH] Fix the image reference for prod: from v1.3.0 to 1.3.0 (#669) ## Motivation and Context The following PR fixes the docs and the image reference for prod since they don't expect to have the v prefix there. ## How Has This Been Tested? ## Breaking Changes ## Types of changes - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update ## Checklist - [ ] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [ ] My code follows the repository's style guidelines - [ ] New and existing tests pass locally - [ ] I have added appropriate error handling - [ ] I have added or updated documentation as needed ## Additional context --------- Signed-off-by: Radoslav Dimitrov --- deploy/Pulumi.gcpProd.yaml | 2 +- deploy/README.md | 6 +++--- docs/guides/contributing/releasing.md | 10 ++++++---- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/deploy/Pulumi.gcpProd.yaml b/deploy/Pulumi.gcpProd.yaml index 6d78e52..2260e2f 100644 --- a/deploy/Pulumi.gcpProd.yaml +++ b/deploy/Pulumi.gcpProd.yaml @@ -1,7 +1,7 @@ config: mcp-registry:environment: prod mcp-registry:provider: gcp - mcp-registry:imageTag: v1.3.0 # Set specific image tag for production (change this to deploy different versions) + mcp-registry:imageTag: 1.3.0 # Set specific image tag for production (change this to deploy different versions) gcp:project: mcp-registry-prod mcp-registry:githubClientId: Iv23liUydBbI7Z2Q9bOZ mcp-registry:githubClientSecret: diff --git a/deploy/README.md b/deploy/README.md index b8da9e1..3125d61 100644 --- a/deploy/README.md +++ b/deploy/README.md @@ -43,14 +43,14 @@ PULUMI_CONFIG_PASSPHRASE="" pulumi config set mcp-registry:githubClientSecret -- # Or via gh CLI: gh release create v1.2.3 --generate-notes ``` - This builds Docker images tagged as `v1.2.3` and `latest` + This builds Docker images tagged as `1.2.3` and `latest` (note: image tags do not include the 'v' prefix) 2. Update the production image tag in `Pulumi.gcpProd.yaml`: ```bash # Edit deploy/Pulumi.gcpProd.yaml - # Change line: mcp-registry:imageTag: v1.2.3 + # Change line: mcp-registry:imageTag: 1.2.3 (note: no 'v' prefix for Docker image tags) git add deploy/Pulumi.gcpProd.yaml - git commit -m "Deploy v1.2.3 to production" + git commit -m "Deploy version 1.2.3 to production" git push ``` diff --git a/docs/guides/contributing/releasing.md b/docs/guides/contributing/releasing.md index 470cb12..f0f5b03 100644 --- a/docs/guides/contributing/releasing.md +++ b/docs/guides/contributing/releasing.md @@ -10,7 +10,7 @@ The release workflow will automatically: - Build binaries for 6 platforms (Linux, macOS, Windows × amd64, arm64) -- Create and push Docker images with `:latest` and `:vX.Y.Z` tags +- Create and push Docker images with `:latest` and `:X.Y.Z` tags (note: no 'v' prefix) - Attach all artifacts to the GitHub release - Generate checksums and signatures @@ -18,12 +18,12 @@ The release workflow will automatically: - Docker images will be available at: - `ghcr.io/modelcontextprotocol/registry:latest` - Latest stable release - - `ghcr.io/modelcontextprotocol/registry:vX.Y.Z` - Specific release version + - `ghcr.io/modelcontextprotocol/registry:X.Y.Z` - Specific release version (note: no 'v' prefix) - Binaries can be downloaded from the GitHub release page **Note:** Releases do not automatically deploy to production. To deploy a release to production: -1. Update `mcp-registry:imageTag` in `deploy/Pulumi.gcpProd.yaml` to the desired version (e.g., `v1.2.3`) +1. Update `mcp-registry:imageTag` in `deploy/Pulumi.gcpProd.yaml` to the desired version (e.g., `1.2.3` - note: no 'v' prefix) 2. Commit and push the change to the `main` branch 3. The [deploy-production.yml](../../../.github/workflows/deploy-production.yml) workflow will automatically trigger and deploy the specified version @@ -34,10 +34,12 @@ See the [deployment documentation](../../../deploy/README.md) for more details. The registry publishes different Docker image tags for different use cases: - **`:latest`** - Latest stable release (updated only on releases) -- **`:vX.Y.Z`** - Specific release versions (e.g., `:v1.0.0`) +- **`:X.Y.Z`** - Specific release versions (e.g., `:1.0.0` - note: no 'v' prefix) - **`:main`** - Rolling tag updated on every push to main branch (continuous deployment) - **`:main-YYYYMMDD-sha`** - Specific development builds from main branch +**Note:** Git release tags include the 'v' prefix (e.g., `v1.0.0`), but Docker image tags follow the standard Docker convention and do not include the 'v' prefix (e.g., `1.0.0`). + ## Versioning We use semantic versioning (SemVer):